fix(preprocessor): mark getCode as view in VmContractHelper#13089
Merged
grandizzy merged 1 commit intofoundry-rs:masterfrom Jan 15, 2026
Merged
fix(preprocessor): mark getCode as view in VmContractHelper#13089grandizzy merged 1 commit intofoundry-rs:masterfrom
grandizzy merged 1 commit intofoundry-rs:masterfrom
Conversation
When using `type(Contract).creationCode` in test files with dynamic linking, Foundry transforms it to `VmContractHelper.getCode()`. The generated interface was missing the `view` modifier, which broke view function compatibility. Fixes foundry-rs#13086
grandizzy
requested review from
0xrusowsky,
DaniPopes,
mattsse,
onbjerg and
zerosnacks
as code owners
mattsse
approved these changes
Jan 14, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using
type(Contract).creationCodein test files withdynamic_test_linking = true, Foundry transforms it toVmContractHelper.getCode(). The generated interface was missing theviewmodifier, which brokeviewfunction compatibility.Fix
Added
viewmodifier to thegetCodefunction in the generatedVmContractHelperinterface.Test
Added
preprocess_creation_code_in_view_functiontest to verifytype(Contract).creationCodeworks inviewfunctions with dynamic linking.Fixes #13086