Deduplicate call input lookup in inspector stack#13032
Closed
splinter012 wants to merge 2 commits intofoundry-rs:masterfrom
Closed
Deduplicate call input lookup in inspector stack#13032splinter012 wants to merge 2 commits intofoundry-rs:masterfrom
splinter012 wants to merge 2 commits intofoundry-rs:masterfrom
Conversation
splinter012
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
DaniPopes
reviewed
Jan 9, 2026
|
|
||
| if let Some(cheatcodes) = self.cheatcodes.as_deref_mut() { | ||
| // Handle mocked functions, replace bytecode address with mock if matched. | ||
| let input_bytes = call.input.bytes(ecx); |
Member
There was a problem hiding this comment.
wrong scope, move down one line
onbjerg
requested changes
Jan 9, 2026
Member
onbjerg
left a comment
onbjerg
left a comment
There was a problem hiding this comment.
please make sure your prs are formatted using rustmft
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove double call.input.bytes(ecx) by caching input_bytes when resolving mocked functions; behavior unchanged, avoids redundant work/allocation. Scope: foundry/crates/evm/evm/src/inspectors/stack.rs.