feat: uncomment transaction replacement test#13029
Merged
onbjerg merged 3 commits intofoundry-rs:masterfrom Jan 9, 2026
Merged
feat: uncomment transaction replacement test#13029onbjerg merged 3 commits intofoundry-rs:masterfrom
onbjerg merged 3 commits intofoundry-rs:masterfrom
Conversation
echowandere
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
Member
|
doesn't compile |
… it never gets mined.
Contributor
Author
All good now, removed the attempt to get receipt for the replaced transaction since it never gets mined. |
onbjerg
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FIXME referenced alloy-rs/alloy#614 which was merged back in April 2024. Since we're now on alloy 1.1.3, the receipt polling issue has been fixed for a while.
Restored the test assertions with a small fix - removed the attempt to get receipt for the replaced transaction since it never gets mined.