Conversation
onbjerg
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse and
zerosnacks
as code owners
DaniPopes
reviewed
Jan 8, 2026
Member
DaniPopes
left a comment
DaniPopes
left a comment
There was a problem hiding this comment.
these might be used externally
Member
Author
|
which ones? there are some that we can def remove because there are equivalents in alloy (e.g. base fee calc) |
Member
|
idk maybe the inspect. @mattsse thoughts |
mattsse
previously requested changes
Jan 8, 2026
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
I'd rather do this on a case by case basis, keeping the pub fn doesnt really hurt
onbjerg
commented
Jan 8, 2026
Comment on lines
-2797
to
-2804
| /// Sets the reported block number | ||
| /// | ||
| /// Handler for ETH RPC call: `anvil_setBlock` | ||
| pub fn anvil_set_block(&self, block_number: u64) -> Result<()> { | ||
| node_info!("anvil_setBlock"); | ||
| self.backend.set_block_number(block_number); | ||
| Ok(()) | ||
| } |
Member
Author
There was a problem hiding this comment.
i think we should also remove this then if we are doing case by case, this is entirely unused. there is no anvil_setBlock @mattsse
onbjerg
force-pushed
the
onbjerg/push-lmxtztozykqk
branch
from
0d83cb4 to
3f74352
Compare
DaniPopes
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Cleanup
Solution
Remove dead/unused code.
PR Checklist