feat: add support for constructing tempo tx#12972
Merged
Conversation
onbjerg
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse and
zerosnacks
as code owners
3 tasks
onbjerg
force-pushed
the
onbjerg/prim-tempo-req
branch
from
e360413 to
a8e17b4
Compare
0xrusowsky
approved these changes
Jan 2, 2026
Comment on lines
+50
to
+54
| /// Consume self and return the inner [`WithOtherFields<TransactionRequest>`]. | ||
| #[inline] | ||
| pub fn into_inner(self) -> WithOtherFields<TransactionRequest> { | ||
| self.0 | ||
| } |
Contributor
There was a problem hiding this comment.
just flagging that this method seems to be unused in the PR.
good to leave it for convenience of potential future consumers, though.
DaniPopes
approved these changes
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to add support for constructing Tempo transactions in e.g. Cast. This requires support in the primitives crate, which this PR adds.
PR Checklist