fix(forge): Ignore file access events to prevent rebuild loop#10763
Merged
zerosnacks merged 1 commit intofoundry-rs:masterfrom Jun 12, 2025
Merged
fix(forge): Ignore file access events to prevent rebuild loop#10763zerosnacks merged 1 commit intofoundry-rs:masterfrom
zerosnacks merged 1 commit intofoundry-rs:masterfrom
Conversation
This fixes an issue introduced by notify-rs/notify#612, where `OPEN` events are now reported on Linux. As a result, file access (e.g., reading a file) triggers spurious change notifications, causing the compilation process to restart repeatedly. To resolve this, we explicitly filter out `OPEN` (access) events during event processing.
joeblogg801
requested review from
DaniPopes,
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
zerosnacks
approved these changes
Jun 12, 2025
Member
There was a problem hiding this comment.
Thanks @joeblogg801 the implementation looks good and confirming it works as expected
Checked together w/ @grandizzy
Contributor
Author
|
Thanks! Happy to contribute 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10762
Motivation
This fixes an issue introduced by notify-rs/notify#612, where
OPENevents are now reported on Linux. As a result, file access (e.g., reading a file) triggers spurious change notifications, causing the compilation process to restart repeatedly.Solution
To resolve this, we explicitly ignore Access(Open) events during event processing.
PR Checklist