Skip to content

[FIO extras] fiovb: return error on init if board not closed#68

Merged
Tim-Anderson merged 1 commit intofoundriesio:2020.04+fiofrom
Tim-Anderson:fiovb_init_return_error
Jun 10, 2021
Merged

[FIO extras] fiovb: return error on init if board not closed#68
Tim-Anderson merged 1 commit intofoundriesio:2020.04+fiofrom
Tim-Anderson:fiovb_init_return_error

Conversation

@Tim-Anderson
Copy link
Copy Markdown

Signed-off-by: Tim Anderson [email protected]

Please do not submit a Pull Request via github. Our project makes use of
mailing lists for patch submission and review. For more details please
see https://www.denx.de/wiki/U-Boot/Patches

@igoropaniuk
Copy link
Copy Markdown

igoropaniuk commented Jun 9, 2021

@Tim-Anderson I think that will break non-imx boards, and also imx7ulp, as boot_mode_is_closed is not defined for that boards

@Tim-Anderson Tim-Anderson force-pushed the fiovb_init_return_error branch from 86fc607 to f1c7678 Compare June 9, 2021 18:35
Copy link
Copy Markdown

@igoropaniuk igoropaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardosalveti
Copy link
Copy Markdown
Member

@Tim-Anderson I think that will break non-imx boards, and also imx7ulp, as boot_mode_is_closed is not defined for that boards

@Tim-Anderson can you make sure we also implement boot_mode_is_closed for 7ulp? Otherwise this will bite us as @vanmaegima updates 7ulp to the latest.

Copy link
Copy Markdown
Member

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tim-Anderson Tim-Anderson merged commit c25fa73 into foundriesio:2020.04+fio Jun 10, 2021
@Tim-Anderson Tim-Anderson deleted the fiovb_init_return_error branch June 10, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants