Skip to content

build with clang toolchain by default#704

Merged
ricardosalveti merged 1 commit intofoundriesio:mainfrom
quaresmajose:clang
Sep 20, 2022
Merged

build with clang toolchain by default#704
ricardosalveti merged 1 commit intofoundriesio:mainfrom
quaresmajose:clang

Conversation

@quaresmajose
Copy link
Copy Markdown
Member

@quaresmajose quaresmajose commented Jun 29, 2022

base: lmp: build with clang toolchain by default

For recipes that doesn't build we can go back to gcc toolchain
with TOOLCHAIN:pn-recipes = "gcc" in main local.conf or
TOOLCHAIN = "gcc" on himself in a bbappend

Depends on #705

@quaresmajose quaresmajose marked this pull request as ready for review June 29, 2022 18:58
@ricardosalveti
Copy link
Copy Markdown
Member

Nice, would you mind breaking this down into 2 prs? One for adding all the clang stuff and another for enabling it as the default toolchain?

@quaresmajose
Copy link
Copy Markdown
Member Author

Sure I will split it

@quaresmajose quaresmajose changed the title enable the clang toolchain build with clang toolchain by default Jun 30, 2022
@quaresmajose quaresmajose force-pushed the clang branch 2 times, most recently from fd132c4 to d323b6a Compare July 5, 2022 09:53
@MrCry0 MrCry0 self-requested a review July 5, 2022 10:09
Copy link
Copy Markdown
Contributor

@angolini angolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I like the errors as comments, but I think I understand where they come from and I don't think they hurt, so LGTM

@quaresmajose
Copy link
Copy Markdown
Member Author

I'm not sure I like the errors as comments, but I think I understand where they come from and I don't think they hurt, so LGTM

The reason for the errors in the commands comes from the upstream
https://github.com/kraj/meta-clang/blob/master/conf/nonclangable.conf

Maybe I should put this one in draft because it only contain the last commit and all the others comes from #705

@quaresmajose quaresmajose marked this pull request as draft July 5, 2022 13:43
@quaresmajose quaresmajose marked this pull request as ready for review July 5, 2022 21:28
For recipes that doesn't build we can go back to gcc toolchain
with TOOLCHAIN:pn-recipes = "gcc" in main local.conf or
TOOLCHAIN = "gcc" on himself in a bbappend

Signed-off-by: Jose Quaresma <[email protected]>
Copy link
Copy Markdown
Member

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and here we go :-)

@ricardosalveti ricardosalveti merged commit 689e544 into foundriesio:main Sep 20, 2022
@quaresmajose quaresmajose deleted the clang branch September 20, 2022 14:58
angolini added a commit that referenced this pull request Feb 28, 2025
Relevant changes:
- 5ff4cf4d61e1 Merge pull request #713 from angolini/fix_imx93
- e587f8fe42f1 firmware: se_fw: remove info_list from ro section
- a0609cb5220a Merge pull request #712 from angolini/push_one
- 0f638960dcff media: Kconfig: fix double VIDEO_DEV
- 226bfffe04bc Merge pull request #709 from fs-csenatore/6.6-2.2.x-imx
- 198242c057e0 drivers:clk:imx:clk-imx8mp-audiomix: remove duplicated CLK_GATE_PARENT definition
- 427223e3206d Merge pull request #707 from iceaway/revert_u-serial_patch
- 4f5936d7391f Revert "usb: gadget: u_serial: Disable ep before setting port to null to fix the crash caused by port being null"
- 00aabf3c03c3 Merge pull request #705 from unitexe/6.6-2.2.x-imx
- 997b7e13e413 imx8mp-olimex.dts: Olimex iMX8MP-SOM-EVB-IND
- 2a0fc42db4d4 Merge pull request #704 from ernestvh/6.6-2.2.x-imx-forward-port
- b746c990ecba Revert "LF-12740: mxc: vpu: hantro_v4l2: report performance statistics"
- e349e6c45a94 arm64: imx_v8_defconfig: Enable CONFIG_GPIO_VF610
- 5a015324eddc arm64: dts: imx8qm: add missing imx8-ss-cm40.dtsi include
- 8a8245d395d5 arm64: dts: imx8: img: add #address-cells and #size-cells to I2C MIPI CSI nodes
- db13648c4be6 fw: imx: seco_mu: change dev_err to dev_err_probe for -EPROBE_DEFER
- 0451236fd0ae clk: imx: imx8qm: add more resources to whitelist
- 2ee789512d1b drm/imx: lcdifv3: Fix videomode settings
- 5cd4c30ec228 i2c: imx: Remove unnecessary clock reconfiguration
- 583f2a703c5d tty: vt: conmakehash: remove non-portable code printing comment header
- 4ddc4dae8515 tty: vt: conmakehash: cope with abs_srctree no longer in env
- 46a05495bce3 drm: of: Fix build without CONFIG_OF

Signed-off-by: Daiane Angolini <[email protected]>
angolini added a commit that referenced this pull request Feb 28, 2025
Relevant changes:
- 5ff4cf4d61e1 Merge pull request #713 from angolini/fix_imx93
- e587f8fe42f1 firmware: se_fw: remove info_list from ro section
- a0609cb5220a Merge pull request #712 from angolini/push_one
- 0f638960dcff media: Kconfig: fix double VIDEO_DEV
- 226bfffe04bc Merge pull request #709 from fs-csenatore/6.6-2.2.x-imx
- 198242c057e0 drivers:clk:imx:clk-imx8mp-audiomix: remove duplicated CLK_GATE_PARENT definition
- 427223e3206d Merge pull request #707 from iceaway/revert_u-serial_patch
- 4f5936d7391f Revert "usb: gadget: u_serial: Disable ep before setting port to null to fix the crash caused by port being null"
- 00aabf3c03c3 Merge pull request #705 from unitexe/6.6-2.2.x-imx
- 997b7e13e413 imx8mp-olimex.dts: Olimex iMX8MP-SOM-EVB-IND
- 2a0fc42db4d4 Merge pull request #704 from ernestvh/6.6-2.2.x-imx-forward-port
- b746c990ecba Revert "LF-12740: mxc: vpu: hantro_v4l2: report performance statistics"
- e349e6c45a94 arm64: imx_v8_defconfig: Enable CONFIG_GPIO_VF610
- 5a015324eddc arm64: dts: imx8qm: add missing imx8-ss-cm40.dtsi include
- 8a8245d395d5 arm64: dts: imx8: img: add #address-cells and #size-cells to I2C MIPI CSI nodes
- db13648c4be6 fw: imx: seco_mu: change dev_err to dev_err_probe for -EPROBE_DEFER
- 0451236fd0ae clk: imx: imx8qm: add more resources to whitelist
- 2ee789512d1b drm/imx: lcdifv3: Fix videomode settings
- 5cd4c30ec228 i2c: imx: Remove unnecessary clock reconfiguration
- 583f2a703c5d tty: vt: conmakehash: remove non-portable code printing comment header
- 4ddc4dae8515 tty: vt: conmakehash: cope with abs_srctree no longer in env
- 46a05495bce3 drm: of: Fix build without CONFIG_OF

Signed-off-by: Daiane Angolini <[email protected]>
quaresmajose pushed a commit to quaresmajose/meta-lmp that referenced this pull request Mar 5, 2025
Relevant changes:
- 5ff4cf4d61e1 Merge pull request foundriesio#713 from angolini/fix_imx93
- e587f8fe42f1 firmware: se_fw: remove info_list from ro section
- a0609cb5220a Merge pull request foundriesio#712 from angolini/push_one
- 0f638960dcff media: Kconfig: fix double VIDEO_DEV
- 226bfffe04bc Merge pull request foundriesio#709 from fs-csenatore/6.6-2.2.x-imx
- 198242c057e0 drivers:clk:imx:clk-imx8mp-audiomix: remove duplicated CLK_GATE_PARENT definition
- 427223e3206d Merge pull request foundriesio#707 from iceaway/revert_u-serial_patch
- 4f5936d7391f Revert "usb: gadget: u_serial: Disable ep before setting port to null to fix the crash caused by port being null"
- 00aabf3c03c3 Merge pull request foundriesio#705 from unitexe/6.6-2.2.x-imx
- 997b7e13e413 imx8mp-olimex.dts: Olimex iMX8MP-SOM-EVB-IND
- 2a0fc42db4d4 Merge pull request foundriesio#704 from ernestvh/6.6-2.2.x-imx-forward-port
- b746c990ecba Revert "LF-12740: mxc: vpu: hantro_v4l2: report performance statistics"
- e349e6c45a94 arm64: imx_v8_defconfig: Enable CONFIG_GPIO_VF610
- 5a015324eddc arm64: dts: imx8qm: add missing imx8-ss-cm40.dtsi include
- 8a8245d395d5 arm64: dts: imx8: img: add #address-cells and #size-cells to I2C MIPI CSI nodes
- db13648c4be6 fw: imx: seco_mu: change dev_err to dev_err_probe for -EPROBE_DEFER
- 0451236fd0ae clk: imx: imx8qm: add more resources to whitelist
- 2ee789512d1b drm/imx: lcdifv3: Fix videomode settings
- 5cd4c30ec228 i2c: imx: Remove unnecessary clock reconfiguration
- 583f2a703c5d tty: vt: conmakehash: remove non-portable code printing comment header
- 4ddc4dae8515 tty: vt: conmakehash: cope with abs_srctree no longer in env
- 46a05495bce3 drm: of: Fix build without CONFIG_OF

Signed-off-by: Daiane Angolini <[email protected]>
Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose pushed a commit that referenced this pull request Mar 6, 2025
Relevant changes:
- 5ff4cf4d61e1 Merge pull request #713 from angolini/fix_imx93
- e587f8fe42f1 firmware: se_fw: remove info_list from ro section
- a0609cb5220a Merge pull request #712 from angolini/push_one
- 0f638960dcff media: Kconfig: fix double VIDEO_DEV
- 226bfffe04bc Merge pull request #709 from fs-csenatore/6.6-2.2.x-imx
- 198242c057e0 drivers:clk:imx:clk-imx8mp-audiomix: remove duplicated CLK_GATE_PARENT definition
- 427223e3206d Merge pull request #707 from iceaway/revert_u-serial_patch
- 4f5936d7391f Revert "usb: gadget: u_serial: Disable ep before setting port to null to fix the crash caused by port being null"
- 00aabf3c03c3 Merge pull request #705 from unitexe/6.6-2.2.x-imx
- 997b7e13e413 imx8mp-olimex.dts: Olimex iMX8MP-SOM-EVB-IND
- 2a0fc42db4d4 Merge pull request #704 from ernestvh/6.6-2.2.x-imx-forward-port
- b746c990ecba Revert "LF-12740: mxc: vpu: hantro_v4l2: report performance statistics"
- e349e6c45a94 arm64: imx_v8_defconfig: Enable CONFIG_GPIO_VF610
- 5a015324eddc arm64: dts: imx8qm: add missing imx8-ss-cm40.dtsi include
- 8a8245d395d5 arm64: dts: imx8: img: add #address-cells and #size-cells to I2C MIPI CSI nodes
- db13648c4be6 fw: imx: seco_mu: change dev_err to dev_err_probe for -EPROBE_DEFER
- 0451236fd0ae clk: imx: imx8qm: add more resources to whitelist
- 2ee789512d1b drm/imx: lcdifv3: Fix videomode settings
- 5cd4c30ec228 i2c: imx: Remove unnecessary clock reconfiguration
- 583f2a703c5d tty: vt: conmakehash: remove non-portable code printing comment header
- 4ddc4dae8515 tty: vt: conmakehash: cope with abs_srctree no longer in env
- 46a05495bce3 drm: of: Fix build without CONFIG_OF

Signed-off-by: Daiane Angolini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants