base: u-boot-ostree-scr-fit: save fiovb.is_secondary_boot if changed#567
Merged
ricardosalveti merged 2 commits intofoundriesio:mainfrom Apr 5, 2022
Merged
Conversation
Contributor
igoropaniuk
commented
Mar 24, 2022
igoropaniuk
commented
igoropaniuk
requested review from
MrCry0,
Tim-Anderson,
angolini,
ldts,
mike-scott and
ricardosalveti
igoropaniuk
force-pushed
the
secondary_boot_val_rework
branch
from
07deff0 to
b3b5417
Compare
igoropaniuk
force-pushed
the
secondary_boot_val_rework
branch
from
b3b5417 to
18afff0
Compare
angolini
approved these changes
Mar 25, 2022
igoropaniuk
force-pushed
the
secondary_boot_val_rework
branch
3 times, most recently
from
6f2d835 to
18afff0
Compare
Member
|
@igoropaniuk can you either bump optee as part of this pr or have that merged proposed and merged first? So we can have a linear logic. |
Contributor
Author
|
@ricardosalveti done |
MrCry0
approved these changes
Apr 5, 2022
Fix the issue, when rpmb/ubootenv contains obsolete value of fiovb.is_secondary_boot. This happens after update is triggered: 1. secondary path is booted, fiovb.is_secondary_boot == 1 2. update procedure is run 3. saveenv && reset 3. primary boot path is booted, fiovb.is_secondary_boot == 0, however it is not updated in ubootenv/rpmb storage. 5. In Linux fw_printenv/fiovb_printenv shows is_secondary_boot == 1, regardless the fact, that the primary boot path is booted. Signed-off-by: Igor Opaniuk <[email protected]>
Relevant changes: - 444d46a4d [FIO internal] ta: fiovb: add is_secondary_boot variable Signed-off-by: Igor Opaniuk <[email protected]>
igoropaniuk
force-pushed
the
secondary_boot_val_rework
branch
from
17b0778 to
fbda47d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.