[RFC] bsp: u-boot-ostree-scr-fit: boot firmware updates for QSPI#453
Closed
igoropaniuk wants to merge 1 commit intofoundriesio:masterfrom
Closed
[RFC] bsp: u-boot-ostree-scr-fit: boot firmware updates for QSPI#453igoropaniuk wants to merge 1 commit intofoundriesio:masterfrom
igoropaniuk wants to merge 1 commit intofoundriesio:masterfrom
Conversation
Add support of boot firmware updates on UltraZed QSPI. Signed-off-by: Igor Opaniuk <[email protected]>
MrCry0
reviewed
Nov 3, 2021
|
|
||
| setenv update_primary_image2 'echo "${fio_msg} writing ${image_path} ..."; mmc dev ${devnum} && fatwrite mmc ${devnum}:${bootpart} ${loadaddr} u-boot0001.itb ${filesize}'; | ||
| setenv update_secondary_image2 'echo "${fio_msg} writing ${image_path} ..."; mmc dev ${devnum} && fatwrite mmc ${devnum}:${bootpart} ${loadaddr} u-boot0002.itb ${filesize}'; | ||
| setenv update_primary_image 'echo "${fio_msg} writing ${image_path} ..."; sf probe; sf update ${loadaddr} ${qspi_bootloader_offset} ${filesize}'; |
Contributor
There was a problem hiding this comment.
Wouldn't it be better to generalize setting update_* commands to avoid code duplication?
Like
if test "${modeboot}" = "qspiboot"; then
...
setenv update_cmd 'sf probe; sf update ${loadaddr}'
setenv image_pri1 '${qspi_bootloader_offset}'
setenv image_sec1 '${qspi_bootloader_s_offset}'
...
else
setenv update_cmd 'mmc dev \${devnum} && fatwrite mmc \${devnum}:\${bootpart} \${loadaddr}'
setenv image_pri1 'boot0001.bin'
setenv image_sec1 'boot0002.bin'
fi
setenv update_primary_image 'echo "${fio_msg} writing ${image_path} ..."; ${update_cmd} ${image_pri1} ${filesize}';
setenv update_primary_image 'echo "${fio_msg} writing ${image_path} ..."; ${update_cmd} ${image_sec1} ${filesize}';
...
Contributor
Author
There was a problem hiding this comment.
sure, nice idea, will do
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support of boot firmware updates on UltraZed QSPI.
Signed-off-by: Igor Opaniuk [email protected]
Just RFC, please don't merge it!