Boot firmware updates alternative path#449
Merged
igoropaniuk merged 2 commits intofoundriesio:masterfrom Oct 29, 2021
Merged
Conversation
igoropaniuk
requested review from
MrCry0,
Tim-Anderson,
angolini,
ldts,
mike-scott,
ricardosalveti and
vanmaegima
Add alternative boot firmware upgrade common include, where primary image set is updated first. Signed-off-by: Igor Opaniuk <[email protected]>
Add support for boot firmware updates Signed-off-by: Igor Opaniuk <[email protected]>
igoropaniuk
force-pushed
the
boot_updates_alternative
branch
from
91f3d7a to
da993a5
Compare
mike-scott
reviewed
Oct 28, 2021
| run bootcmd_rollback | ||
| run bootcmd_load_f | ||
| run bootcmd_tee_ovy | ||
| if test -n "${bootcmd_load_fw}"; then |
Contributor
There was a problem hiding this comment.
@igoropaniuk I think this is a great addition and we could also use this in the https://github.com/foundriesio/meta-lmp/blob/master/meta-lmp-base/recipes-bsp/u-boot/u-boot-ostree-scr-fit/boot-common.cmd.in script.
Can you open a new PR for that change also?
Member
There was a problem hiding this comment.
Yeah, +1 on this suggestion.
@vanmaegima this could be a way to load/execute m4 stuff in a more generic way.
ricardosalveti
approved these changes
Oct 29, 2021
Member
ricardosalveti
left a comment
ricardosalveti
left a comment
There was a problem hiding this comment.
LGTM, minor comment, just unable to validate as I don't have such target in hands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.