Skip to content

bsp: linux-lmp-fslc-imx: add patch to fix building busfreq-imx.c#447

Merged
ricardosalveti merged 1 commit intofoundriesio:ebbr-nxpfrom
MrCry0:fio-ebbr-nxp-fixes
Oct 25, 2021
Merged

bsp: linux-lmp-fslc-imx: add patch to fix building busfreq-imx.c#447
ricardosalveti merged 1 commit intofoundriesio:ebbr-nxpfrom
MrCry0:fio-ebbr-nxp-fixes

Conversation

@MrCry0
Copy link
Copy Markdown
Contributor

@MrCry0 MrCry0 commented Oct 25, 2021

In case CONFIG_HAVE_IMX_BUSFREQ is not set, there are mocks for some
functions from busfreq-imx declared. It fails kernel building with an
error [1].
Disable duplicated functions from busfreq-imx fixes this issue.

[1]
...
| arch/arm/mach-imx/busfreq-imx.c:821:6: error: redefinition of 'request_bus_freq'
| 821 | void request_bus_freq(enum bus_freq_mode mode)
| | ^~~~~~~~~~~~~~~~
| In file included from arch/arm/mach-imx/busfreq-imx.c:23:
| include/linux/busfreq-imx.h:58:20: note: previous definition of 'request_bus_freq' was here
| 58 | static inline void request_bus_freq(enum bus_freq_mode mode)
| | ^~~~~~~~~~~~~~~~
...

Signed-off-by: Oleksandr Suvorov [email protected]

@ricardosalveti
Copy link
Copy Markdown
Member

Is this a consequence of a particular BSP patch? If so, tag as tonxp so we can forward that to them.

In case CONFIG_HAVE_IMX_BUSFREQ is not set, there are mocks for some
functions from busfreq-imx declared. It fails kernel building with an
error [1].
Disable duplicated functions from busfreq-imx fixes this issue.

[1]
...
| arch/arm/mach-imx/busfreq-imx.c:821:6: error: redefinition of 'request_bus_freq'
|   821 | void request_bus_freq(enum bus_freq_mode mode)
|       |      ^~~~~~~~~~~~~~~~
| In file included from arch/arm/mach-imx/busfreq-imx.c:23:
| include/linux/busfreq-imx.h:58:20: note: previous definition of 'request_bus_freq' was here
|    58 | static inline void request_bus_freq(enum bus_freq_mode mode)
|       |                    ^~~~~~~~~~~~~~~~
...

Signed-off-by: Oleksandr Suvorov <[email protected]>
@MrCry0 MrCry0 force-pushed the fio-ebbr-nxp-fixes branch from f4be739 to a0fad1e Compare October 25, 2021 19:37
@MrCry0
Copy link
Copy Markdown
Contributor Author

MrCry0 commented Oct 25, 2021

Is this a consequence of a particular BSP patch? If so, tag as tonxp so we can forward that to them.

Ah, thanks, fixed!

Copy link
Copy Markdown
Member

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardosalveti ricardosalveti merged commit 09b2b47 into foundriesio:ebbr-nxp Oct 25, 2021
@MrCry0 MrCry0 deleted the fio-ebbr-nxp-fixes branch January 13, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants