Skip to content

fix single char vars#446

Merged
ricardosalveti merged 2 commits intofoundriesio:masterfrom
MrCry0:master-fix-single-char-vars
Oct 25, 2021
Merged

fix single char vars#446
ricardosalveti merged 2 commits intofoundriesio:masterfrom
MrCry0:master-fix-single-char-vars

Conversation

@MrCry0
Copy link
Copy Markdown
Contributor

@MrCry0 MrCry0 commented Oct 21, 2021

Rename single-char variables to make code easy to understand and avoid possible name conflicts.

Copy link
Copy Markdown
Contributor

@Tim-Anderson Tim-Anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-scott
Copy link
Copy Markdown
Contributor

This would be a great case for running an automated case to make sure this doesn't break anything.

@MrCry0
Copy link
Copy Markdown
Contributor Author

MrCry0 commented Oct 25, 2021

This would be a great case for running an automated case to make sure this doesn't break anything.

@mike-scott Do you mean on the LAB? With LAVA?

Comment thread meta-lmp-base/recipes-bsp/u-boot/u-boot-lmp-common.inc Outdated
Rename single-char variables to make code more understandable and
avoid possible name conflicts.

Signed-off-by: Oleksandr Suvorov <[email protected]>
@MrCry0 MrCry0 force-pushed the master-fix-single-char-vars branch from 8106b42 to 53c8c6f Compare October 25, 2021 17:58
Comment thread meta-lmp-bsp/recipes-bsp/u-boot/u-boot-fio_%.bbappend Outdated
Comment thread meta-lmp-bsp/recipes-bsp/u-boot/u-boot-fio-mfgtool_%.bbappend Outdated
Rename single-char variables to make code more understandable and
avoid possible name conflicts.

Signed-off-by: Oleksandr Suvorov <[email protected]>
@MrCry0 MrCry0 force-pushed the master-fix-single-char-vars branch from 53c8c6f to ff7e9c1 Compare October 25, 2021 18:08
Copy link
Copy Markdown
Member

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ricardosalveti ricardosalveti merged commit f83356f into foundriesio:master Oct 25, 2021
@MrCry0 MrCry0 deleted the master-fix-single-char-vars branch January 13, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants