base: kernel-lmp-fitimage: fix loadable and dtb counters#445
Merged
ricardosalveti merged 1 commit intofoundriesio:masterfrom Oct 21, 2021
Merged
Conversation
In fitimage_assemble, we use a shell variable "i" to keep track
of the number of DTBs we've added. This variable is compared
to "dtbcount" in order to see if we're on the first or "default"
dtb.
However, we also use the "i" variable in fitimage_emit_section_config
to keep a running count of loadables so that we can name them
"loadable_${i}" for uniqueness.
This means anytime "FIT_LOADABLES" is set, we are messing with the DTB
counter and it causes more than 1 "default" node to possibly be set.
Fix this by not using the "i" variable in fitimage_emit_section_config.
Signed-off-by: Michael Scott <[email protected]>
mike-scott
requested review from
MrCry0,
Tim-Anderson,
igoropaniuk and
ricardosalveti
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In fitimage_assemble, we use a shell variable "i" to keep track
of the number of DTBs we've added. This variable is compared
to "dtbcount" in order to see if we're on the first or "default"
dtb.
However, we also use the "i" variable in fitimage_emit_section_config
to keep a running count of loadables so that we can name them
"loadable_${i}" for uniqueness.
This means anytime "FIT_LOADABLES" is set, we are messing with the DTB
counter and it causes more than 1 "default" node to possibly be set.
Fix this by not using the "i" variable in fitimage_emit_section_config.
Signed-off-by: Michael Scott [email protected]