base: docker-moby: patch to fsync layer metadata#443
Merged
ricardosalveti merged 1 commit intomasterfrom Oct 18, 2021
Merged
Conversation
Fsync `link` and `lower` layer files just after write to make sure their content is stored on a persistent storage. It helps to overcome the issue that occurs when image layers download/extraction is interrupted by a power cut. Docker daemon can recover if the interrupted layer is "broken", but it cannot recover if there are two or more lower to the interrupted layers are "broken". The given fix makes sure that the lower layers that are fully downloaded and extracted are consistent even if the current top layer is broken. Signed-off-by: Mike Sul <[email protected]>
Contributor
Author
|
This is CI job https://ci.foundries.io/projects/msul-dev01/lmp/builds/1056/ that built the given change. |
ricardosalveti
approved these changes
Oct 18, 2021
Member
ricardosalveti
left a comment
ricardosalveti
left a comment
There was a problem hiding this comment.
LGTM, will merge and we can do a bit more testing with it.
BTW, this looks like something that upstream should be able to accept, would be good to send a similar change and see what they might think about it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fsync
linkandlowerlayer files just after write operation to make sure theircontent is stored on a persistent storage. It helps to overcome
the issue that occurs when image layers download/extraction is
interrupted by a power cut.
Docker daemon can recover if the interrupted layer is "broken",
but it cannot recover if there are two or more lower to the interrupted
layers are "broken". The given fix makes sure that the lower layers that
are fully downloaded and extracted are consistent even if the current
top layer is broken.
Signed-off-by: Mike Sul [email protected]