UZ secondary boot boot.cmd adjustments#441
UZ secondary boot boot.cmd adjustments#441ricardosalveti merged 3 commits intofoundriesio:masterfrom
Conversation
igoropaniuk
requested review from
MrCry0,
Tim-Anderson,
angolini,
ldts,
mike-scott,
ricardosalveti and
vanmaegima
| if test -z "${check_secondary_boot}"; then setenv check_secondary_boot "imx_secondary_boot"; fi; | ||
| if test -z "${set_primary_boot}"; then setenv set_primary_boot "imx_secondary_boot 0"; fi; | ||
| if test -z "${set_secondary_boot}"; then setenv set_secondary_boot "imx_secondary_boot 1"; fi; | ||
| setenv update_image 'echo "${fio_msg} writing ${image_path} ..."; run set_blkcnt && mmc dev ${devnum} ${uboot_hwpart} && mmc write ${loadaddr} ${start_blk} ${blkcnt}' |
There was a problem hiding this comment.
I think moving the update_image definition to here, makes this a bit harder to read. It was previously defined next to the other update helpers. Was there another reason to move?
There was a problem hiding this comment.
I moved all env var definitions that can be redefined in the board specific boot.cmd to the beginning of the file
Tim-Anderson
left a comment
Tim-Anderson
left a comment
There was a problem hiding this comment.
added some comments
|
@igoropaniuk Have we re-tested this with IMX targets? |
igoropaniuk
force-pushed
the
uz_secondary_boot
branch
2 times, most recently
from
af139ea to
cb48071
Compare
angolini
left a comment
angolini
left a comment
There was a problem hiding this comment.
The commit bsp: u-boot-ostree-scr-fit: imx: introduce common imx include
includes 2 files .boot-common-imx.cmd.in.swp and .boot-common.cmd.in.swp, I think it is temp file, could you, please, double check?
angolini
left a comment
angolini
left a comment
There was a problem hiding this comment.
Other than the minor comments, LGTM
|
@angolini thanks for catching that, Ive included them accidentally, it's just vim cache(I should have added them to my .gitignore) Will delete them |
MrCry0
left a comment
MrCry0
left a comment
There was a problem hiding this comment.
With removed vim .swp files, LGTM.
igoropaniuk
force-pushed
the
uz_secondary_boot
branch
from
cb48071 to
f4ec944
Compare
|
removed .swp files |
igoropaniuk
force-pushed
the
uz_secondary_boot
branch
from
f4ec944 to
586b0a9
Compare
|
Tested on iMX targets, fixed one type in boot-common-imx.cmd.in @ricardosalveti this PR ready for final testing |
| do_compile() { | ||
| sed -e '/@@INCLUDE_COMMON@@/ {' -e 'r ${S}/boot-common.cmd.in' -e 'd' -e '}' \ | ||
| sed -e '/@@INCLUDE_COMMON_IMX@@/ {' -e 'r ${S}/boot-common-imx.cmd.in' -e 'd' -e '}' \ | ||
| "${S}/boot.cmd" > boot.cmd.in |
There was a problem hiding this comment.
This is fine for now, but later on we can probably change this to INCLUDE_COMMON_BSP and have the boot-common-bsp.cmd.in file to be provided under a bsp specific folder (e.g. imx here), as then we would have a more generic way of adding stuff that is specific to the bsp.
|
LGTM but was unable to test this yet, hope to do that tomorrow. One minor comment, please avoid patches with no body in the commit message, add at least one short line explaining the reasoning behind your patch. |
Introduce common include for i.MX-based boards. Signed-off-by: Igor Opaniuk <[email protected]>
Add SoC manufacture agnostic wrappers for checking board secure state, getting/setting primary/secondary boot and updating images. Move imx-specific defines to the boot-common-imx.cmd.in include. Signed-off-by: Igor Opaniuk <[email protected]>
Add support for Boot Firmware updates on Ultrazed board. Currently only eMMC/SD is supported. Signed-off-by: Igor Opaniuk <[email protected]>
igoropaniuk
force-pushed
the
uz_secondary_boot
branch
from
586b0a9 to
03a930f
Compare
Fixed |
6 participants
No description provided.