recipes-sota: Add example recipe for custom C++ aklite client#437
recipes-sota: Add example recipe for custom C++ aklite client#437ricardosalveti merged 1 commit intomasterfrom
Conversation
|
@rsalveti @mike-sul - this is related to foundriesio/docs#280 We have an aklite revision bump in review right now: #429 I think I'll hold off on bumping that SRCREV until we get both of these merged. Make sense? |
| DEPENDS = "jsoncpp boost aktualizr" | ||
|
|
||
| BRANCH = "master" | ||
| SRCREV = "05c4180840ef84c21b0632be4a542580d720491f" |
There was a problem hiding this comment.
I wonder if something like this SRCREV = aktualizr_SRCREV :)
There was a problem hiding this comment.
^^ this would be cool. I wasn't sure if there was a convention for that.
There was a problem hiding this comment.
Not unless we control the aktualizr revision outside the aktualizr recipe.
I think it is fine for us to manually track this for now, I was surprised to see that the custom sota client reference is part of the aktualizr-lite source tree, was expecting that to be a different tree on its own (but not an issue, what was done here is correct).
|
|
||
| [Install] | ||
| WantedBy=multi-user.target | ||
|
|
There was a problem hiding this comment.
Nit, drop this extra empty line.
There was a problem hiding this comment.
done in a fixup commit that we can squash
ricardosalveti
left a comment
ricardosalveti
left a comment
There was a problem hiding this comment.
LGTM, minor nits only.
|
i see you already gave the thumbs up, so I'll squash and git-push -f to my branch now |
doanac
force-pushed
the
custom-sota-client-example
branch
2 times, most recently
from
591999e to
5ed69b5
Compare
This recipe can be used as a starting point for people wanting to create their own custom sota clients. It can be enabled by: setting SOTA_CLIENT="custom-sota-client" Signed-off-by: Andy Doan <[email protected]>
doanac
force-pushed
the
custom-sota-client-example
branch
from
5ed69b5 to
409e655
Compare
3 participants
This recipe can be used as a starting point for people wanting to create
their own custom sota clients. It can be enabled by:
setting SOTA_CLIENT="custom-sota-client"
Signed-off-by: Andy Doan [email protected]