Boot firmware bootcmd#351
Merged
igoropaniuk merged 10 commits intofoundriesio:masterfrom Jun 9, 2021
Merged
Conversation
igoropaniuk
force-pushed
the
boot_firmware_bootcmd
branch
from
772472d to
ad64c3c
Compare
igoropaniuk
requested review from
Tim-Anderson,
angolini,
ldts,
mike-scott,
ricardosalveti and
vanmaegima
and removed request for
Tim-Anderson and
mike-scott
mike-scott
requested changes
Jun 3, 2021
igoropaniuk
force-pushed
the
boot_firmware_bootcmd
branch
from
ad64c3c to
d13f21f
Compare
Member
|
Please add at least one line at the patch body explaining why bootcount was disabled (just for reference). |
Signed-off-by: Igor Opaniuk <[email protected]>
Signed-off-by: Igor Opaniuk <[email protected]>
Signed-off-by: Igor Opaniuk <[email protected]>
Signed-off-by: Igor Opaniuk <[email protected]>
Signed-off-by: Igor Opaniuk <[email protected]>
Signed-off-by: Igor Opaniuk <[email protected]>
Signed-off-by: Igor Opaniuk <[email protected]>
Signed-off-by: Igor Opaniuk <[email protected]>
Add support for boot firmware update handling. Bootcount is handled manually in boot.cmd script as we don't want double incrementing of counter when we boot secondary boot path for image validation. Signed-off-by: Igor Opaniuk <[email protected]>
igoropaniuk
force-pushed
the
boot_firmware_bootcmd
branch
from
d13f21f to
019736e
Compare
igoropaniuk
force-pushed
the
boot_firmware_bootcmd
branch
2 times, most recently
from
f0ca113 to
4ef7790
Compare
ricardosalveti
approved these changes
Jun 9, 2021
Member
ricardosalveti
left a comment
ricardosalveti
left a comment
There was a problem hiding this comment.
One minor comment but LGTM, feel free to merge once you're happy with it, then we can start doing a wider testing.
Also, do we need foundriesio/u-boot#68?
1. Set bootcount to 0 if it is not defined 2. Handle the case if boot firmware update image doesn't exist 3. Move common prefix in all printed messages to a separate variable 4. Save ubootenv after update of bootcount 5. Use ubootenv that doesn't use eMMC for booting and that are closed Signed-off-by: Igor Opaniuk <[email protected]>
igoropaniuk
force-pushed
the
boot_firmware_bootcmd
branch
from
4ef7790 to
7b8455c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.