iMX6ULL EVK/Apalis iMX6Q secondary boot support by igoropaniuk · Pull Request #316 · foundriesio/meta-lmp

igoropaniuk · 2021-04-16T17:38:04Z

No description provided.

ricardosalveti · 2021-04-28T18:53:10Z

"bsp: u-boot-fio-common: add support for sit geenration" -> generation

Tim-Anderson

LGTM

ricardosalveti · 2021-05-05T00:59:11Z

Looks good, will do some testing tomorrow and approve.

igoropaniuk · 2021-05-05T16:03:06Z

@ricardosalveti sure, thanks

ricardosalveti · 2021-05-06T02:06:26Z

@igoropaniuk we're missing a u-boot-fio rev bump for apalis-imx6, otherwise u-boot-fio fails to build as SECONDARY_BOOT_SECTOR_OFFSET is not available for IMX6 on the current u-boot rev used by this pull request.

ricardosalveti · 2021-05-06T02:07:37Z

Also, can you change the commit order to have "bsp: mfgtool-files: imx6ullevk: write secondary boot images" applied only after the required settings for generating sit are available? Just to get first to produce sit and then use it as part of mfgtools.

ricardosalveti · 2021-05-06T02:08:13Z

Tested imx6ullevk, seems correct, just missing the u-boot rev bump for being able to test on apalis-imx6.

Relevant changes: - 4b11d263c2 [FIO internal] imx: imx8m: drop all board-specific do_reset funcs - b86d18b382 [FIO internal] arm: use default implementation of do_reset for SPL - 2337804451 [FIO internal] mx6ullevk: drop empty reset_cpu - 5a973cb6b0 [FIO internal] watchdog: introduce SPL_HW_WATCHDOG - 24f22c50da [FIO internal] imx: move secondary boot logic to soc-specific code - c9a22e18db [FIO internal] fastboot: fsl: add sit offset for MX6 SoCs - d3f551cc7f [FIO internal] imx: add support of secondary boot for MX6 - 70c98a180d [FIO fromtree] sysreset: provide type of reset in do_reset cmd - 94e3044551 [FIO fromtree] sysreset: psci: use psci driver exported functions - 4a9c634fde [FIO fromtree] psci: add features/reset2 support - f51692c3a1 [FIO fromtree] psci: add v1.0/v1.1 definitions from Linux - e208657ebf [FIO internal] ARM: dts: imx6ul: add psci node Signed-off-by: Igor Opaniuk <[email protected]>

Add step for generating Secondary Image Table binary, needed for redundant boot support. Signed-off-by: Igor Opaniuk <[email protected]>

Drop Secondary Boot image generation code in favor of the one from u-boot-fio-common. Signed-off-by: Igor Opaniuk <[email protected]>

Signed-off-by: Igor Opaniuk <[email protected]>

1. Add secondary boot defines 2. Enable watchdog support Signed-off-by: Igor Opaniuk <[email protected]>

- use PSCI for reset command. - enable watchdog by default. Signed-off-by: Igor Opaniuk <[email protected]>

Signed-off-by: Igor Opaniuk <[email protected]>

1. Add CONFIG_SECONDARY_BOOT_SECTOR_OFFSET 2. Adjust CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR to correspond the one from lmp.cfg Signed-off-by: Igor Opaniuk <[email protected]>

Signed-off-by: Igor Opaniuk <[email protected]>

ricardosalveti

LGTM

Bumping pflag to version v1.0.5-4-gd5e0c06, which comprises the following commits: d5e0c06 allow for blank ip addresses (#316) 85dd5c8 Add IPNetSlice and unit tests (#170) 6971c29 remove dead code for checking error nil (#282) 81378bb Add exported functions to preserve `pkg/flag` compatibility (#220) 14457a6 Remove require pflag v1.0.3 e8f2996 Fix typo in go.mod 8e39cc4 gofmt 68f4136 Add SliceValue Comments b22fc70 Expand SliceValue support to all slice and array types. c6c0f0f Add first SliceValue implementations 9722382 Added String-To-Int64 option parsing (#211) 4890c25 Fix package doc b3e76d4 Fix descriptions for StringSlice functions 24fa697 fix misspell (#197) 916c5bf Fix typo in count.go (#196) aea12ed add int32 & int64 slice support (#194) 454a7fb add float32 & float64 slice support (#192) 082b515 Travis: test on 1.9 as well (#191) 252d3ee travis: update to 1.10 and 1.11 in travis tests (#190) 0873577 Fix golint import path (#189) b5e1a80 Sentence restructure and grammar fix (#188) 298182f Fix panic when parsing unknown flag followed by empty argument (#173) d929dcb Handle single string=>string flags without quotes (#179) 947b89b Add map valued (string->string, string->int) flags. (#133) 9a97c10 bytes: add support for base64 encoded flags (#177) 3ebe029 Allow bubbling up of -test.* flags (#169) 583c0c0 Typo correction in flag.go (#164) 329ebf1 Allow Users To Show Deprecated Flags (#163) 1ce0cc6 make x.Parsed() return true after AddGoFlagSet(x) and pflag.Parse() (#162) 1cd4a0c add ability to ignore unknown flags (#160) ad68c28 Add multiline wrapping support (#155) 45e82a3 Implement BytesHex type of argument (#115) ee5fd03 doc: clarify difference between string slice vs. array (#158) 6a877eb DurationSlice: implementation and tests (#122) 4c012f6 Add uintSlice and boolSlice to name prettifier (#150) 97afa5e Prevent printing when using ContinueOnError (#144) 1f33b80 add int16 flag (#143) a9789e8 Remove redundant break 2c300e7 Fixing Count flag usage string (#141) be7121d Fix SetNormalizeFunc (#137) 5c2d607 Generate flag error output for errors returned from the parseFunc (#138) 7aff26d New: renamed intSlice to ints in usage 230e229 Fixed: updated unittest adc6ccc New: added a default name to avoid stringSlice in the usage message. e57e3ee Delete example, what isn't even shown in docs 80fe0fb Testing for Shorthand Lookup 75859d1 Add example to FlagSet.ShorthandLookup 86425cb Add example to ShorthandLookup 10b28b3 Add note about panic in ShorthandLookup a84f757 Allow lookup by shorthand (#106) c990990 Add Go 1.8.1 to .travis.yml af3f947 Update .travis.yml f1d95a3 Unify error message for panic and f.out 314c91c Use comparison a string with "" instead of comparison of len 1cd6182 Prevent parsing if there are no arguments 9c8891d Add more verbosity to panic of shorthand redefinition 1d9fab4 Use f.out in output flag deprecation 4995a3e Make more detailed error in Set 9421342 Add comments for better understanding of parsing short flags 159e1d7 Document Count function e466d44 Delete setFlag 686edd7 Fix alreadythere variable name af10531 Note about SortFlags in README e453343 flag_test: fix go vet (#123) 0328f15 Cache sorted flags 9a906f1 Prevent changing order of flags after SetNormalizeFunc() (#121) d16db1e Modified to display a string default value as double quoted and escaped (#118) d90f37a Add SortFlags option (#113) b205ad1 Change `ogier` to `spf13` in docs and README 9ff6c69 Add FlagSet.FlagUsagesWrapped(cols) which wraps to the given column (#105) 3f939ad Removed unused field "exitOnError". Signed-off-by: Bruce Ashfield <[email protected]>

mike-scott requested changes Apr 16, 2021

View reviewed changes

Comment thread meta-lmp-bsp/conf/machine/include/lmp-machine-custom.inc

igoropaniuk force-pushed the imx6ull_secondary_boot branch from bacc70a to c16506a Compare April 16, 2021 17:43

igoropaniuk requested review from Tim-Anderson, angolini, ldts, mike-scott, ricardosalveti and vanmaegima April 16, 2021 17:44

ricardosalveti reviewed Apr 16, 2021

View reviewed changes

Comment thread meta-lmp-base/classes/uboot-fitimage.bbclass Outdated

mike-scott reviewed Apr 21, 2021

View reviewed changes

Comment thread meta-lmp-bsp/recipes-bsp/u-boot/u-boot-fio-mfgtool/imx6ullevk/lmp.cfg Outdated

mike-scott reviewed Apr 22, 2021

View reviewed changes

Comment thread meta-lmp-bsp/recipes-bsp/u-boot/u-boot-fio/imx6ullevk/lmp.cfg

igoropaniuk force-pushed the imx6ull_secondary_boot branch 2 times, most recently from dc7f431 to a533a5a Compare April 26, 2021 15:12

igoropaniuk changed the title ~~WIP: I.MX6ULL secondary boot~~ WIP: iMX6ULL EVK/Apalis iMX6Q secondary boot support Apr 28, 2021

igoropaniuk force-pushed the imx6ull_secondary_boot branch 2 times, most recently from 2b7fa86 to b7588ba Compare April 28, 2021 14:23

igoropaniuk requested review from mike-scott and ricardosalveti April 28, 2021 14:23

igoropaniuk changed the title ~~WIP: iMX6ULL EVK/Apalis iMX6Q secondary boot support~~ iMX6ULL EVK/Apalis iMX6Q secondary boot support Apr 28, 2021

igoropaniuk commented Apr 28, 2021

View reviewed changes

Comment thread meta-lmp-bsp/recipes-bsp/u-boot/u-boot-fio/apalis-imx6/lmp-base.cfg Outdated