recipes-support: libfyaml for aktualizr-lite by ldts · Pull Request #294 · foundriesio/meta-lmp

ldts · 2021-03-23T15:20:38Z

This tool (binary, not libraries) is used by aklite to convert yaml to json

Signed-off-by: Jorge Ramirez-Ortiz [email protected]

ricardosalveti · 2021-03-23T15:25:11Z

+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
+
+SRC_URI = "git://github.com/pantoniou/libfyaml.git"
+SRCREV = "de89df9041b3a72b258680d6c8f6df31c5cee28a"


Do we need to use git or using the latest known release is enough? Released snapshots are preferred (then renaming the recipe from _git.bb to _0.6.bb).

0.6 is also good

ricardosalveti · 2021-03-23T15:25:18Z

+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://${S}/LICENSE;md5=6399094fbc639a289cfca2d660c010aa"
+
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"


No need for this line.

ricardosalveti · 2021-03-23T15:27:42Z

+SRC_URI = "git://github.com/pantoniou/libfyaml.git"
+SRCREV = "de89df9041b3a72b258680d6c8f6df31c5cee28a"
+
+DEPENDS = " pkgconf "


Is this needed?

I can replace it with
inherit autotools pkgconfig
as we do in other recipe but the outcome will be the same. but will do for coherence

yeah, that is preferred (inherit).

ricardosalveti · 2021-03-23T15:27:57Z

+S = "${WORKDIR}/git"
+
+inherit autotools
+PARALLEL_MAKE = ""


Why setting parallel_make to ""?

someone somewhere mentioned that parallel builds might mess autoconf (I didnt validate it though, but seemed possible)

maybe it was an old comment. is ok without it. removed!

ldts · 2021-03-23T18:56:11Z

@rsalveti these autotools dont seem to be installing in the final image?

jramirez@trex build-lmp$ find . -name "fy-tool"
./tmp-lmp/work/cortexa53-crypto-lmp-linux/libfyaml/0.6-r0/image/usr/bin/fy-tool
./tmp-lmp/work/cortexa53-crypto-lmp-linux/libfyaml/0.6-r0/package/usr/bin/.debug/fy-tool
./tmp-lmp/work/cortexa53-crypto-lmp-linux/libfyaml/0.6-r0/package/usr/bin/fy-tool
./tmp-lmp/work/cortexa53-crypto-lmp-linux/libfyaml/0.6-r0/packages-split/libfyaml/usr/bin/fy-tool
./tmp-lmp/work/cortexa53-crypto-lmp-linux/libfyaml/0.6-r0/packages-split/libfyaml-dbg/usr/bin/.debug/fy-tool
./tmp-lmp/work/cortexa53-crypto-lmp-linux/libfyaml/0.6-r0/build/src/fy-tool
./tmp-lmp/work/cortexa53-crypto-lmp-linux/libfyaml/0.6-r0/build/src/.libs/fy-tool

is this a bug or am I missing something in the recipe??

ldts · 2021-03-23T19:53:45Z

ok I'll cancel the PR until I figure out the install part. will try again later :)

ldts · 2021-03-23T20:16:58Z

added it to the factory.inc....although since it is only used by aktualizr-lite perhaps they should go together.
or with the ota-utils...dunno, so many choices...

ricardosalveti · 2021-03-23T20:26:50Z

added it to the factory.inc....although since it is only used by aktualizr-lite perhaps they should go together.
or with the ota-utils...dunno, so many choices...

If used/required by aktualizr-lite, just make it a dependency of aktualizr.

ricardosalveti · 2021-03-23T20:28:24Z

PACKAGECONFIG += "${@bb.utils.filter('SOTA_EXTRA_CLIENT_FEATURES', 'fiovb', d)}"
PACKAGECONFIG[fiovb] = ",,,optee-fiovb aktualizr-fiovb-env-rollback"
PACKAGECONFIG[ubootenv] = ",,u-boot-fw-utils,u-boot-fw-utils u-boot-default-env aktualizr-uboot-env-rollback"

You could extend that to cover libfyaml, like:
PACKAGECONFIG[fyaml] = ",,,libfyaml"

And adding fyaml to PACKAGECONFIG by default.

ldts · 2021-03-23T20:54:49Z

right and I was thinking about messing with that but what would happen if other clients decide to use this tool?
it is not much different than aktualizr-lite depending on docker-cli (actually is pretty much the same sort of dependency)
so I opted for just adding it to the factory inc.

"And adding fyaml to PACKAGECONFIG by default."

PACKAGECONFIG += "libfyaml"
PACKAGECONFIG[libfyaml] = ",,,libfyaml"

what do you mean something like the above? I am not too familiar with this bit...so is the typical use case of this construct for binaries calling other binaries? seems strange capturing dependencies between binaries in this way...

ricardosalveti · 2021-03-23T22:07:12Z

right and I was thinking about messing with that but what would happen if other clients decide to use this tool?
it is not much different than aktualizr-lite depending on docker-cli (actually is pretty much the same sort of dependency)
so I opted for just adding it to the factory inc.

"And adding fyaml to PACKAGECONFIG by default."
PACKAGECONFIG += "libfyaml"
PACKAGECONFIG[libfyaml] = ",,,libfyaml"

Right, this change would need to be part of the aktualizr_%.bbappend we have in meta-lmp-base.

what do you mean something like the above? I am not too familiar with this bit...so is the typical use case of this construct for binaries calling other binaries? seems strange capturing dependencies between binaries in this way...

IIRC the syntax here is:

PACKAGECONFIG[foobar] = "optiontoenableduringbuildtime,optiontodisableduringbuildtime,builddependency,runtimedependency"

So you could have this as a build option in aktualizr as well if needed. Since it seems you need during runtime, you have to add it at the last block.

ricardosalveti · 2021-03-23T22:10:44Z

+S = "${WORKDIR}/libfyaml-${PV}"
+
+inherit autotools pkgconfig
+


Just drop this last empty line.

ricardosalveti · 2021-03-23T22:12:38Z

WARNING: libfyaml-0.6-r0 do_package_qa: QA Issue: libfyaml: SRC_URI uses unstable GitHub archives [src-uri-bad]

I think we need to use the release link instead.

ricardosalveti · 2021-03-23T22:13:52Z

https://github.com/pantoniou/libfyaml/archive/refs/tags/v0.6.tar.gz

WARNING: libfyaml-0.6-r0 do_package_qa: QA Issue: libfyaml: SRC_URI uses unstable GitHub archives [src-uri-bad]

I think we need to use the release link instead.

Seems release is not available for 0.6, sigh.

In this case, use git then and use the hash from the 0.6 tag.

ricardosalveti · 2021-03-24T02:21:44Z

right and I was thinking about messing with that but what would happen if other clients decide to use this tool?

Then they will need to rdepend on it as well.

In our case, as we know which tool is expecting to use it, it is better to just make it a dependency the tool we're already installing, as then we don't need to change the image.

ldts · 2021-03-24T08:24:02Z

the issue is that .tarball-version is missing in the tarball
should contain something like:
0.6.0

ldts · 2021-03-24T14:45:06Z

I believe this should get merged rather than waiting for v.07 (or whatever version comes along). we can always bump it later

ldts · 2021-03-26T08:26:18Z

I believe this should get merged rather than waiting for v.07 (or whatever version comes along). we can always bump it later

it doesnt matter anymore...just got an update from Pantelis

fy-tool generated during build will be consumed by aktualizr-lite to convert docker yaml to json. Signed-off-by: Jorge Ramirez-Ortiz <[email protected]>

mike-sul · 2021-03-30T08:47:41Z

@ricardosalveti Can we merge it so I can test the latest aklite dev version (deps on fy-tool) against the latest lmp.

ricardosalveti · 2021-03-30T17:12:21Z

@ricardosalveti Can we merge it so I can test the latest aklite dev version (deps on fy-tool) against the latest lmp.

Merging just the recipe itself is fine, as that won't influence anything for now, let me see if I can just cherry-pick that.

ricardosalveti · 2021-03-30T17:26:06Z

I pushed just the recipe at 1dd1d1f, @ldts please update this PR with just the aktualizr-lite addition once there is an updated rev that requires it.

ricardosalveti · 2021-03-30T17:27:36Z

 PACKAGECONFIG += "${@bb.utils.filter('SOTA_EXTRA_CLIENT_FEATURES', 'fiovb', d)}"
 PACKAGECONFIG[fiovb] = ",,,optee-fiovb aktualizr-fiovb-env-rollback"
 PACKAGECONFIG[ubootenv] = ",,u-boot-fw-utils,u-boot-fw-utils u-boot-default-env aktualizr-uboot-env-rollback"
+PACKAGECONFIG += "libfyaml"


Can you extend the first "PACKAGECONFIG +=" line instead with libfyaml?

Also please bump the rev to the one that now requires libfyaml, to avoid having an extra dependency that has no use for the rootfs.

@ricardosalveti done

Signed-off-by: Jorge Ramirez-Ortiz <[email protected]>

ricardosalveti · 2021-04-05T17:39:00Z

Manually merged after resolving a minor conflict and removing one patch which was already added in v80.

mike-sul · 2021-04-06T07:54:19Z

@ricardosalveti Thanks, so the libfyaml stuff is in the master/HEAD of lmp-manifest but is not in v80, which is the right thing to do.

ldts requested a review from mike-sul March 23, 2021 15:20

ricardosalveti reviewed Mar 23, 2021

View reviewed changes

ldts force-pushed the libfyaml branch 2 times, most recently from cf5c305 to ebe42c9 Compare March 23, 2021 18:37

ldts closed this Mar 23, 2021

ldts reopened this Mar 23, 2021

ldts requested a review from ricardosalveti March 23, 2021 20:27

ricardosalveti reviewed Mar 23, 2021

View reviewed changes

ricardosalveti requested a review from angolini March 24, 2021 02:21

ldts force-pushed the libfyaml branch 2 times, most recently from cb6c57c to 84ba704 Compare March 24, 2021 10:35

ldts force-pushed the libfyaml branch from 84ba704 to 09f949d Compare March 26, 2021 08:24

recipes-support: libfyaml

29c693a

fy-tool generated during build will be consumed by aktualizr-lite to convert docker yaml to json. Signed-off-by: Jorge Ramirez-Ortiz <[email protected]>

ldts force-pushed the libfyaml branch from 09f949d to 53a5ce4 Compare March 26, 2021 08:28

angolini approved these changes Mar 26, 2021

View reviewed changes

ricardosalveti reviewed Mar 30, 2021

View reviewed changes

ldts added 2 commits March 31, 2021 15:11

base: aktualizr-lite: depends on fy-tool (libfyaml)

eade944

Signed-off-by: Jorge Ramirez-Ortiz <[email protected]>

bump: aktualizr-lite: bump to 4be89e29

f208d80

Signed-off-by: Jorge Ramirez-Ortiz <[email protected]>

ldts force-pushed the libfyaml branch from 53a5ce4 to f208d80 Compare March 31, 2021 13:12

ricardosalveti closed this Apr 5, 2021

Conversation

ldts commented Mar 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ldts Mar 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ldts Mar 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ldts Mar 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ldts commented Mar 23, 2021

Uh oh!

ldts commented Mar 23, 2021

Uh oh!

ldts commented Mar 23, 2021

Uh oh!

ricardosalveti commented Mar 23, 2021

Uh oh!

ricardosalveti commented Mar 23, 2021

Uh oh!

ldts commented Mar 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ricardosalveti commented Mar 23, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ricardosalveti commented Mar 23, 2021

Uh oh!

ricardosalveti commented Mar 23, 2021

Uh oh!

ricardosalveti commented Mar 24, 2021

Uh oh!

ldts commented Mar 24, 2021

Uh oh!

ldts commented Mar 24, 2021

Uh oh!

ldts commented Mar 26, 2021

Uh oh!

mike-sul commented Mar 30, 2021

Uh oh!

ricardosalveti commented Mar 30, 2021

Uh oh!

ricardosalveti commented Mar 30, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ricardosalveti commented Apr 5, 2021

Uh oh!

mike-sul commented Apr 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

ldts commented Mar 23, 2021 •

edited

Loading

ldts Mar 23, 2021 •

edited

Loading

ldts Mar 23, 2021 •

edited

Loading

ldts Mar 23, 2021 •

edited

Loading

ldts commented Mar 23, 2021 •

edited

Loading