Skip to content

optee: switch to 3.12 version#266

Merged
ricardosalveti merged 1 commit intofoundriesio:masterfrom
igoropaniuk:optee_3.12_transition
Mar 2, 2021
Merged

optee: switch to 3.12 version#266
ricardosalveti merged 1 commit intofoundriesio:masterfrom
igoropaniuk:optee_3.12_transition

Conversation

@igoropaniuk
Copy link
Copy Markdown
Contributor

@igoropaniuk igoropaniuk commented Feb 25, 2021 

Switch optee-os-fio/optee-client/optee-test to 3.12 version.

Signed-off-by: Igor Opaniuk <[email protected]>

ricardosalveti
ricardosalveti reviewed Feb 25, 2021
View reviewed changes
Comment thread meta-lmp-bsp/recipes-security/optee/optee-os-fio_3.12.0.bbappend
ricardosalveti
ricardosalveti reviewed Feb 25, 2021
View reviewed changes
Comment thread meta-lmp-bsp/recipes-security/optee/optee-os-fio_3.12.0.bbappend Outdated
@igoropaniuk igoropaniuk force-pushed the optee_3.12_transition branch from c798bac to 0ddc6b4 Compare February 25, 2021 07:48
ricardosalveti
ricardosalveti reviewed Feb 26, 2021
View reviewed changes
Comment thread meta-lmp-base/recipes-security/optee/optee-os-fio_3.12.0.bb Outdated
ricardosalveti
ricardosalveti reviewed Feb 26, 2021
View reviewed changes
Comment thread meta-lmp-base/recipes-security/optee/optee-os-fio_3.12.0.bb
@ricardosalveti
Copy link
Copy Markdown
Member

ricardosalveti commented Feb 26, 2021

For SE050 we should make sure we're able to build https://github.com/foundriesio/plug-and-trust as part of the optee-os build process (which will be tricky because plug-and-trust requires access to the optee-os source code as well).

We don't yet have any target that uses SE050 by default, but as part of this PR we should make sure we're able to test on a device that has access to SE050. Documenting (even if part of this PR) the options used would be nice as well.

@ricardosalveti
Copy link
Copy Markdown
Member

ricardosalveti commented Feb 26, 2021

This is what @ldts used, as reference:

EXTRA_OEMAKE_append_imx8mmevk = " \
     CFG_PRNG_SOURCE_RANDOM_REE=y \
     CFG_WITH_STATS=y \
     CFG_NXP_CAAM=y \
     CFG_CRYPTO_DRV_CIPHER=y \
     CFG_CRYPTO_DRV_ACIPHER=y \
     CFG_STACK_THREAD_EXTRA=8192 \
     CFG_STACK_TMP_EXTRA=8192 \
     CFG_IMX_I2C=y \
     CFG_NXP_SE05X=y \
     CFG_CORE_SE05X_DISPLAY_SCP03_KEYS=y \
     CFG_CORE_SE05X_SCP03_PROVISION=y \
     CFG_NXP_SE05X_RNG_DRV=n \
     CFG_NXP_CAAM_RNG_DRV=n \
     CFG_WITH_SOFTWARE_PRNG=y \
     CFG_NXP_SE05X_RSA_DRV=y \
     CFG_NXP_SE05X_ECC_DRV=y \
     CFG_NXP_SE05X_CTR_DRV=y \
     CFG_NXP_SE05X_PLUG_AND_TRUST_LIB=/home/jramirez/Src/se050/upstream/plug-and-trust/optee_lib/build/libse050.a \
     CFG_NXP_SE05X_PLUG_AND_TRUST=/home/jramirez/Src/se050/upstream/plug-and-trust \
     CFG_CORE_SE05X_DISPLAY_INFO=1 \
     CFG_CORE_SE05X_SCP03_EARLY=1 \
     CFG_CORE_SE05X_INIT_NVM=1 \
     CFG_CORE_SE05X_OEFID=0xA1F4 \
     CFG_CORE_CRYPTO_AES_ACCEL=y \
 "

@igoropaniuk igoropaniuk force-pushed the optee_3.12_transition branch 7 times, most recently from c28ba7d to a532372 Compare March 2, 2021 20:29
ricardosalveti
ricardosalveti reviewed Mar 2, 2021
View reviewed changes
Comment thread meta-lmp-bsp/recipes-security/optee/optee-os-fio-mfgtool_3.12.0.bbappend Outdated
ricardosalveti
ricardosalveti reviewed Mar 2, 2021
View reviewed changes
Comment thread meta-lmp-bsp/recipes-security/optee/optee-os-fio-mfgtool_3.12.0.bbappend Outdated
ricardosalveti
ricardosalveti reviewed Mar 2, 2021
View reviewed changes
Comment thread meta-lmp-bsp/recipes-security/optee/optee-os-fio-mfgtool_3.12.0.bbappend Outdated
ricardosalveti
ricardosalveti reviewed Mar 2, 2021
View reviewed changes
Comment thread meta-lmp-bsp/recipes-security/optee/optee-os-fio_3.12.0.bbappend Outdated
ricardosalveti
ricardosalveti reviewed Mar 2, 2021
View reviewed changes
Comment thread meta-lmp-bsp/recipes-security/optee/optee-os-fio_3.12.0.bbappend Outdated
@igoropaniuk igoropaniuk force-pushed the optee_3.12_transition branch from a532372 to 68db572 Compare March 2, 2021 22:17
@igoropaniuk
optee: add configuration for 3.12
7b8ba8a 
Add build configuration for OP-TEE 3.12, bump to new hash.

Signed-off-by: Igor Opaniuk <[email protected]>
@igoropaniuk igoropaniuk force-pushed the optee_3.12_transition branch from 68db572 to 7b8ba8a Compare March 2, 2021 22:18
ricardosalveti
ricardosalveti approved these changes Mar 2, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardosalveti ricardosalveti merged commit 28237f4 into foundriesio:master Mar 2, 2021
@ldts
Copy link
Copy Markdown
Contributor

ldts commented Mar 4, 2021

For SE050 we should make sure we're able to build https://github.com/foundriesio/plug-and-trust as part of the optee-os build process (which will be tricky because plug-and-trust requires access to the optee-os source code as well).

right. So first we need to build plug-and-trust: for that we need a path to the op-tee repo so it can access its include flies.
Then we build op-tee against plug-and-trust libs and includes.

We don't yet have any target that uses SE050 by default, but as part of this PR we should make sure we're able to test on a device that has access to SE050. Documenting (even if part of this PR) the options used would be nice as well.

I dont remember if the scp03 provisioning tool was merged in uboot; we will need that in order to stop using the OFEID. Need to remember the provisioning uses the HUK to derive the SCP03 so if the board is not closed we better keep those keys or we risk getting locked up. I think it will be worth having an imx8mm with an ARD SE050 in the lab.

@ldts
Copy link
Copy Markdown
Contributor

ldts commented Mar 4, 2021

This is what @ldts used, as reference:

EXTRA_OEMAKE_append_imx8mmevk = " \
     CFG_PRNG_SOURCE_RANDOM_REE=y \
     CFG_WITH_STATS=y \
     CFG_NXP_CAAM=y \
     CFG_CRYPTO_DRV_CIPHER=y \
     CFG_CRYPTO_DRV_ACIPHER=y \
     CFG_STACK_THREAD_EXTRA=8192 \
     CFG_STACK_TMP_EXTRA=8192 \
     CFG_IMX_I2C=y \
     CFG_NXP_SE05X=y \
     CFG_CORE_SE05X_DISPLAY_SCP03_KEYS=y \
     CFG_CORE_SE05X_SCP03_PROVISION=y \
     CFG_NXP_SE05X_RNG_DRV=n \
     CFG_NXP_CAAM_RNG_DRV=n \
     CFG_WITH_SOFTWARE_PRNG=y \
     CFG_NXP_SE05X_RSA_DRV=y \
     CFG_NXP_SE05X_ECC_DRV=y \
     CFG_NXP_SE05X_CTR_DRV=y \
     CFG_NXP_SE05X_PLUG_AND_TRUST_LIB=/home/jramirez/Src/se050/upstream/plug-and-trust/optee_lib/build/libse050.a \
     CFG_NXP_SE05X_PLUG_AND_TRUST=/home/jramirez/Src/se050/upstream/plug-and-trust \
     CFG_CORE_SE05X_DISPLAY_INFO=1 \
     CFG_CORE_SE05X_SCP03_EARLY=1 \
     CFG_CORE_SE05X_INIT_NVM=1 \
     CFG_CORE_SE05X_OEFID=0xA1F4 \
     CFG_CORE_CRYPTO_AES_ACCEL=y \
 "

I think we should better use the CAAM_RNG (ie not CFG_WITH_SOFTWARE_PRNG ) and not enable CFG_CORE_SE05X_INIT_NVM (it will delete all the SE050 storage on every boot).

quaresmajose pushed a commit that referenced this pull request Jan 10, 2023
@zeddii
go-fsnotify: update to v1.5.1
9437f70 
Bumping fsnotify to version v1.5.1-7-gaf855d7

We update the license checksum, due to new copyright dates, and include
the following commits:

    af855d7 Final Notice: Maintainers Wanted
    62a598a maintainers wanted
    d696f5c revise contributing
    6e1d4e4 update readme
    83f9fe6 Test on Go 1.18 and two most recent versions (#411)
    0aba082 Update issue templates (#410)
    3eb7fa4 Removed dead link
    466b39d prepare 1.5.1, retract 1.5.0
    b98ede5 Revert "Add AddRaw to not follow symlinks + Fix link folloing on Windows (#289)"
    dfdb645 revise pull request template
    08848a0 v1.5.0 preparation (#380)
    e2e9517 Add AddRaw to not follow symlinks + Fix link folloing on Windows (#289)
    82ee6f3 Update test matrix for go 1.17 stable release (#385)
    16f0d42 add //go:build lines + add 1.17.0-rc2 to test matrix (#377)
    cc8365b Update x/sys to latest (#379)
    2fb15b1 Drop support/testing for Go 1.11 and earlier (#381)
    5ce1ba4 Remove Travis CI and references
    ed6d2f5 Add lint+vet+old versions to GitHub Action
    42e9219 introduce GitHub Actions
    7f4cf4d Fix unsafe pointer conversion (#325)
    45d7d09 Move example usage to the readme
    4bf2d1f Updating the FAQ section for supportability with NFS & FUSE filesystems.
    dc27d96 drop 1.8.x from Travis CI
    fce5a44 2019
    ecf2c4d revise editor config
    0a05407 Add Go modules
    ab058b4 readme: plan to support fanotify
    924410f Open files with CLOEXEC
    1485a34 Also create epoll and pipe fds with close-on-exec (#155) (#219)
    11844c0 readme: remove AppVeyor badge
    85de84f Add windows to travis matrix
    2216558 Fix lint issue with error doc string
    9152fb1 only run golint on latest version of go
    ccc981b Check if channels are closed in the example (#244)
    1f285c6 darwin tests: Exchangedata is deprecated on 10.13
    7b866c9 travis: less verbose tests
    8ba2b19 [#234] t.Fatalf -> t.Errorf in go routines (#266)
    70cc4a1 Fix TestInotifyOverflow (#265)
    1d13583 TravisCI: updating test versions
    c282820 v1.4.7
    a6f391c travis: test on Go 1.9.x
    ea33dcb Fix missing verb on format string (#228)
    3d33f50 Fix possible deadlock on closing the watcher on kqueue (#230)
    4da3e2c Fix deadlock in Remove (linux/inotify)
    ff7bc41 Watch.Add improvements (avoid race, fix consistency, reduce garbage) (#189)
    7d7316e travis: update for Go 1.8
    a904159 Moved FAQ into the README
    fd9ec7d Properly handle inotify's IN_Q_OVERFLOW event (#149)
    bd2828f replace references to OS X with macOS
    629574c v1.4.2
    abf5e85 pull request and issue template (#179)
    11054bc Create inotify fd with close-on-exec (#178)
    944cff2 v1.4.1
    5c1390e deflake inotify stress test (#177)
    b4f2a68 rm go1.5.4 from travis config since the linter doesn't build in 1.5 (#175)
    c07fd86 readme: remove gocover.io badge
    b3baf18 update link to contributing to external git repos
    26b17cd v1.4.0
    c3181d8 add @oozie to AUTHORS
    55579be Add a String() func to Event.Op (#165)
    f12c623 Bump Travis to Go 1.6.3 (#156)
    a8a77c9 v1.3.1
    51d3cc5 Use filepath.Join() (#153)
    30411db global: switch to x/sys/unix
    836bfd9 Update Travis config to Go 1.5.4 and 1.6.1

Signed-off-by: Bruce Ashfield <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ricardosalveti ricardosalveti ricardosalveti approved these changes

@mike-scott mike-scott Awaiting requested review from mike-scott

@ldts ldts Awaiting requested review from ldts

@Tim-Anderson Tim-Anderson Awaiting requested review from Tim-Anderson

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@igoropaniuk @ricardosalveti @ldts