Imx8mm secure boot support (updated)#260
Merged
ricardosalveti merged 11 commits intofoundriesio:masterfrom Feb 17, 2021
Merged
Conversation
igoropaniuk
reviewed
Feb 15, 2021
Contributor
|
Besides bootloader/bootloader2 approach in mfgtools/uuu, LGTM |
igoropaniuk
reviewed
Feb 15, 2021
mike-scott
force-pushed
the
master-mx8mm-changes
branch
from
c550162 to
6bfa1d5
Compare
Contributor
Author
|
Rebased and addressed @igoropaniuk comments |
Member
|
LGTM, nice set of changes, will do some local testing and report back. |
Relevant changes: - f0e3fc69 [FIO extras] fiovb: sync ta header for upgrade_available support - 4b6ffe1e [FIO extras] fiovb: add support to delete persistent values - b7229946 [FIO internal] imx8mmevk: drop hardcoded USB configuration - 203c7679 [FIO internal] imx8mm_evk: fix build issues when SPL_DM=y - c8bb7924 [FIO internal] usb hub: don't use env if it's not enabled - 40403e6d [FIO internal] imx8m: don't enable CAAM if OP-TEE is used - 81bd72c4 [FIO toup] rsa-verify: fix aligment issues for SPL - a46a3140 [FIO toup] cmd: scp03: enable and provision command - 8e27c188 [FIO toup] common: TEE SCP03 control Signed-off-by: Michael Scott <[email protected]>
Signed-off-by: Jorge Ramirez-Ortiz <[email protected]> Signed-off-by: Michael Scott <[email protected]>
There are 2 paths for making u-boot and imx8 is typically setup to use.
For example from imx8mmevk.conf:
UBOOT_CONFIG ??= "sd"
UBOOT_CONFIG[sd] = "imx8mm_evk_config,sdcard"
UBOOT_CONFIG[fspi] = "imx8mm_evk_fspi_defconfig"
UBOOT_CONFIG[mfgtool] = "imx8mm_evk_config"
When configured to build u-boot this way, we get artifacts placed in
the following build dirs:
(1 build for each index in the UBOOT_CONFIG array)
${B}/${config}/
The uboot-fitimage class which generates u-boot.itb does not work with
files in this extra "config" subdir. It expects UBOOT_CONFIG not to
be set, instead using the UBOOT_MACHINE method of building u-boot which
places the artifacts directly under the build dir:
${B}/
Let's handle both deployments, but for now we'll be using the
UBOOT_MACHINE method for building u-boot.
Also, generate extra symlinks to account for the imx-boot recipe attempting
to use UBOOT_CONFIG as a suffix which ends up being empty.
Signed-off-by: Jorge Ramirez-Ortiz <[email protected]>
Signed-off-by: Igor Opaniuk <[email protected]>
Signed-off-by: Michael Scott <[email protected]>
…acts
There are 2 paths for making u-boot and imx8 is typically setup to use.
For example from imx8mmevk.conf:
UBOOT_CONFIG ??= "sd"
UBOOT_CONFIG[sd] = "imx8mm_evk_config,sdcard"
UBOOT_CONFIG[fspi] = "imx8mm_evk_fspi_defconfig"
UBOOT_CONFIG[mfgtool] = "imx8mm_evk_config"
When configured to build u-boot this way, we get artifacts placed in
the following build dirs:
(1 build for each index in the UBOOT_CONFIG array)
${B}/${config}/
The uboot-fitimage class which generates u-boot.itb does not work with
files in this extra "config" subdir. It expects UBOOT_CONFIG not to
be set, instead using the UBOOT_MACHINE method of building u-boot which
places the artifacts directly under the build dir:
${B}/
Let's handle both deployments, but for now we'll be using the
UBOOT_MACHINE method for building u-boot.
Also, generate extra symlinks to account for the imx-boot recipe attempting
to use UBOOT_CONFIG as a suffix which ends up being empty.
Signed-off-by: Jorge Ramirez-Ortiz <[email protected]>
Signed-off-by: Igor Opaniuk <[email protected]>
Signed-off-by: Michael Scott <[email protected]>
… SPL - Enable FIT signature verification from SPL - Adjust offset for 2nd stage bootloader (0x300) - Enable flashing bootloader2 in u-boot - Disable CONFIG_SPL_FIT_IMAGE_TINY Signed-off-by: Igor Opaniuk <[email protected]> Signed-off-by: Michael Scott <[email protected]>
Introduce a separate SPL image layout, taking into account new boot sequence. Signed-off-by: Igor Opaniuk <[email protected]>
boot partition is 64MB Signed-off-by: Michael Scott <[email protected]>
Signed-off-by: Michael Scott <[email protected]>
Flash separated imx-boot(SPL) and U-Boot instead of old image format, where everything was packed into one imx boot image. Signed-off-by: Jorge Ramirez-Ortiz <[email protected]> Signed-off-by: Igor Opaniuk <[email protected]> Signed-off-by: Michael Scott <[email protected]>
…generation
To use uboot-fitimage with mx8m we require changes to the imx-atf recipe:
- provide virtual/virtual/trusted-firmware-a
- deploy firmware to ${DEPLOYDIR}
Signed-off-by: Michael Scott <[email protected]>
…e class Additional cleanups: - re-group imx8mmevk settings under the mx8mm settings - mfgtool: fix u-boot-default-script setting Signed-off-by: Michael Scott <[email protected]>
mike-scott
force-pushed
the
master-mx8mm-changes
branch
from
6bfa1d5 to
f2475a3
Compare
ricardosalveti
approved these changes
Feb 17, 2021
Member
ricardosalveti
left a comment
ricardosalveti
left a comment
There was a problem hiding this comment.
All good, working as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supersedes:
#254
#227
Key changes from previous PRs:
imx-bootchanges much cleaner as well as keeps 1 copy of the u-boot.its to manage.Boot: