meta-lmp: xilinx-tools: bitstream-extraction: Add bitstream support#255
Conversation
| EXTRA_IMAGEDEPENDS_remove = "qemu-devicetrees" | ||
|
|
||
| # bitstream support | ||
| MACHINE_FIRMWARE_append_uz3eg-iocc = " bitstream-extraction fpga-manager-script" |
There was a problem hiding this comment.
Since this is machine specific, move this line to conf/machine/uz3eg-iocc.conf instead.
Also, please split the machine changes into a different commit.
|
|
||
| if [ -e ${XSCTH_WS}/${XSCTH_PROJ}_hwproj/*.bit ]; then | ||
| install -d ${D}/${nonarch_base_libdir}/firmware/ | ||
| install -d ${D}/var/lib/firmware/bitstream/ |
There was a problem hiding this comment.
Var is a special directory in our setup because it is RW, so not really managed by ostree.
As all you need is a link, it is better to create a systemd tmpfile for this recipe, like https://github.com/foundriesio/meta-lmp/blob/master/meta-lmp-base/recipes-security/softhsm/softhsm/tmpfiles.conf (but using link instead, check https://www.freedesktop.org/software/systemd/man/tmpfiles.d.html for more info). This allows the link to be created by systemd during boot automatically, and it will keep working even if the user erases /var completely (as it will be restored on a following boot).
There was a problem hiding this comment.
Actually, your recipe will have to install the link and the systemd tmpfiles configuration will have to create the directory (under var).
There was a problem hiding this comment.
the kernel driver will only load from /lib/firmware/... so the symlink has to point to someplace that is writable. and since the utility creates the /var/lib/firmware/bitstream automatically I do not think a systemd operation is strictly neccessary.
| install -Dm 0644 ${XSCTH_WS}/${XSCTH_PROJ}_hwproj/*.bit ${D}/${nonarch_base_libdir}/firmware/ | ||
| fi | ||
| } | ||
|
|
There was a problem hiding this comment.
For loading from fit you will also need a do_deploy (no needed for now, but just a heads up).
There was a problem hiding this comment.
understood, I will add that when I look at the u-boot pieces
| @@ -0,0 +1,5 @@ | |||
| FILESEXTRAPATHS_prepend := "${THISDIR}/files:" | |||
|
|
|||
| SRC_URI_append += " \ | |||
There was a problem hiding this comment.
No need to use append with += (either append or +=).
Signed-off-by: Tim Anderson <[email protected]>
Tim-Anderson
force-pushed
the
update-xilinx-fpga-support
branch
from
90e17cd to
deab47f
Compare
| HDF_EXT = "dsa" | ||
|
|
||
| # bitstream support | ||
| MACHINE_FIRMWARE_append_uz3eg-iocc = " bitstream-extraction fpga-manager-script" |
There was a problem hiding this comment.
No need for append_uz3eg-iocc as this is already the board configuration file, just append works.
Signed-off-by: Tim Anderson <[email protected]>
Tim-Anderson
force-pushed
the
update-xilinx-fpga-support
branch
from
deab47f to
bebf365
Compare
2 participants
Signed-off-by: Tim Anderson [email protected]