Hot reload of the docker image and layer stores#240
Closed
Conversation
mike-sul
force-pushed
the
feat/ostree-for-apps-prototype
branch
2 times, most recently
from
2991a4d to
a5cf70c
Compare
mike-sul
changed the title
Contributor
Author
|
This is part 1.2 of the implementation plan https://docs.google.com/document/d/1lQs5Sas0WwVFzcaH4v-UYelgvaYn6_PBkEGs-Ndop5I/edit#heading=h.e4bsxuh2k3zs Part 1.3 foundriesio/aktualizr-lite#43 |
This was referenced Dec 10, 2020
Signed-off-by: Mike Sul <[email protected]>
mike-sul
force-pushed
the
feat/ostree-for-apps-prototype
branch
from
a5cf70c to
0c266f2
Compare
Signed-off-by: Mike Sul <[email protected]>
mike-sul
force-pushed
the
feat/ostree-for-apps-prototype
branch
from
0c266f2 to
03c166e
Compare
| The given change extends the existing configuration reloading | ||
| functionality, that is triggered on receiving SIGHUP, with reloading | ||
| of images' and layers' data from a filesystem. | ||
|
|
Member
There was a problem hiding this comment.
Can you add "Upstream-Status: Inappropriate [lmp specific]" here?
As this will never land upstream, better to flag it now.
| digest "github.com/opencontainers/go-digest" | ||
| "github.com/pkg/errors" | ||
| "github.com/sirupsen/logrus" | ||
| + refstore "github.com/docker/docker/reference" |
| +func (daemon *Daemon) ReloadImageStore() error { | ||
| + imageRoot := filepath.Join(daemon.root, "image", daemon.graphDrivers[runtime.GOOS]) | ||
| + | ||
| + logrus.Warn(">>>>>>>>>> RELOADING Image Store <<<<<<<<<<<<<") |
Member
There was a problem hiding this comment.
This is probably a normal info message, right? Warn can later give an impression that something wrong happened (and this will be a natural flow for us later on).
ricardosalveti
requested changes
Jan 25, 2021
Member
ricardosalveti
left a comment
ricardosalveti
left a comment
There was a problem hiding this comment.
Sorry for the huge delay, some minor comments.
Member
|
And this depends on foundriesio/ci-scripts#110 as well (which seems to be mostly good?). We can break this into 2 PRs in case we need more time to land the ci-scripts one, as the docker patch can land before the rest is completed. |
Contributor
Author
sure, I've been considering it too. I think it makes sense to break it into two PRs, the docker patch (go first) and then changes related to changes in ci-scripts, will do it tomorrow. |
Contributor
Author
quaresmajose
pushed a commit
that referenced
this pull request
Jan 10, 2023
Bumping the docker recipes to the latest 19.03 changes: f0e27e52c1 Merge component 'cli' from [email protected]:docker/cli 19.03 65550b7564 Merge pull request #2352 from thaJeztah/19.03_backport_add_daemon_redirect 118ddd9ac0 docs: add redirect for old location of daemon reference baa53b1dcc Merge pull request #2344 from thaJeztah/19.03_backport_builder_prune_flags 5321005e4e Merge component 'packaging' from [email protected]:docker/docker-ce-packaging 19.03 d97f4c303b Merge pull request #432 from thaJeztah/19.03_backport_bump_golang_1.12.17 e08e107ddc Merge component 'cli' from [email protected]:docker/cli 19.03 058ac7dc90 Merge pull request #2342 from thaJeztah/19.03_backport_bump_golang_1.12.17 84d75db7ac Fix builder prune -a/--all flag description 29db22eecc unused-for is a deprecated synonym 2f76c46e36 Update Golang 1.12.17 f49613c3ae Update Golang 1.12.17 369ce74a3c Merge pull request #643 from arkodg/19.03 bee80f7cbf Bump Version to 19.03.6 78e3d7a827 Merge component 'cli' from [email protected]:docker/cli 19.03 a53add6c25 Merge pull request #2320 from thaJeztah/19.03_docs_backports b21b8c4427 docs: update deprecated status for --disable-legacy-registry ee91f95834 docs: add status table to "deprecated.md" 672cbe85e0 docs: mark deprecation of "docker engine" subcommands 1697838c76 docs: mark deprecation of "dab" files and top-level "deploy" subcommand 293ca94147 docs: sort "deprecated.md" by deprecation release 8ac182f3d5 docs: update some release-versions in "deprecated.md" 7877cc4a39 docs: minor touch-ups in "deprecated.md" 22b4b51d54 docs: service create: document os/arch constraints and more examples 09315bfb9c docs: service create: document non-matching/exclude constraints 275af80811 docs: service create: use markdown table for constraints 969ddd8937 Give an example for --reserve-memory 70114cfeab Merge component 'cli' from [email protected]:docker/cli 19.03 0056d8cf4a Merge pull request #2315 from thaJeztah/19.03_backport_carry_855_config_opts c3831cea9c Remove a useless '\' and enhance a script in an example in the section 'Add entries ... (--add-host)' d9eb3c2d18 Add examples for configs 586103a655 Merge component 'cli' from [email protected]:docker/cli 19.03 9e55c7c6ff Merge pull request #2311 from thaJeztah/19.03_backport_carry_1889_build_docs_update fc0328309a Syntax corrected 94739e3a28 docs: document dockerignore update 49c91f0de5 docs: document build outputs 0350afa412 docs: document cache-from b9eb7e03e8 Add notice about port binding and overriding of UFW to docker run reference 97049ac8a1 Merge pull request #640 from arkodg/19.03 6d6ce58b31 Bump version to 19.03.6.rc2 76a635b4c1 Merge component 'engine' from [email protected]:docker/engine 19.03 92806c13e9 Merge pull request #40453 from thaJeztah/19.03_bump_containerd 74ceaefc0f Merge component 'engine' from [email protected]:docker/engine 19.03 6e493ff731 update runc library to v1.0.0-rc10 (CVE-2019-19921) 4b4ef42785 update runc binary to v1.0.0-rc10 (CVE-2019-19921) 0a962fdb56 [19.03] Update containerd binary to v1.2.12 e88a6aff54 Merge pull request #40440 from tonistiigi/1903-update-buildkit 8d4dd9cf04 Merge pull request #40432 from thaJeztah/19.03_bump_swarmkit 7b4d2e6d4b vendor: update buildkit to 57e8ad5 57d13bfe2a Merge pull request #40433 from thaJeztah/19.03_bump_golang_1.12.16 2fb2d60efe [19.03] vendor: bump swarmkit 062b694b46c0744d601eebef79f3f7433d808a04 2cf45c5bcb vendor: update golang.org/x/crypto 69ecbb4d6d5dab05e49161c6e77ea40a030884e1 6466a776b3 [19.03] Update Golang 1.12.16 (CVE-2020-0601, CVE-2020-7919) 3e58daafc4 Merge component 'cli' from [email protected]:docker/cli 19.03 68d0178e83 Merge pull request #2302 from thaJeztah/19.03_bump_golang_1.12.16 e5e1976a91 Merge component 'packaging' from [email protected]:docker/docker-ce-packaging 19.03 4e8f5d9d7d Merge pull request #429 from thaJeztah/19.03_backport_bump_golang_1.12.16 9dd99e2dc3 Update Golang 1.12.16 (CVE-2020-0601, CVE-2020-7919) 5974a91053 vendor: update golang.org/x/crypto 69ecbb4d6d5dab05e49161c6e77ea40a030884e1 (CVE-2020-7919) d3739cb2c9 Update Golang 1.12.16 (CVE-2020-0601, CVE-2020-7919) a5b1206510 Merge component 'cli' from [email protected]:docker/cli 19.03 a2bc745cee Merge pull request #2291 from thaJeztah/19.03_backport_update_flag_description 80c58bbf63 Merge component 'cli' from [email protected]:docker/cli 19.03 7b094d6ad6 Merge pull request #2292 from thaJeztah/19.03_backport_hide_unsupported_buildkit_flags 45171da30b Annotate flags that are not supported by Buildkit 7f9957e9d5 Update flag description for docker rm -v 77739a9875 Merge pull request #639 from arkodg/19.03 855b0a0806 Bump version to 19.03.6.rc1 8af945c717 Merge component 'engine' from [email protected]:docker/engine 19.03 7cdc0a43bc Merge pull request #454 from thaJeztah/19.03_backport_lgetxattr_panic 4bd7815ea5 Merge component 'engine' from [email protected]:docker/engine 19.03 78567fe9cc Merge pull request #429 from thaJeztah/19.03_backport_windows_1903_fixes 8b00f36b33 Merge pull request #240 from thaJeztah/19.03_backport_lcowfromscratch 80cebcf36a Merge pull request #443 from thaJeztah/19.03_backport_health_race 5effd71d27 Merge pull request #441 from thaJeztah/19.03_backport_fix_double_host 102b097aff Merge pull request #439 from arkodg/19.03 4e53bffc7f Merge pull request #442 from thaJeztah/19.03_backport_errdefs_no_recurse c094d5a10c Merge pull request #444 from thaJeztah/19.03_backport_fix_unmount_ipc_ignore_enotexist 6c41819f16 Merge pull request #446 from thaJeztah/19.03_backport_ctx_upload_cancel 8f7f8f44fe Merge pull request #447 from thaJeztah/19.03_backport_fix_containerStart_unhandled_error 084a766569 Merge pull request #449 from thaJeztah/19.03_backport_move_windows_gopath_out_of_goroot 4e02c9f299 Merge pull request #440 from thaJeztah/19.03_backport_remove_cocky 446d2c5c1c Merge pull request #448 from thaJeztah/19.03_backport_gofmt_pkg_parsers 3a72499a38 Merge pull request #450 from thaJeztah/19.03_backport_bump_docker_py_4.1.0 169849fb47 Merge pull request #451 from thaJeztah/19.03_backport_swagger_fixes 9d81f4dc77 Merge pull request #452 from thaJeztah/19.03_bump_golang_1.12.15 cda3e3908a Merge component 'packaging' from [email protected]:docker/docker-ce-packaging 19.03 ff42a8ba90 Merge pull request #425 from thaJeztah/19.03_backport_file_permissions db575945f1 Merge component 'engine' from [email protected]:docker/engine 19.03 89d170efa5 Merge pull request #453 from tonistiigi/1903-update-buildkit cebe170ea9 Merge component 'packaging' from [email protected]:docker/docker-ce-packaging 19.03 45d8672a7c Merge pull request #423 from thaJeztah/19.03_backport_eq_fix bb2ce33fe5 Merge pull request #419 from thaJeztah/19.03_backport_bump_golang_1.12.15 8e8ca6cefd Merge component 'packaging' from [email protected]:docker/docker-ce-packaging 19.03 165fa60cf6 deb: make init and postinst files executable ea068ad379 deb: make "rules" executable 8d381059b1 Update Golang 1.12.15 00f93046eb fix eq issue 86c51432c5 Merge pull request #424 from thaJeztah/19.03_fix_engine_build_branch 811ee1c9eb [19.03] Jenkinsfile: fix image-based engine using wrong branch 47f2060ce6 vendor: update buildkit to 926935b5 5ad9cc8ca2 Merge component 'cli' from [email protected]:docker/cli 19.03 3a0d01d07d Merge pull request #2276 from thaJeztah/19.03_backport_bump_golang_1.12.15 6dba05f752 Update Golang 1.12.15 2e17c08fc0 Bump Golang 1.12.14 1ee8d32fb1 Merge component 'engine' from [email protected]:docker/engine 19.03 10edafeba6 Merge pull request #434 from AkihiroSuda/bump-up-rootlesskit-1903 934fe5908d rootless: fix proxying UDP packets 54e2eea263 Merge component 'engine' from [email protected]:docker/engine 19.03 ebff06c64d Merge pull request #445 from thaJeztah/19.03_backport_only_add_btrfs_when_needed_please 14944dac60 Merge component 'cli' from [email protected]:docker/cli 19.03 a6a5fe3f42 [19.03] Bump Golang 1.12.15 d60a0ce710 Merge pull request #2264 from thaJeztah/19.03_backport_passthrough_user_pass 06f4c68830 Merge pull request #2265 from thaJeztah/19.03_backport_fix_pull_test b8f99514f5 Merge pull request #2266 from thaJeztah/19.03_backport_circleci_updates 2bdad99c18 Merge pull request #2267 from thaJeztah/19.03_backport_fix_print 2558f6da19 Merge pull request #2268 from thaJeztah/19.03_backport_docs_changes 43a7e621fa Change example networks 6eeb780d69 Add docs for proxy configuration in config.json bd178e5d35 Fixing some links and deleting an older page reference e027dee044 Update service_create.md 7c3c6bde38 Docs: add note about management commands targeting a manager 8adb5acdec fix formatting issue of encoded url 37661a3bde CircleCI: add some info steps, and re-group jobs 33e6e19119 fix(pull_test): for quiet option 72f8164a81 Fix lint issue 292158ca22 Add test case to cover non-empty auth entry 5caedcf1e7 Allow username/password in config file 2da9c2471c Fix possible runtime panic in Lgetxattr b2ff3fc218 Fix Engine API version history typo 02ea27bc5e swagger: add missing container Health docs 517eb6a711 swagger: move ContainerState to definitions 7bc205f9f7 Fix phrasing when referring to the freezer cgroup 371d0446b2 Update service networks documentation 53051b43bd swagger: restore bind options information 2d9b525418 /containers/{id}/json missing Platform d29437ceda Document `message` parameter to `/images/create` 2f58c245d9 Fix indentation in some description c025267db2 fix swagger.yaml #39484 45e4107de0 bump docker-py to 4.1.0 91d2ac3c90 Move GOPATH out from under the GO source tree 7bc5833224 pkg/parsers/kernel: gofmt hex value (preparation for Go 1.13+) 3a8b05b8b2 daemon:containerStart() fix unhandled error for saveApparmorConfig f72d87c0fc builder-next: close build context upload on cancel 04be8ea7c7 daemon: Remove btrfs_noversion build flag c49c729ba2 Fix "no such file or directory" warning when unmounting IPC mount 759272227c Avoid a data race in container/health.go dd7239f025 errdefs: remove unneeded recursive calls ec423339f0 daemon: don't listen on the same address multiple times 303c74632d Remove cocky from names-generator 3552b026fd Merge component 'engine' from [email protected]:docker/engine 19.03 e7074b6956 Merge component 'cli' from [email protected]:docker/cli 19.03 00159b2d54 Bump 19.03 libnetwork refpoint a2f2b955f2 Merge pull request #2195 from tiborvass/19.03-fix-cp cfe657d671 Merge component 'engine' from [email protected]:docker/engine 19.03 a62d4a6ea5 Merge pull request #424 from thaJeztah/19.03_backport_39608_short_libnetwork_id bb0b936f68 Merge component 'cli' from [email protected]:docker/cli 19.03 982bbfbb9d Merge pull request #2184 from thaJeztah/19.03_backport_fix_max_replicas_per_node_interpolation 9e38db328e Merge pull request #423 from thaJeztah/19.03_backport_win_restore_no_parallelism d6cc247196 Merge pull request #427 from thaJeztah/19.03_backport_40232-comply_with_gelf_spec 403d9c3fcb Merge pull request #425 from cpuguy83/backport_40169_windows_version_quad 788a8e1b4a Merge pull request #435 from thaJeztah/19.03_bump_golang_1.12.14 817461b421 Merge pull request #428 from thaJeztah/19.03_bump_containerd_1.2.11 245f1458e5 Merge pull request #437 from thaJeztah/19.03_backport_skip_broken_docker_py_test 27678e7a7f Merge pull request #438 from ydcool/19.03_backport_fix_compiling_errors_on_mips 642b00b68e Merge component 'cli' from [email protected]:docker/cli 19.03 ebf04109a4 Merge pull request #2261 from zappy-shu/19.03_backport_2250-reverse-port-long-format-order aeec1f7a39 Reverse order of long-form ports 169540b729 cast Dev and Rdev of Stat_t to uint64 for mips 84bf606e9d Merge component 'cli' from [email protected]:docker/cli 19.03 3a9fa3f639 Merge pull request #2239 from thaJeztah/19.03_backport_carry_golangci_lint 482879a6bc Merge pull request #2240 from thaJeztah/19.03_backport_carry_platform_docs 2b51a9c7a8 docs: document from platform a3fb446453 docker-py: skip broken ImageCollectionTest::test_pull_multiple c14d933c6c docker-py: re-enable tests that were fixed in v4.1.0 ffc1e0d1e8 Remove now obsolete gometalinter and use golangci-lint instead b12cb0425d cli/command/stack/kubernetes: Using the variable on range scope `c` in function literal (scopelint) 06b7cc4b21 cli/command/container: Using the variable on range scope `c` in function literal (scopelint) e10677a913 cli/command/stack/kubernetes: Using a reference for the variable on range scope `obj` (scopelint) ad3520d231 opts: Using the variable on range scope `tc` in function literal (scopelint) b88c92188a cli/manifest: Using the variable on range scope `testcase` in function literal (scopelint) b1f12aeb53 cli/compose/template: Using the variable on range scope `tc` in function literal (scopelint) 19a5404f7c cli/command/container: suppress dogsled warnings 05d443cf6e e2e: remove unnecessary trailing newline (whitespace) 95a8c8d361 internal: remove unnecessary newlines (whitespace) bbd8228b8b cli/command: Using the variable on range scope `testcase` in function literal (scopelint) 4bd7b2790b cli: remove unnecessary newlines (whitespace) 709d853810 cli/command/trust: Using the variable on range scope `keyBytes` in function literal (scopelint) e4dd0c48c0 cli/command/context: Using the variable on range scope `c` in function literal (scopelint) 941a48cf6c e2e/cli-plugins: Using the variable on range scope `args` in function literal (scopelint) 1bd87c8870 cli/compose/loader: Using a reference for the variable on range scope `overrideService` (scopelint) cf3ad51330 templates: Using the variable on range scope `testCase` in function literal (scopelint) 938050f6df service/logs: Using the variable on range scope `testcase` in function literal (scopelint) 892f49ecc1 cli/config: Using the variable on range scope `tc` in function literal (scopelint) 86637da9e1 cli/command/formatter: Error return value of `ContainerWrite` is not checked (errcheck) f1226e4803 cli/command: Error return value of `cli.Apply` is not checked (errcheck) c16e5c5cb6 cli/command/formatter: Error return value of `ImageWrite` is not checked (errcheck) 6980a9fa85 cli/context/store: SA5001: should check returned error before deferring f.Close() (staticcheck) 3b21601ee7 cli/command/image: SA1006: printf-style with no further arguments (staticcheck) 6607bae1ed cli/command/utils: SA1006: printf-style with no further arguments (staticcheck) 63aecdcc56 cli/command/trust: SA1006: printf-style with no further arguments (staticcheck) 8dce5cdba3 cli/command/image/build: G107: Potential HTTP request made with variable url (gosec) 356d918639 cli/command/service: SA1012: do not pass a nil Context (staticcheck) 406e58f349 cli/command/secret: G101: Potential hardcoded credentials (gosec) b60f19d443 cli/compose/convert: driverObjectConfig - result 1 (error) is always nil (unparam) feabf9a1a7 e2e/container: containerExistsWithStatus - t is unused (unparam) dc7ad38270 cli/command/image/build/context_test.go:244:38: `createTestTempDir` - `prefix` always receives `"builder-context-test"` (unparam) a96c9f7fb3 cli/command/registry/login_test.go:66:25: unnecessary conversion (unconvert) 6fc683021d File is not `goimports`-ed (goimports) e04f71b179 cli/compose/convert/service_test.go:274:72: unnecessary conversion (unconvert) e0a19e5428 cli/command/trust/sign_test.go:119:70: unnecessary conversion (unconvert) 6ebeec5a54 Disable unparam linter: e2e/image/push_test.go:299:27: `withNotaryPassphrase` - `pwd` always receives `"foo"` (unparam) fc40566c78 Disable unparam linter: cli/required.go:102:16: `pluralize` - `word` always receives `"argument"` (unparam) 7ce0919e99 compose/loader: define type for transformer-functions 3e2e85ac3f disable unparam linter on these functions, as we need an error in these function signatures cd2bfde567 cli/compose/convert: result 1 (error) is always nil (unparam) b591d5805c cli/command/system/info.go:116:68: prettyPrintClientInfo - result 0 (error) is always nil (unparam) 0110e1a9fa cli/command/stack/kubernetes/deploy_test.go:65:68: `checkOwnerReferences` - `stackName` always receives `"test"` (unparam) cdaadd3714 cli/command/plugin/list_test.go:61:31: `TestList$1` - `filter` is unused (unparam) 949cd3a5a5 cli/command/image/build_session.go:133:45: getBuildSharedKey - result 1 (error) is always nil (unparam) 4de862fd32 cli/command/image/build_buildkit.go:450:56: parseSSH - result 1 (error) is always nil (unparam) 142ccde3b1 cli/command/image/build/context_test.go:252:71: `createTestTempFile` - `perm` always receives `0777` (`511`) (unparam) e6a8833c39 cli/command/image/build/context_test.go:244:38: `createTestTempDir` - `dir` always receives `""` (unparam) 7c4745bb2b unchecked errors 8f63ddef03 cli/command/container/attach.go:141:15: nilness: impossible condition: nil != nil (govet) db9be2bb14 opts/ulimit_test.go:11:13: composites: `*github.com/docker/cli/vendor/github.com/docker/go-units.Ulimit` composite literal uses unkeyed fields (govet) de156d566e cli/compose/types/types.go:106:2: structtag: struct field tag `yaml:",inline", json:"-"` not compatible with reflect.StructTag.Get: key:"value" pairs not separated by spaces (govet) f97c9969e2 cli/registry/client/fetcher.go:106:9: nilness: impossible condition: nil != nil (govet) 5e679e1088 cli/command/container/start.go:157:20: nilness: nil dereference in type assertion (govet) 6c3a85d5bd cli/command/stack/kubernetes/list.go:32:47: nilness: tautological condition: non-nil != nil (govet) 46b5db8f92 cli/command/trust/key_generate.go:112:9: nilness: impossible condition: nil != nil (govet) 34db4b6f2d SA1019: httputil.ErrPersistEOF is deprecated: No longer used. (staticcheck) 40eae09556 cli/command/container/stats.go:211:21: SA1015: using time.Tick leaks the underlying ticker, consider using it only in endless functions, tests and the main package, and use time.NewTicker here (staticcheck) abd320c8ee cli/command/trust/inspect_pretty_test.go:399:24: SA4010: this result of append is never used, except maybe in other appends (staticcheck) 11cd9341cf opts/throttledevice.go:51:5: SA4003: unsigned values are never < 0 (staticcheck) c7898382f0 compose/loader: fix TestIsAbs not testing all combinations 8f6e057d58 Gometalinter: raise deadline to 3 minutes db568b7af3 gometalinter: fix configuration 775adaed88 [19.03] Bump Golang 1.12.14 aa6bfe79fc Merge component 'packaging' from [email protected]:docker/docker-ce-packaging 19.03 c3d8c3468e Merge pull request #413 from arkodg/19.03 ec67290985 Add ubuntu-disco and ubuntu-eoan to deb Makefile 8529189e00 Add Ubuntu 19.10 "eoan" 45b0e46ce5 Merge pull request #638 from tiborvass/bump19036test e3e3a4e994 Bump VERSION to 19.03.6-test1 b875282b34 Merge component 'cli' from [email protected]:docker/cli 19.03 6fed018433 Merge pull request #2222 from thaJeztah/19.03_backport_fix_docker_cp_npe 250fddee49 docker cp: prevent NPE when failing to stat destination 93bf0c971f Bump hcsshim to b3f49c06ffaeef24d09c6c08ec8ec8425a 6ad4cf704c TestRunAttachFailedNoLeak: Compare lowercase a44ab059da bump Microsoft/hcsshim 2226e083fc390003ae5aa8325c3c92789afa0e7a f521821787 integration-cli: remove unnescessary conversions (unconvert) 08d18a123f Rename "v1" to "statsV1" c6b9bdb87c bump containerd/cgroups 5fbad35c2a7e855762d3c60f2e474ffcad0d470a c8bfd0a7a9 bump containerd/cgroups c4b9ac5c7601384c965b9646fc515884e091ebb9 298f6e1c08 Merge component 'packaging' from [email protected]:docker/docker-ce-packaging 19.03 0c8d8151ac RHEL8 iptables build fix (#410) 67f4391ce0 [19.03] Update containerd binary to v1.2.11 31d684a683 [19.03] Update to runc v1.0.0-rc9 df4aa4947c LCOW: Fix FROM scratch cdd97d5eee logger/gelf: Skip empty lines to comply with spec cbc9071e4a daemon: Use short libnetwork ID in exec-root & update libnetwork 60e2f6b3c9 Windows: Only set VERSION_QUAD if unset 1232d6d690 Windows: Use system specific parallelism value on containers restart 17870bcb42 cp: allow trailing slash in non-existant destination dfba6b8680 Add interpolation type cast for max_replicas_per_node Signed-off-by: Bruce Ashfield <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.