base: classes: kernel-fit-image: fix DTB iteration variable#220
Merged
ricardosalveti merged 1 commit intofoundriesio:masterfrom Oct 19, 2020
Merged
base: classes: kernel-fit-image: fix DTB iteration variable#220ricardosalveti merged 1 commit intofoundriesio:masterfrom
ricardosalveti merged 1 commit intofoundriesio:masterfrom
Conversation
When we use variable "i" to count iteratation through DTBS in fitimage_assemble. However, during each loop, we also call fitimage_emit_section_config which also uses a variable "i" to count loops when processing LOADABLES. This causes the value of "i" in the fitimage_assemble loop to seemingly stay the same or randomly change in odd ways. Let's fix the fitimage_assemble iteration count by renaming the variable to "n" which is not used elsewhere. Signed-off-by: Michael Scott <[email protected]>
quaresmajose
pushed a commit
that referenced
this pull request
Nov 9, 2022
Relevant changes: - 07c9d8e Merge pull request #239 from YoeDistro/yoe/mut - 25c9178 layers: Add langdale to LAYERSERIES_COMPAT - 6f9430d Merge pull request #231 from chrisdimich/master - c51905a nitrogen6sx: add required uboot variables for u-boot-boundary - 7aef299 Merge pull request #228 from angolini/rm-machines - 10bf4d7 imx7d-remarkable2: Remove machine - cb7ad45 ventana: Remove the machine - 4bced88 Merge pull request #226 from chrisdimich/master - fa0d5ec linux-boundary: bump revision to eb43cb07 - cd59504 Merge pull request #224 from chrisdimich/master - 18fe766 imx-atf-boundary: update do_deploy to fix binary path as per imx-boot - 3d0130f Merge pull request #222 from sergioprado/colibri-imx6-bootscript - 596d36a colibri-imx6: use soft assignment for u-boot-default-script provider - dfae23f Merge pull request #220 from MaxKrummenacher/master - 28aac37 mqxboot: prevent oe qa error, gnu_hash - 7e2e2d8 libmcc: prevent oe qa error, gnu_hash - 7a86916 kernel-module-mcc-toradex: cope with changes to kernel module build - 936a385 colibri-vf: use linux-toradex independent of the bsp - e59062b vf: follow SoC override changes also for vybrid - 6ee01e2 u-boot-timesys: remove 2011.12 recipe - f405db7 Merge pull request #217 from chrisdimich/master - cc9c239 linux-boundary: Upgrade to 5.15 - 80e234f Merge pull request #214 from MaxKrummenacher/u-boot-compat - fb198b6 Merge pull request #213 from MaxKrummenacher/master - 7f43964 machines: follow kernel deployment changes - 2454fc6 u-boot-toradex_2020.07: change to be compatible with any bsp Signed-off-by: Daiane Angolini <[email protected]>
quaresmajose
pushed a commit
that referenced
this pull request
Jan 10, 2023
Bumping go-errors to version v0.8.1-32-g5dd12d0, which comprises the following commits:
5dd12d0 AddingPowerSupport_CI/Testing (#234)
614d223 Revert "Support Go 1.13 error chains in `Cause` (#215)" (#220)
49f8f61 Support Go 1.13 error chains in `Cause` (#215)
004deef remove unnecessary use of fmt.Sprintf (#217)
6d954f5 feat: support std errors functions (#213)
7f95ac1 Add support for Go 1.13 error chains (#206)
91f1693 travis.yml: add Go 1.13
ca0248e fix travis, 1.10 doesnt support by unconvert anymore
27936f6 travis.yml: add Go 1.12 (#200)
856c240 Add json.Marshaler support to the Frame type. (#197)
ffb6e22 Reduce allocations in StackTrace.Format (#194)
e9933c1 Restore performance improvements from #150
ee1923e Return errors.Frame to a uintptr
72fa05e errors: detect unknown frames correctly (#192)
c38ea53 Remove errors.Frame to runtime.Frame conversions (#189)
c9e70be Makefile: switch to staticcheck (#187)
ee4766c Fix error during merge
584cbac Remove checks for old style anon funcs (#186)
42ce1b6 Remove Frame methods (#185)
937e8c5 gofmt -w
e19cb69 Remove last reference to runtime.FuncForPC (#184)
4f47277 Switch to runtime.CallersFrames (#183)
537896a travis: remove Go 1.8 and earlier (#182)
31aac83 travis: use Makefile (#181)
5ac96ae Update README.md
ba968bf gofmt -w errors.go (#179)
059132a Update .travis.yml (#168)
d58f942 Bump Travis versions (#172)
6ed0a2e Fix StackTrace print example
2233dee Copyedit the package documentation (#135)
e981d1a Add WithMessagef function (#118)
c059e47 fixed spelling (#156)
816c908 travis.yml: add Go 1.10 (#154)
e1ac100 reduce allocations when printing stack traces (#149)
30136e2 Remove deadcode (#146)
e881fd5 Fix minor typo in README.md (#142)
8842a6e Add badge for number of dependent libraries (#109)
e4f5060 Fix doc comment for exported Format func (#137)
f15c970 Remove an unused argument of utility test func (#139)
2b3a18b travis: add 1.9.x to go versions (#133)
c605e28 Add doc comment for exported Format func (#115)
ff09b13 Bump Go versions, use latest patch releases (#110)
bfd5150 Move benchmark assigned err to global exported variable (#106)
248dadf Bump Go versions (#91)
Signed-off-by: Bruce Ashfield <[email protected]>
quaresmajose
pushed a commit
that referenced
this pull request
Jan 10, 2023
Bumping pflag to version v1.0.5-4-gd5e0c06, which comprises the following commits:
d5e0c06 allow for blank ip addresses (#316)
85dd5c8 Add IPNetSlice and unit tests (#170)
6971c29 remove dead code for checking error nil (#282)
81378bb Add exported functions to preserve `pkg/flag` compatibility (#220)
14457a6 Remove require pflag v1.0.3
e8f2996 Fix typo in go.mod
8e39cc4 gofmt
68f4136 Add SliceValue Comments
b22fc70 Expand SliceValue support to all slice and array types.
c6c0f0f Add first SliceValue implementations
9722382 Added String-To-Int64 option parsing (#211)
4890c25 Fix package doc
b3e76d4 Fix descriptions for StringSlice functions
24fa697 fix misspell (#197)
916c5bf Fix typo in count.go (#196)
aea12ed add int32 & int64 slice support (#194)
454a7fb add float32 & float64 slice support (#192)
082b515 Travis: test on 1.9 as well (#191)
252d3ee travis: update to 1.10 and 1.11 in travis tests (#190)
0873577 Fix golint import path (#189)
b5e1a80 Sentence restructure and grammar fix (#188)
298182f Fix panic when parsing unknown flag followed by empty argument (#173)
d929dcb Handle single string=>string flags without quotes (#179)
947b89b Add map valued (string->string, string->int) flags. (#133)
9a97c10 bytes: add support for base64 encoded flags (#177)
3ebe029 Allow bubbling up of -test.* flags (#169)
583c0c0 Typo correction in flag.go (#164)
329ebf1 Allow Users To Show Deprecated Flags (#163)
1ce0cc6 make x.Parsed() return true after AddGoFlagSet(x) and pflag.Parse() (#162)
1cd4a0c add ability to ignore unknown flags (#160)
ad68c28 Add multiline wrapping support (#155)
45e82a3 Implement BytesHex type of argument (#115)
ee5fd03 doc: clarify difference between string slice vs. array (#158)
6a877eb DurationSlice: implementation and tests (#122)
4c012f6 Add uintSlice and boolSlice to name prettifier (#150)
97afa5e Prevent printing when using ContinueOnError (#144)
1f33b80 add int16 flag (#143)
a9789e8 Remove redundant break
2c300e7 Fixing Count flag usage string (#141)
be7121d Fix SetNormalizeFunc (#137)
5c2d607 Generate flag error output for errors returned from the parseFunc (#138)
7aff26d New: renamed intSlice to ints in usage
230e229 Fixed: updated unittest
adc6ccc New: added a default name to avoid stringSlice in the usage message.
e57e3ee Delete example, what isn't even shown in docs
80fe0fb Testing for Shorthand Lookup
75859d1 Add example to FlagSet.ShorthandLookup
86425cb Add example to ShorthandLookup
10b28b3 Add note about panic in ShorthandLookup
a84f757 Allow lookup by shorthand (#106)
c990990 Add Go 1.8.1 to .travis.yml
af3f947 Update .travis.yml
f1d95a3 Unify error message for panic and f.out
314c91c Use comparison a string with "" instead of comparison of len
1cd6182 Prevent parsing if there are no arguments
9c8891d Add more verbosity to panic of shorthand redefinition
1d9fab4 Use f.out in output flag deprecation
4995a3e Make more detailed error in Set
9421342 Add comments for better understanding of parsing short flags
159e1d7 Document Count function
e466d44 Delete setFlag
686edd7 Fix alreadythere variable name
af10531 Note about SortFlags in README
e453343 flag_test: fix go vet (#123)
0328f15 Cache sorted flags
9a906f1 Prevent changing order of flags after SetNormalizeFunc() (#121)
d16db1e Modified to display a string default value as double quoted and escaped (#118)
d90f37a Add SortFlags option (#113)
b205ad1 Change `ogier` to `spf13` in docs and README
9ff6c69 Add FlagSet.FlagUsagesWrapped(cols) which wraps to the given column (#105)
3f939ad Removed unused field "exitOnError".
Signed-off-by: Bruce Ashfield <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we use variable "i" to count iteratation through DTBS in
fitimage_assemble. However, during each loop, we also call
fitimage_emit_section_config which also uses a variable "i" to
count loops when processing LOADABLES. This causes the value
of "i" in the fitimage_assemble loop to seemingly stay the same
or randomly change in odd ways.
Let's fix the fitimage_assemble iteration count by renaming the
variable to "n" which is not used elsewhere.
Signed-off-by: Michael Scott [email protected]