base: lmp-device-register: Remove Docker App#213
Merged
ricardosalveti merged 4 commits intomasterfrom Sep 28, 2020
Merged
Conversation
doanac
reviewed
Sep 23, 2020
Member
doanac
left a comment
doanac
left a comment
There was a problem hiding this comment.
This is fine. I assume the git sha may/may-not change depending on how you merge the lmp-device-register change.
Contributor
Author
yes, I think so (no sha change in this PR), just wanted to verify it in my Factory. |
mike-sul
force-pushed
the
remove-docker-app
branch
from
51641e6 to
a68d0c2
Compare
Contributor
Author
|
I think it's ready to be merged |
| PACKAGECONFIG ?= "aklitetags dockerapp" | ||
| PACKAGECONFIG[aklitetags] = "-DAKLITE_TAGS=ON -DDEFAULT_TAG=${LMP_DEVICE_REGISTER_TAG},-DAKLITE_TAGS=OFF," | ||
| PACKAGECONFIG[dockerapp] = "-D${APP_TYPE}=ON,-D${APP_TYPE}=OFF," | ||
| PACKAGECONFIG[dockerapp] = "-DDOCKER_COMPOSE_APP=ON,-DDOCKER_COMPOSE_APP=OFF," |
Member
There was a problem hiding this comment.
As we're removing references for docker app, I think it would also make sense to rename this packageconfig variable to composeapp, just to avoid confusion.
Signed-off-by: Mike Sul <[email protected]>
Relevant changes: - 1660bfb: Remove docker apps support Signed-off-by: Mike Sul <[email protected]>
mike-sul
force-pushed
the
remove-docker-app
branch
from
61e1cd7 to
82d6111
Compare
Effectively BUILD_DOCKERAPP build flag is becoming useless as we build aklite with apps support anyway and this is rather runtime (sota.toml) configurations to turn on/off just an ostree pack manager or an ostree+app pack manager. Signed-off-by: Mike Sul <[email protected]>
Signed-off-by: Mike Sul <[email protected]>
Member
|
Great, just need to confirm with @doanac if the public builds were already converted. |
Member
|
We haven't converted containers.git to produce the new style compose apps, but I'm not sure if that should gate this. I'm going to go ahead and convert containers.git tonight though. |
Member
|
Yeah, let's merge this now. |
quaresmajose
pushed a commit
that referenced
this pull request
Nov 9, 2022
Relevant changes: - 07c9d8e Merge pull request #239 from YoeDistro/yoe/mut - 25c9178 layers: Add langdale to LAYERSERIES_COMPAT - 6f9430d Merge pull request #231 from chrisdimich/master - c51905a nitrogen6sx: add required uboot variables for u-boot-boundary - 7aef299 Merge pull request #228 from angolini/rm-machines - 10bf4d7 imx7d-remarkable2: Remove machine - cb7ad45 ventana: Remove the machine - 4bced88 Merge pull request #226 from chrisdimich/master - fa0d5ec linux-boundary: bump revision to eb43cb07 - cd59504 Merge pull request #224 from chrisdimich/master - 18fe766 imx-atf-boundary: update do_deploy to fix binary path as per imx-boot - 3d0130f Merge pull request #222 from sergioprado/colibri-imx6-bootscript - 596d36a colibri-imx6: use soft assignment for u-boot-default-script provider - dfae23f Merge pull request #220 from MaxKrummenacher/master - 28aac37 mqxboot: prevent oe qa error, gnu_hash - 7e2e2d8 libmcc: prevent oe qa error, gnu_hash - 7a86916 kernel-module-mcc-toradex: cope with changes to kernel module build - 936a385 colibri-vf: use linux-toradex independent of the bsp - e59062b vf: follow SoC override changes also for vybrid - 6ee01e2 u-boot-timesys: remove 2011.12 recipe - f405db7 Merge pull request #217 from chrisdimich/master - cc9c239 linux-boundary: Upgrade to 5.15 - 80e234f Merge pull request #214 from MaxKrummenacher/u-boot-compat - fb198b6 Merge pull request #213 from MaxKrummenacher/master - 7f43964 machines: follow kernel deployment changes - 2454fc6 u-boot-toradex_2020.07: change to be compatible with any bsp Signed-off-by: Daiane Angolini <[email protected]>
quaresmajose
pushed a commit
that referenced
this pull request
Jan 10, 2023
Bumping go-errors to version v0.8.1-32-g5dd12d0, which comprises the following commits:
5dd12d0 AddingPowerSupport_CI/Testing (#234)
614d223 Revert "Support Go 1.13 error chains in `Cause` (#215)" (#220)
49f8f61 Support Go 1.13 error chains in `Cause` (#215)
004deef remove unnecessary use of fmt.Sprintf (#217)
6d954f5 feat: support std errors functions (#213)
7f95ac1 Add support for Go 1.13 error chains (#206)
91f1693 travis.yml: add Go 1.13
ca0248e fix travis, 1.10 doesnt support by unconvert anymore
27936f6 travis.yml: add Go 1.12 (#200)
856c240 Add json.Marshaler support to the Frame type. (#197)
ffb6e22 Reduce allocations in StackTrace.Format (#194)
e9933c1 Restore performance improvements from #150
ee1923e Return errors.Frame to a uintptr
72fa05e errors: detect unknown frames correctly (#192)
c38ea53 Remove errors.Frame to runtime.Frame conversions (#189)
c9e70be Makefile: switch to staticcheck (#187)
ee4766c Fix error during merge
584cbac Remove checks for old style anon funcs (#186)
42ce1b6 Remove Frame methods (#185)
937e8c5 gofmt -w
e19cb69 Remove last reference to runtime.FuncForPC (#184)
4f47277 Switch to runtime.CallersFrames (#183)
537896a travis: remove Go 1.8 and earlier (#182)
31aac83 travis: use Makefile (#181)
5ac96ae Update README.md
ba968bf gofmt -w errors.go (#179)
059132a Update .travis.yml (#168)
d58f942 Bump Travis versions (#172)
6ed0a2e Fix StackTrace print example
2233dee Copyedit the package documentation (#135)
e981d1a Add WithMessagef function (#118)
c059e47 fixed spelling (#156)
816c908 travis.yml: add Go 1.10 (#154)
e1ac100 reduce allocations when printing stack traces (#149)
30136e2 Remove deadcode (#146)
e881fd5 Fix minor typo in README.md (#142)
8842a6e Add badge for number of dependent libraries (#109)
e4f5060 Fix doc comment for exported Format func (#137)
f15c970 Remove an unused argument of utility test func (#139)
2b3a18b travis: add 1.9.x to go versions (#133)
c605e28 Add doc comment for exported Format func (#115)
ff09b13 Bump Go versions, use latest patch releases (#110)
bfd5150 Move benchmark assigned err to global exported variable (#106)
248dadf Bump Go versions (#91)
Signed-off-by: Bruce Ashfield <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mike Sul [email protected]