[backport - scarthgap] fioconfig updates#1699
Merged
ricardosalveti merged 3 commits intofoundriesio:scarthgapfrom Jan 14, 2026
Merged
[backport - scarthgap] fioconfig updates#1699ricardosalveti merged 3 commits intofoundriesio:scarthgapfrom
ricardosalveti merged 3 commits intofoundriesio:scarthgapfrom
Conversation
doanac
reviewed
Jan 14, 2026
| GO_IMPORT = "github.com/foundriesio/fioconfig" | ||
| GO_IMPORT_PROTO ?= "https" | ||
| SRC_URI = "git://${GO_IMPORT};protocol=${GO_IMPORT_PROTO};branch=v94 \ | ||
| file://fioconfig.service \ |
Member
There was a problem hiding this comment.
I think you have to update this branch value
Member
Author
There was a problem hiding this comment.
nice catch, forgot we are using a different branch in scarthgap
Member
There was a problem hiding this comment.
yeah the other one comes from the fioconfig/main
Notable changes since v96: * fix(systemd): check if service is enabled before restarting * fix(contrib): don't restart aklite if its not enabled * move transport and config logic into public modules * make transport public APIs more usable * feat(fiotest): Add support for run-and-report (remote actions base) * feat(config): Make pkcs11 support optionally compiled * rework init functions to make them more extensible * feat(log): Move from log -> slog * feat(app): Make a public API for using this tool inside other apps like fioup * feat(log): Make CLI(with tty) and daemon log appropriately for given environment Signed-off-by: Andy Doan <[email protected]> (cherry picked from commit 7ba70b3) Signed-off-by: Ricardo Salveti <[email protected]>
This brings in changes from fioconfig: * e627342 Add init logic to configure remote actions * a9aa833 contrib: Add a action to run fio-diag.sh * a13b30f contrib: Add on-change handler for run-and-report Signed-off-by: Andy Doan <[email protected]> (cherry picked from commit 6092edc)
ricardosalveti
force-pushed
the
scarthgap
branch
from
da07aba to
da12b36
Compare
Member
Author
|
Failing to build still. |
Golang version available in scarthgap fails to build fioconfig with dynlink, disable as done for composectl. Signed-off-by: Ricardo Salveti <[email protected]>
quaresmajose
approved these changes
Jan 14, 2026
doanac
approved these changes
Jan 14, 2026
detsch
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.