scarthgap: keep the same IMAGE_NAME_SUFFIX as before#1580
scarthgap: keep the same IMAGE_NAME_SUFFIX as before#1580quaresmajose merged 2 commits intofoundriesio:mainfrom
Conversation
Fixup for [1]. The default value of IMAGE_NAME_SUFFIX is '.rootfs' but that can be changed so add support for that. [1] foundriesio@d024291 Signed-off-by: Jose Quaresma <[email protected]>
ricardosalveti
left a comment
ricardosalveti
left a comment
There was a problem hiding this comment.
LGTM, we should validate via CI, with pre-built containers and so on as well.
I have asked Mike Sul to help testing this and he validate the system assembly in his factory |
angolini
left a comment
angolini
left a comment
There was a problem hiding this comment.
"The default value in scarthgap of IMAGE_NAME_SUFFIX is '.rootfs'.
This will have several impacts on our CI so we will revert back
for the default value."
is confusing, maybe use:
"The default value in scarthgap of IMAGE_NAME_SUFFIX is '.rootfs'.
This will have several impacts on our CI so we will revert back
for the previous/lmp defaulf value."
Other than that, great work, thanks!
| sed -e 's/@@MACHINE@@/${MACHINE}/' ${S}/bootloader.uuu.in > bootloader.uuu | ||
| sed -e 's/@@MACHINE@@/${MACHINE}/' \ | ||
| -e 's/@@MFGTOOL_FLASH_IMAGE@@/${MFGTOOL_FLASH_IMAGE}/' \ | ||
| -e 's/@@IMAGE_NAME_SUFFIX@@/${IMAGE_NAME_SUFFIX}/' \ |
The default value in scarthgap of IMAGE_NAME_SUFFIX is '.rootfs'. This will have several impacts on our CI so we will revert back for the previous/lmp defaulf value. Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
force-pushed
the
image-name-suffix
branch
from
f57605e to
6f8cdba
Compare
I used your suggestion |
3 participants
The default value in scarthgap of IMAGE_NAME_SUFFIX is '.rootfs'.
This will have several impacts on our CI so we will revert back for the default value.