base: rc: aktualizr: Fix Yocto TMPDIR warning message#1567
base: rc: aktualizr: Fix Yocto TMPDIR warning message#1567angolini merged 1 commit intofoundriesio:mainfrom
Conversation
asn1c tool places the full absolute path for the asn1 files inside
comments of the generated source files. Make them relative to ${S} to
avoid the warning messages during do_package_qa.
Signed-off-by: Andre Detsch <[email protected]>
|
Using sed is prone to errors that go unnoticed. In my opinion I prefer the foundriesio/aktualizr#79 but lets get more opinions |
|
I understand and agree with #1567 (comment), but the reason for having it now is that the later PR was not working. So I would accept this change as an intermediate amend to the problem, and have it reworked properly for future aklite versions (using newer versions of generation tool, or changing that tool) It looks odd to worry so much about a path on a comment, but the reason behind it is reproducibility. |
That is correct, the change in akltualizr was not enough to fix the issue. Best would be to make asn1c not generate the full path in the comment, but this is not an option. |
3 participants
asn1c tool places the full absolute path for the asn1 files inside comments of the generated source files. Make them relative to ${S} to avoid the warning messages during do_package_qa.