Skip to content

Deprecate meta-xilinx - Remove the LmP direct support#1553

Merged
angolini merged 1 commit intofoundriesio:mainfrom
angolini:deprecation1
Jan 16, 2025
Merged

Deprecate meta-xilinx - Remove the LmP direct support#1553
angolini merged 1 commit intofoundriesio:mainfrom
angolini:deprecation1

Conversation

@angolini
Copy link
Copy Markdown
Contributor

@angolini angolini commented Jan 10, 2025

The plan is to have the support added as an partner layer, this way we can easier handle versioning.

This patch was created basically searching (find and grep) for the following keywords:

  • kv260
  • kv260-ebbr
  • zynqmp
  • uz3eg-iocc-sec
  • versal
  • vck190
  • kria
  • ultrazed
  • xlnx

I personally prefer one huge commit, please let me know what would be the best way to cluster the changes.

I tested by trying to build the removed images, but this is not good enough. So any idea on how to better test it, please let me know

@angolini angolini marked this pull request as ready for review January 10, 2025 19:31
@angolini angolini requested review from a team, mike-scott, quaresmajose and ricardosalveti and removed request for quaresmajose January 10, 2025 19:31
@ricardosalveti
Copy link
Copy Markdown
Member

Should we drop in a big commit and move the current logic to a meta-partner layer? I know we want to remove it from this layer, but we will have to add it all over again once we bring the latest bsp in a partner layer.

@mike-scott
Copy link
Copy Markdown
Contributor

I think we can keep these removal commits and mimic them when we add these back to a partner layer.

@ricardosalveti
Copy link
Copy Markdown
Member

The only issue is that most changes should later be applied at the same time, unless we break the removal into several commits (per logical blocks). I personally prefer with a big single commit, but fine with either way.

@quaresmajose
Copy link
Copy Markdown
Member

some more pieces to drop:

$ grep xlnx -r
meta-lmp-base/conf/distro/include/non-clangable.inc:OBJCOPY:pn-linux-lmp-xlnx:toolchain-clang = "${HOST_PREFIX}objcopy"
meta-lmp-base/conf/distro/include/non-clangable.inc:STRIP:pn-linux-lmp-xlnx:toolchain-clang = "${HOST_PREFIX}strip"
meta-lmp-base/conf/distro/include/non-clangable.inc:TOOLCHAIN:pn-u-boot-xlnx = "gcc"
meta-lmp-base/conf/distro/include/non-clangable.inc:# libmali-xlnx calls gcc directly on do_install
meta-lmp-base/conf/distro/include/non-clangable.inc:TOOLCHAIN:pn-libmali-xlnx = "gcc"
meta-lmp-bsp/recipes-kernel/linux/linux-lmp-xlnx_git.bb:KBRANCH = "xlnx_v5.15.y"

@quaresmajose
Copy link
Copy Markdown
Member

And also meta-lmp-bsp/dynamic-layers/xilinx-tools

@angolini
Copy link
Copy Markdown
Contributor Author

Thanks José, I haven't realized xlnx is also a keyword

@angolini
Copy link
Copy Markdown
Contributor Author

I prefer a huge commit, so I'm going to squash everything

The plan is to include it as a partner layer, this way we can better
handle versioning.

Searching (find and grep) for the following keywords:

 * kv260
 * zynqmp
 * uz3eg
 * versal
 * vck190
 * kria
 * ultrazed
 * xlnx

Signed-off-by: Daiane Angolini <[email protected]>
@angolini
Copy link
Copy Markdown
Contributor Author

updated

Copy link
Copy Markdown
Member

@quaresmajose quaresmajose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angolini angolini merged commit c3d48d9 into foundriesio:main Jan 16, 2025
angolini added a commit to angolini/meta-lmp that referenced this pull request Feb 12, 2025
Since [1] the Xilinx BSP is removed from meta-lmp. At that time the
keywords "uz" and "k26" were missing from the search, so these files
were missed during the removal.

This commit removes them.

[1] foundriesio#1553

Signed-off-by: Daiane Angolini <[email protected]>
ricardosalveti pushed a commit that referenced this pull request Feb 12, 2025
Since [1] the Xilinx BSP is removed from meta-lmp. At that time the
keywords "uz" and "k26" were missing from the search, so these files
were missed during the removal.

This commit removes them.

[1] #1553

Signed-off-by: Daiane Angolini <[email protected]>
mike-scott pushed a commit to mike-scott/meta-lmp that referenced this pull request Mar 18, 2025
Since [1] the Xilinx BSP is removed from meta-lmp. At that time the
keywords "uz" and "k26" were missing from the search, so these files
were missed during the removal.

This commit removes them.

[1] foundriesio#1553

Signed-off-by: Daiane Angolini <[email protected]>
@angolini angolini deleted the deprecation1 branch April 10, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants