Port to Yocto scarthgap [Part1] by quaresmajose · Pull Request #1538 · foundriesio/meta-lmp

quaresmajose · 2024-11-15T17:36:11Z

The full PR was submitted #1532 but it was very big and we decided to break it down into smaller parts to facilitate the review process.

These small parts have not been tested at all and only the complete PR has been, so it is quite possible that they will not work separately as they are submitted now.

The full list of changes that have been tested are at https://github.com/foundriesio/meta-lmp/tree/scarthgap-next

Because TI uses multiconfig we can't have this file names shared between machines in [1] | ERROR: mc:k3r5:u-boot-ti-staging-1_2023.04+git-r0 do_deploy: Recipe u-boot-ti-staging is trying to install files into a shared area when those files already exist. The files and the manifests listing them are: | /build/deploy/images/am62xx-evm/u-boot-ti-staging-config | (matched in manifest-am62xx_evm-u-boot-ti-staging.deploy) | Please adjust the recipes so only one recipe provides a given file. [1] meta-lmp-base/recipes-bsp/u-boot/u-boot-lmp-common.inc Signed-off-by: Jose Quaresma <[email protected]>

ricardosalveti · 2024-11-18T16:20:25Z

Can you please have the patches changing the same recipe done in sequence? Current flow makes it harder to review the individual changes.

quaresmajose · 2024-11-18T16:38:08Z

The current order is basically chronological, I'll try to change it to be by recipe

angolini

I reviewed the PR.
I would squash all commits for the same recipe together, but it does not hurt to leave it this way.
Thanks a lot for this!

This reverts commit 96d6173. merged https://git.yoctoproject.org/poky/commit/?id=b02bdaa5a5b1dc051849919785d4687bec1bfaf8 Signed-off-by: Jose Quaresma <[email protected]>

Signed-off-by: Jose Quaresma <[email protected]>

This reverts commit 35696b6. These patches are already included in ovmf 2022.11 Signed-off-by: Jose Quaresma <[email protected]>

Use the meta-openembedded version that is updated to b4e0673 Signed-off-by: Jose Quaresma <[email protected]>

We are facing some build erros on uz3eg-iocc-sec machine because we don't have sufficient space. | spl/u-boot-spl.bin exceeds file size limit: | limit: 0x26000 bytes | actual: 0x26009 bytes | excess: 0x9 bytes Signed-off-by: Jose Quaresma <[email protected]>

Signed-off-by: Jose Quaresma <[email protected]>

…this propose Use yocto variables for this propose: - KERNEL_MODULE_AUTOLOAD https://docs.yoctoproject.org/ref-manual/variables.html?highlight=kernel_module_autoload#term-KERNEL_MODULE_AUTOLOAD - KERNEL_MODULE_PROBECONF https://docs.yoctoproject.org/ref-manual/variables.html?highlight=kernel_module_autoload#term-KERNEL_MODULE_PROBECONF Signed-off-by: Jose Quaresma <[email protected]>

This reverts commit bceb837. Merged upstream https://git.yoctoproject.org/meta-security/commit/?id=0e648bae9cdb8a2f41bde1f9a3ecaaf5fb80df63 Signed-off-by: Jose Quaresma <[email protected]>

The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>

The imx-boot-container [1] is now only enabled on mx8m-generic-bsp machines. [1] Freescale/meta-freescale#1488 Signed-off-by: Jose Quaresma <[email protected]>

…dynamic Add boot container dynamic selection to imx-base.inc Freescale/meta-freescale#1492 Signed-off-by: Jose Quaresma <[email protected]>

quaresmajose · 2024-11-19T10:30:03Z

I reviewed the PR. I would squash all commits for the same recipe together, but it does not hurt to leave it this way. Thanks a lot for this!

I have squashed some commits especially the ones that did not contain any changes, the others I kept because this is important if it is necessary to make any bisect.
Thank you very much for your review.

quaresmajose · 2024-11-19T10:31:22Z

Can you please have the patches changing the same recipe done in sequence? Current flow makes it harder to review the individual changes.

@ricardosalveti I think I got it for a significant part.

Reference: https://git.openembedded.org/openembedded-core/commit/meta/recipes-core/systemd?id=c8c615329ad62a28c0762e79e7f11216f9bd88db Signed-off-by: Jose Quaresma <[email protected]>

- systemd v254 drops dependency on gnu-efi and add dependency on pyelftools for EFI builds Reference: https://git.openembedded.org/openembedded-core/commit/meta/recipes-core/systemd?id=95ed1fa4ff74a77deade51ad73b2f8963ff81548 Signed-off-by: Jose Quaresma <[email protected]>

The SRCREV_FORMAT variable must be set when multiple SCMs are used. | bb.data_smart.ExpansionError: Failure expanding variable SRCPV, expression was ${@bb.fetch2.get_srcrev(d)} which triggered exception FetchError: Fetcher failure: The SRCREV_FORMAT variable must be set when multiple SCMs are used. | The SCMs are: | git://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git;protocol=https;branch=main | git://github.com/NXP/imx-firmware.git;protocol=https;branch=lf-5.15.71_2.2.0;destsuffix=imx-firmware;name=imx-firmware; | The variable dependency chain for the failure is: SRCPV -> PV -> BP -> FILESPATH Signed-off-by: Jose Quaresma <[email protected]>

Signed-off-by: Jose Quaresma <[email protected]>

| find . -type f -exec sed -i 's/-\${PR}//g' {} + https://git.yoctoproject.org/poky/commit/?id=ad5464eb7ef5ab80f74b22bfb0f3dc63174b78cc https://git.yoctoproject.org/poky/commit/?id=1b94ea8b2516c929830fea716bb027a9ea1a3a1e https://git.yoctoproject.org/poky/commit/?id=d7ce7d67994f02367750d03e9e97ebdf89cd7a33 Signed-off-by: Jose Quaresma <[email protected]>

https://git.yoctoproject.org/poky/commit/?id=12da590768b9e51a66f425c07fbef266a0115395 Signed-off-by: Jose Quaresma <[email protected]>

Signed-off-by: Jose Quaresma <[email protected]>

- Update patches with devtool | Applying patch 0001-85-nm-unmanaged.rules-do-not-manage-docker-bridges.patch | patching file data/85-nm-unmanaged.rules | Hunk #1 succeeded at 30 with fuzz 2 (offset 4 lines). Signed-off-by: Jose Quaresma <[email protected]>

Signed-off-by: Jose Quaresma <[email protected]>

Rebase and refresh patches Signed-off-by: Jose Quaresma <[email protected]>

Signed-off-by: Jose Quaresma <[email protected]>

ricardosalveti

LGTM, please announce in platform that things will be temporarily broken as we merge this.

quaresmajose · 2024-11-21T16:50:13Z

I will wait for the proposed backports #1543 and foundriesio/lmp-manifest#468 so we can have a funcional tree with mostly the same content.

quaresmajose requested a review from a team November 15, 2024 17:36