bsp: meson: Backport 1.3.1.imx from scarthgap by angolini · Pull Request #1459 · foundriesio/meta-lmp

angolini · 2024-05-15T13:12:05Z

When using kirkstone with some scarthgap compatible metalayers, some gstreamer from the BSP layer require the version 0.62.1 or newer.

This patch brings this version from scarthgap as a backport.

This is to be removed when we start using Scarthgap branch by default.

Tested with bitbake gstreamer1.0

and also:

bitbake-layers show-recipes meson
=== Matching recipes: ===
meson:
  meta-lmp-bsp         0.63.3.imx
  meta                 0.61.3

quaresmajose · 2024-05-16T08:47:50Z

The meason is a critical piece to build the software so in my opinion we should use the upstream version and try to push this to the bsp that requires the version with some PREFERRED_VERSION_meson and renaming the recipe to be bsp specific. I think this is a IMX requirement so ended up with something like meson_0.62.1.imx that we make the default one with:

PREFERRED_VERSION_meson:imx-nxp-bsp ??= "0.62.1.imx"

if not possible to change upstream we can try the same on the meta-lmp-bsp layer.

ricardosalveti · 2024-05-16T16:33:23Z

in my opinion we should use the upstream version and try to push this to the bsp

+1, we can make it freescale specific to avoid having a side effect to the other layers.

angolini · 2024-05-17T12:37:12Z

We can also start using meta-gstreamer1.0 where all the backport is supported (although I haven't tested what it takes to integrate the layer directly).

My point is, gstreamer version might always be a point of pain when using mixed branches, although I think this is going to happen only now, and in the next LTS LmP will handle differently the branching schema.

What do you mean exactly by saying "we should use the upstream version"? Are you saying to push the 0.62.1 version to meta-freescale master?

ricardosalveti · 2024-05-20T22:03:27Z

We can also start using meta-gstreamer1.0 where all the backport is supported (although I haven't tested what it takes to integrate the layer directly).

For now I would prefer to avoid meta-gstreamer1.0 as that adds a lot of complexity and possible side effects here.

What do you mean exactly by saying "we should use the upstream version"? Are you saying to push the 0.62.1 version to meta-freescale master?

I think that would be a cherry-pick from oe-master based on the version we need, instead of fetching the recipe from meta-gstreamer1.0.

quaresmajose · 2024-05-21T08:12:24Z

We can also start using meta-gstreamer1.0 where all the backport is supported (although I haven't tested what it takes to integrate the layer directly).

For now I would prefer to avoid meta-gstreamer1.0 as that adds a lot of complexity and possible side effects here.

What do you mean exactly by saying "we should use the upstream version"? Are you saying to push the 0.62.1 version to meta-freescale master?

I think that would be a cherry-pick from oe-master based on the version we need, instead of fetching the recipe from meta-gstreamer1.0.

I mean having a downstream fork on meta-freescale[master] with a different version name 0.62.1.imx that can be chosen to be used on imx machines with PREFERRED_VERSION.
This meson version is only needed to build the gstreamer from meta-freescale[master] so it should be restricted to that bsp layer and not be of global use.
If you think it is not suitable for meta-freescale we can carry it in the same way in our meta-lmp-bsp layer.

angolini · 2024-06-04T21:30:29Z

+PREFERRED_VERSION_meson ?= "0.61.3"
+PREFERRED_VERSION_meson:imx8-nxp-bsp ?= "1.3.1.imx"
+PREFERRED_VERSION_meson:imx9-nxp-bsp ?= "1.3.1.imx"
+


because we are setting here PREFERRED_VERSION, we may want to mark this somehow as a backport.
I suggest we use the [REVERTME-scargthgap] tag as we use on factories https://docs.foundries.io/latest/reference-manual/linux/linux-update.html#common-pitfalls

we have more backports that are marked but I agree to mark it someway as it was easy to remember

yes, I'm still trying to find good ways to track the backports

I will recreate this patch, so we can see what it looks like with the tag

Instead of having the [REVERTME-scargthgap] tag on the commit title, I would rather open a new PR as draft revert this one

I think we can keep without the tag since this branch in particular is kirkstone specific, having it under recipes-backports is already enough from my perspective.

I believe we will have to keep 2 branches in order to keep kirkstone and scarthgap in place, so we would just skip this from merging in scarthgap.

ricardosalveti · 2024-06-11T22:20:41Z

Hm, do we need version 1.3.1? That is a major bump, I was thinking we would end up backporting 0.63 or close by.

angolini · 2024-06-17T14:05:42Z

Those are the versions:

scarthgap meson 1.3.1
nanbield meson 1.2.2
mickledore meson 1.0.1
langdale meson 0.63.3
kirkstone meson 0.61.3

The requirement is to be 0.62 or newer

the version from meta-multimedia is 0.62.y and it was ok, that's why I chose that one at first. This time I thought it would be better to already go to scarthgap version, but I'm ok to recreate the PR.

quaresmajose · 2024-06-17T16:22:50Z

The langdale version 0.63.3 is more aligned in my opinion

ricardosalveti

LGTM (with the revert removal from the commit message).

When using kirkstone with some scarthgap compatible meta layers some gstreamer from the BSP layer require the meson version 0.62.1 or newer. This commit copies from oe/meta at langdale. Signed-off-by: Daiane Angolini <[email protected]>

angolini · 2024-06-20T21:13:15Z

LGTM (with the revert removal from the commit message).

done @ricardosalveti

This reverts commit 915af2c. - Reverts scarthgap meson backport bsp: meson: Backport 1.3.1.imx from scarthgap foundriesio#1459 Signed-off-by: Jose Quaresma <[email protected]>

This reverts commit c8db41e. - Reverts scarthgap meson backport bsp: meson: Backport 1.3.1.imx from scarthgap foundriesio#1459 Signed-off-by: Jose Quaresma <[email protected]>

This reverts commit 915af2c. - Reverts scarthgap meson backport bsp: meson: Backport 1.3.1.imx from scarthgap foundriesio#1459 Signed-off-by: Jose Quaresma <[email protected]>

This reverts commit c8db41e. - Reverts scarthgap meson backport bsp: meson: Backport 1.3.1.imx from scarthgap foundriesio#1459 Signed-off-by: Jose Quaresma <[email protected]>

This reverts commit 915af2c. - Reverts scarthgap meson backport bsp: meson: Backport 1.3.1.imx from scarthgap #1459 Signed-off-by: Jose Quaresma <[email protected]>

This reverts commit c8db41e. - Reverts scarthgap meson backport bsp: meson: Backport 1.3.1.imx from scarthgap #1459 Signed-off-by: Jose Quaresma <[email protected]>

angolini changed the title ~~bsp: meson: Backport 0.62.1 from scarthgap~~ [RFC] bsp: meson: Backport 0.62.1 from scarthgap May 15, 2024

angolini marked this pull request as ready for review May 15, 2024 13:13

ricardosalveti requested a review from a team May 15, 2024 13:20

angolini force-pushed the backport-meson branch from ec9bbea to 64c6126 Compare May 31, 2024 21:27

angolini requested a review from ricardosalveti May 31, 2024 21:31

angolini force-pushed the backport-meson branch from 64c6126 to ffdfa3b Compare June 4, 2024 21:24

angolini changed the title ~~[RFC] bsp: meson: Backport 0.62.1 from scarthgap~~ [RFC] bsp: meson: Backport 1.3.1.imx from scarthgap Jun 4, 2024

angolini commented Jun 4, 2024

View reviewed changes

quaresmajose reviewed Jun 5, 2024

View reviewed changes

Comment thread meta-lmp-bsp/conf/machine/include/lmp-machine-custom.inc Outdated

angolini changed the title ~~[RFC] bsp: meson: Backport 1.3.1.imx from scarthgap~~ bsp: meson: Backport 1.3.1.imx from scarthgap Jun 6, 2024

angolini force-pushed the backport-meson branch from ffdfa3b to eb26b5a Compare June 7, 2024 16:07

angolini requested a review from quaresmajose June 7, 2024 16:09

angolini force-pushed the backport-meson branch from eb26b5a to d88911e Compare June 19, 2024 13:40

ricardosalveti approved these changes Jun 20, 2024

View reviewed changes

bsp: meson: backport version 0.63.3

ef8c420

When using kirkstone with some scarthgap compatible meta layers some gstreamer from the BSP layer require the meson version 0.62.1 or newer. This commit copies from oe/meta at langdale. Signed-off-by: Daiane Angolini <[email protected]>

angolini force-pushed the backport-meson branch from d88911e to ef8c420 Compare June 20, 2024 21:12

ricardosalveti merged commit c8db41e into foundriesio:main Jun 21, 2024

angolini deleted the backport-meson branch August 21, 2024 13:54

Conversation

angolini commented May 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

quaresmajose commented May 16, 2024

Uh oh!

ricardosalveti commented May 16, 2024

Uh oh!

angolini commented May 17, 2024

Uh oh!

ricardosalveti commented May 20, 2024

Uh oh!

quaresmajose commented May 21, 2024

Uh oh!

angolini Jun 4, 2024

Choose a reason for hiding this comment

Uh oh!

quaresmajose Jun 5, 2024

Choose a reason for hiding this comment

Uh oh!

angolini Jun 7, 2024

Choose a reason for hiding this comment

Uh oh!

quaresmajose Jun 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ricardosalveti Jun 19, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ricardosalveti commented Jun 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

angolini commented Jun 17, 2024

Uh oh!

quaresmajose commented Jun 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ricardosalveti left a comment

Choose a reason for hiding this comment

Uh oh!

angolini commented Jun 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

angolini commented May 15, 2024 •

edited

Loading

quaresmajose Jun 19, 2024 •

edited

Loading

ricardosalveti commented Jun 11, 2024 •

edited

Loading

quaresmajose commented Jun 17, 2024 •

edited

Loading