base: Add lmp-signing#1311
Conversation
MrCry0
left a comment
There was a problem hiding this comment.
LGTM with a minor note:
I'd shorten the commit subject to avoid wrapping it:
base: lmp-staging: Adds function to take in consideration the hash of… … the keys to, like, base: lmp-staging: Store hash of varfiles to vardeps
ab1c2d2 to
fa4c88c
Compare
Thanks for the sugestion. |
ricardosalveti
left a comment
There was a problem hiding this comment.
LGTM for the kernel module signing, but for the original issue we were concerned with we should also track the content for the keys used for signing the kernel fitimage (u-boot signing key).
fa4c88c to
f7f4b8a
Compare
|
The |
|
The As can be see every task that uses the keys will run again: |
|
Tests for |
|
Nice, looks fine from the code perspective, we should be good once you finish testing/validating with the u-boot based keys. |
|
The As can be see every task that uses the keys will run again: |
|
The As can be see every task that uses the keys will run again: |
This bitbake class will store the hash of the keys files so that all tasks using these keys will re-run when the keys changed. The main function add_varfiles_hash_to_vardeps_of_var is used for adding the hash value of the files in 'varfiles' on the 'var' variable dependency chain. Signed-off-by: Jose Quaresma <[email protected]>
Start tracking keys content/hash changes into consideration to invalidate sstate-cache. Signed-off-by: Jose Quaresma <[email protected]>
f7f4b8a to
9417b32
Compare
Done and ready to merge |
This bitbake class will store the hash of the keys files so that all tasks using these keys will re-run when the keys changed.
The main function add_varfiles_hash_to_vardeps_of_var is used for adding the hash value of the files in 'varfiles' on the 'var' variable dependency chain.
To unblock #916