base: lmp: sota_var_cleanup: use the ostree_rmdir_helper#1148
Merged
ricardosalveti merged 1 commit intofoundriesio:mainfrom May 18, 2023
Merged
base: lmp: sota_var_cleanup: use the ostree_rmdir_helper#1148ricardosalveti merged 1 commit intofoundriesio:mainfrom
ricardosalveti merged 1 commit intofoundriesio:mainfrom
Conversation
MrCry0
approved these changes
May 17, 2023
quaresmajose
force-pushed
the
ostree_rmdir_helper
branch
from
6585b4a to
5c861ed
Compare
It will help removing directories with content inside without failing. Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
force-pushed
the
ostree_rmdir_helper
branch
from
5c861ed to
15c3a08
Compare
MrCry0
approved these changes
May 18, 2023
| ostree_rmdir_helper local | ||
| ostree_rmdir_helper lib/misc | ||
| ostree_rmdir_helper volatile | ||
| ostree_rmdir_helper ${@'' if oe.types.boolean('${VOLATILE_LOG_DIR}') else 'log'} |
Member
There was a problem hiding this comment.
This will call helper with empty inputs when VOLATILE_LOG_DIR is not set, we should probably have an if here instead to avoid surprises later on.
Member
Author
There was a problem hiding this comment.
I have tested it explicit call one only with just ostree_rmdir_helper and it works with an empty arg, because it check if the arg is a directory and not a link before removing and when the arg is empty the functions does nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It will help removing directories with content inside without failing.