lmp-boot-firmware: cleanup and minor changes#1145
Merged
ricardosalveti merged 4 commits intofoundriesio:mainfrom Jun 14, 2023
Merged
lmp-boot-firmware: cleanup and minor changes#1145ricardosalveti merged 4 commits intofoundriesio:mainfrom
ricardosalveti merged 4 commits intofoundriesio:mainfrom
Conversation
angolini
approved these changes
May 9, 2023
MrCry0
approved these changes
May 9, 2023
Member
|
Can you please extend the commit message on every change to avoid having changes with subject only descriptions? |
Signed-off-by: Jose Quaresma <[email protected]>
Modify content on the work or source dir is not safe and can result in build errors Signed-off-by: Jose Quaresma <[email protected]>
We can store the full path on FIRMWARE_DEPLOY_DIR to avoid contatenation Signed-off-by: Jose Quaresma <[email protected]>
Instaed of deploying each file one by one we can deploy the full dir Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
force-pushed
the
lmp-boot-firmware
branch
from
073d58f to
ffed48b
Compare
Member
Author
Added descriptions in all except the indentation fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.