Skip to content

base:rs: Bump ostreeuploader version to b18f2c3#1129

Merged
ricardosalveti merged 1 commit intomainfrom
bump-ostreeuploader
May 2, 2023
Merged

base:rs: Bump ostreeuploader version to b18f2c3#1129
ricardosalveti merged 1 commit intomainfrom
bump-ostreeuploader

Conversation

@mike-sul
Copy link
Copy Markdown
Contributor

@mike-sul mike-sul commented May 2, 2023

Related changes:

  • bbf045d Pass URL to ostreeuploader module for token authentication
  • 8fc3962 Use POST call for doing object check
  • 867760d cli: Add a fio token as an input parameter
  • ae83a21 Do request retry if makes sense
  • cb1e821 Set timeouts for check and push requests.
  • 0372bd4 ostreeuploader: print response body if error
  • f102075 ostreeuploader: upload and check delta indexes
  • e9f4390 fiocheck: check delta objects for v2 API
  • 29ca44f fiosync: use the last available download origin
  • deef2d3 ostreeuploader: use API v2 by default

Related changes:
- bbf045d Pass URL to ostreeuploader module for token authentication
- 8fc3962 Use POST call for doing object check
- 867760d cli: Add a fio token as an input parameter
- ae83a21 Do request retry if makes sense
- cb1e821 Set timeouts for check and push requests.
- 0372bd4 ostreeuploader: print response body if error
- f102075 ostreeuploader: upload and check delta indexes
- e9f4390 fiocheck: check delta objects for v2 API
- 29ca44f fiosync: use the last available download origin
- deef2d3 ostreeuploader: use API v2 by default
- c6d70ad ostreeuploader: add basic guide to README

Signed-off-by: Mike <[email protected]>
@mike-sul mike-sul requested review from doanac and ricardosalveti May 2, 2023 08:21
Copy link
Copy Markdown
Member

@quaresmajose quaresmajose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

base: ostreeuploader: bump version to b18f2c3 is more perceptible in my opinion.

Copy link
Copy Markdown
Member

@doanac doanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this only affect people building the LmP outside our CI (or lp-sdk container)

@mike-sul
Copy link
Copy Markdown
Contributor Author

mike-sul commented May 2, 2023

And this only affect people building the LmP outside our CI (or lp-sdk container)

Correct, I tested it, it works as expected.

Copy link
Copy Markdown
Member

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardosalveti ricardosalveti merged commit 6897683 into main May 2, 2023
@quaresmajose quaresmajose deleted the bump-ostreeuploader branch May 9, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants