base: move var clean up from base-files to lmp.bbclass#1125
Merged
ricardosalveti merged 2 commits intofoundriesio:mainfrom Apr 26, 2023
Merged
base: move var clean up from base-files to lmp.bbclass#1125ricardosalveti merged 2 commits intofoundriesio:mainfrom
ricardosalveti merged 2 commits intofoundriesio:mainfrom
Conversation
This folder is created at runtime via systemd tmpfiles.d. Signed-off-by: Ricardo Salveti <[email protected]>
Var directories, created by base-files, are also used by the rootfs task while performing the image bootstrap process (via packages), so they can't be removed at the base-files package level. Move the removal logic to lmp.bbclass via ROOTFS_POSTPROCESS_COMMAND task, which is executed only when ota-ext4 is set in IMAGE_FSTYPES (only way to know when an ostree image is to be created), after all required rootfs packages are installed. Only dirs that can't be removed at this stage are /var/lib and /var/cache as they are used to store packaging related metadata. Signed-off-by: Ricardo Salveti <[email protected]>
MrCry0
approved these changes
Apr 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Var directories, created by base-files, are also used by the rootfs task while performing the image bootstrap process (via packages), so they can't be removed at the base-files package level.
Move the removal logic to lmp.bbclass via ROOTFS_POSTPROCESS_COMMAND task, which is executed only when ota-ext4 is set in IMAGE_FSTYPES (only way to know when an ostree image is to be created), after all required rootfs packages are installed. Only dirs that can't be removed at this stage are /var/lib and /var/cache as they are used to store packaging related metadata.