ALSA for ostree#1077
Merged
ricardosalveti merged 5 commits intofoundriesio:mainfrom Mar 28, 2023
Merged
Conversation
MrCry0
force-pushed
the
main-alsa
branch
2 times, most recently
from
da99f76 to
1dac2b7
Compare
Tim-Anderson
approved these changes
Mar 23, 2023
Contributor
Tim-Anderson
left a comment
Tim-Anderson
left a comment
There was a problem hiding this comment.
one thing that is missing is adding fio to the audio group
Otherwise LGTM
An vendor-shipped asound.state config file is required by the most of sound systems. Installing this file as /usr/lib/alsa/asound.state to avoid various issue. Add a fallback to scripts to try restoring sound configuration from this file if default /var/lib/alsa/asound.state is unavailable. Signed-off-by: Oleksandr Suvorov <[email protected]>
Contributor
Author
@Tim-Anderson It's already in place 9742ad8 |
MrCry0
force-pushed
the
main-alsa
branch
3 times, most recently
from
48edb58 to
2b9ddf3
Compare
A path to asound.state config file is hardcoded in alsactl. Add a fallback for alsactl to lookup for asound.state in /usr/lib/alsa. Move creating /var/lib/alsa directory to tmpfiles systemd service. Signed-off-by: Oleksandr Suvorov <[email protected]>
Add a full-featured alsa-utils and alsa-tools packages to debug sound issues. Signed-off-by: Oleksandr Suvorov <[email protected]>
Install the alsa-utils-aplay as a part of "packagegroup-base-alsa" as an important tool set for using alsa feature. Signed-off-by: Oleksandr Suvorov <[email protected]>
ALSA is useful sound subsystem and can be used alongside pulseaudio. Enable it by default. Signed-off-by: Oleksandr Suvorov <[email protected]>
quaresmajose
approved these changes
Mar 27, 2023
ricardosalveti
approved these changes
Mar 28, 2023
Member
ricardosalveti
left a comment
ricardosalveti
left a comment
There was a problem hiding this comment.
LGTM, thanks for working on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes ALSA work well on ostree-based distros, add the ALSA feature and enable it by default.
Re-tested on: