base: fioconfig: Bump version#1075
Merged
ricardosalveti merged 1 commit intofoundriesio:mainfrom Apr 3, 2023
Merged
Conversation
Includes changes for: * Improved retry handling when cert rotation fails * Move from umbracle/ecies to foundries/ecies fork Signed-off-by: Andy Doan <[email protected]>
Member
Author
Member
|
In the end I think it will take more than 10s, so won't necessarily get in a failed state here. The question that follows is how do we want fioconfig service logic to be managed in case of failures? I guess we can always restart if failed in a range, which would cover the expected failure use case, and fail hard when in a crash loop (causing the rest of the system to reboot?). |
ricardosalveti
approved these changes
Apr 3, 2023
Member
ricardosalveti
left a comment
ricardosalveti
left a comment
There was a problem hiding this comment.
LGTM, will merge so we can do a bit more testing here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes changes for: