Skip to content

bsp: optee-os-fio: enable CAAM for imx7ulpea-com#1068

Merged
ricardosalveti merged 1 commit intofoundriesio:mainfrom
MrCry0:main-7ulpea-com
Mar 15, 2023
Merged

bsp: optee-os-fio: enable CAAM for imx7ulpea-com#1068
ricardosalveti merged 1 commit intofoundriesio:mainfrom
MrCry0:main-7ulpea-com

Conversation

@MrCry0
Copy link
Copy Markdown
Contributor

@MrCry0 MrCry0 commented Mar 15, 2023

OP-TEE seems to support CAAM for 7ulp. Enable it to fix building error

lmp/work/imx7ulpea_ucom-lmp-linux-gnueabi/optee-os-tadevkit/3.20.0+git-r0/build/export-ta_arm32/ta/7f10a757-4139-4eae-90c9-f2b2eb118139.ta
| arm-lmp-linux-gnueabi-ld.bfd: /srv/oe/build/tmp-lmp/work/imx7ulpea_ucom-lmp-linux-gnueabi/optee-os-tadevkit/3.20.0+git-r0/build/core/kernel/huk_subkey.o: in function `huk_subkey_derive':
| /srv/oe/build/tmp-lmp/work/imx7ulpea_ucom-lmp-linux-gnueabi/optee-os-tadevkit/3.20.0+git-r0/git/core/kernel/huk_subkey.c:78: undefined reference to `tee_otp_get_hw_unique_key'
| make: *** [core/arch/arm/kernel/link.mk:69: /srv/oe/build/tmp-lmp/work/imx7ulpea_ucom-lmp-linux-gnueabi/optee-os-tadevkit/3.20.0+git-r0/build/core/all_objs.o] Error 1

Copy link
Copy Markdown
Member

@quaresmajose quaresmajose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally and fixes the link error

@MrCry0 MrCry0 requested review from a team and vanmaegima March 15, 2023 11:17
@MrCry0
Copy link
Copy Markdown
Contributor Author

MrCry0 commented Mar 15, 2023

LGTM, tested locally and fixes the link error

Thanks! We may wait for @vanmaegima 's approvement, Vanessa knows more about 7ulp ;-)

OP-TEE seems to support CAAM for 7ulp. Enable it to fix building
error [1].

[1]
core/kernel/huk_subkey.o: in function `huk_subkey_derive':
core/kernel/huk_subkey.c:78: undefined reference to `tee_otp_get_hw_unique_key'

Signed-off-by: Oleksandr Suvorov <[email protected]>
@ricardosalveti
Copy link
Copy Markdown
Member

Yeah, thanks for looking at this one, we should be good as we only want to make sure we're able to build correctly for it at this moment, as we will later move to the optee imx bsp version instead (only for ulp).

Copy link
Copy Markdown
Member

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardosalveti ricardosalveti merged commit ea0b764 into foundriesio:main Mar 15, 2023
@MrCry0 MrCry0 deleted the main-7ulpea-com branch March 27, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants