Aligning SDMA firmware version and load logic with NXP BSP#1057
Merged
ricardosalveti merged 4 commits intofoundriesio:mainfrom Mar 1, 2023
Merged
Aligning SDMA firmware version and load logic with NXP BSP#1057ricardosalveti merged 4 commits intofoundriesio:mainfrom
ricardosalveti merged 4 commits intofoundriesio:mainfrom
Conversation
Relevant changes: - d55fd7d3 bsp: imx: enable FW_LOADER_USER_HELPER Signed-off-by: Ricardo Salveti <[email protected]>
Make the sdma-imx6q/7d packages available for runtime. Signed-off-by: Ricardo Salveti <[email protected]>
Follow the NXP BSP and drop the upstream linux sdma packages from the package list. Signed-off-by: Ricardo Salveti <[email protected]>
Follow the NXP BSP and prefer the SDMA provided by the firmware-imx recipe. Also add firmwared as it is the legacy way of loading firmware with help from userspace, which is still required for SDMA. Signed-off-by: Ricardo Salveti <[email protected]>
quaresmajose
approved these changes
Mar 1, 2023
angolini
approved these changes
Mar 1, 2023
| @@ -0,0 +1,4 @@ | |||
| do_install:append() { | |||
Contributor
There was a problem hiding this comment.
if this is needed here, I wonder if this is needed upstream.
I'm up to reworking the firmware-imx_8 recipe mainline. I'm adding a note here, so that when I'm working on this, I remember where it's coming from
Member
Author
There was a problem hiding this comment.
It is already there, but commented out.
Yeah, for upstream I would probably do this differently via providers or similar, as we have 2 recipes providing conflicting packages, and the ideal approach would this to be selected at runtime (not done here as we only use the NXP BSP, so we're good to assume that the one to use is firmware-imx).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have SDMA provided by firmware-imx (latest revision) and add firmwared as it is required for early loading of the firmware when booting the system.