Skip to content

[Backport Honister] bluez5: enable using libedit#1046

Merged
ricardosalveti merged 2 commits intofoundriesio:honisterfrom
MrCry0:honister-bluez-libedit
Feb 28, 2023
Merged

[Backport Honister] bluez5: enable using libedit#1046
ricardosalveti merged 2 commits intofoundriesio:honisterfrom
MrCry0:honister-bluez-libedit

Conversation

@MrCry0
Copy link
Copy Markdown
Contributor

@MrCry0 MrCry0 commented Feb 16, 2023

The backported version of enabling bluetoothctl with libedit.

@vanmaegima this version can be used in customers' factories.

Support automatic choose between readline/libedit for client and mesh
package features of bluez5.

Upstream-Status: Pending
Signed-off-by: Oleksandr Suvorov <[email protected]>
Add libedit config to bluez5 to be able to build a client feature
of bluez5 (bluetoothctl tool).

Signed-off-by: Oleksandr Suvorov <[email protected]>
@MrCry0 MrCry0 force-pushed the honister-bluez-libedit branch from da329d1 to d2d93d6 Compare February 16, 2023 15:58
@vanmaegima
Copy link
Copy Markdown
Member

@MrCry0 thanks for this, I can test it on the customer factory next week, is this ok?

@MrCry0
Copy link
Copy Markdown
Contributor Author

MrCry0 commented Feb 16, 2023

@MrCry0 thanks for this, I can test it on the customer factory next week, is this ok?

Sure, no problem! Just remember the bluetooth.service should be started as well.

@MrCry0 MrCry0 requested review from a team, igoropaniuk and quaresmajose February 16, 2023 19:32
Copy link
Copy Markdown
Member

@vanmaegima vanmaegima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a v86 factory and it works, thanks for this!

Copy link
Copy Markdown
Member

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardosalveti ricardosalveti merged commit 188e14f into foundriesio:honister Feb 28, 2023
@MrCry0 MrCry0 deleted the honister-bluez-libedit branch March 27, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants