base: bluez5: enable using libedit#1044
Merged
MrCry0 merged 2 commits intofoundriesio:mainfrom Feb 16, 2023
Merged
Conversation
MrCry0
requested review from
Tim-Anderson,
angolini,
igoropaniuk,
quaresmajose,
ricardosalveti and
vanmaegima
Contributor
Author
|
@vanmaegima Honister-based backport of this solution is coming. |
MrCry0
force-pushed
the
main-bluez-libedit
branch
from
23a1afe to
01583d2
Compare
quaresmajose
approved these changes
Feb 13, 2023
angolini
approved these changes
Feb 13, 2023
Member
|
Nice work, patch small enough that can be maintained easily here. Would be nice to confirm with @vanmaegima that the non-interactive usage is indeed ok for the customer. |
MrCry0
force-pushed
the
main-bluez-libedit
branch
2 times, most recently
from
8174bb8 to
961dccd
Compare
quaresmajose
approved these changes
Feb 16, 2023
Member
quaresmajose
left a comment
quaresmajose
left a comment
There was a problem hiding this comment.
LGTM with little suggestion that can be implemented after
Support automatic choose between readline/libedit for client and mesh package features of bluez5. Upstream-Status: Pending Signed-off-by: Oleksandr Suvorov <[email protected]>
Add libedit config to bluez5 to be able to build a client feature of bluez5 (bluetoothctl tool). Signed-off-by: Oleksandr Suvorov <[email protected]>
MrCry0
force-pushed
the
main-bluez-libedit
branch
from
961dccd to
dfe0cc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support using libedit for client package feature of bluez5 if GPLv3 packages are disabled.
Signed-off-by: Oleksandr Suvorov [email protected]