Skip to content

Remove meta-ti-extras layer dependencies#1008

Merged
ricardosalveti merged 3 commits intofoundriesio:mainfrom
quaresmajose:remove-meta-ti-extras
Jan 18, 2023
Merged

Remove meta-ti-extras layer dependencies#1008
ricardosalveti merged 3 commits intofoundriesio:mainfrom
quaresmajose:remove-meta-ti-extras

Conversation

@quaresmajose
Copy link
Copy Markdown
Member

This is a temporary workaround to remove the dependencie in
meta-ti-extras until the patch is merged upstream.
https://lists.yoctoproject.org/g/meta-ti/message/15567
https://lists.yoctoproject.org/g/meta-ti/message/15568
https://lists.yoctoproject.org/g/meta-ti/message/15569

The meta-ti-bsp layer is still broken for K3 HS platforms.

The patch [1] makes the check-layer happy again as it does not
fail any more during bitbake parsing but it will be difficult
for the end user to discover this dependency on meta-ti-extras.
On the other side, meta-ti-extras depends on meta-ti-bsp so
this is a circular dependency.

Currently the layer is broken for am62xx-evm/am64xx-evm machines:

ERROR: Nothing PROVIDES 'ti-k3-secdev-native' (but mc:k3r5:/srv/oe/build/conf/../../layers/meta-ti/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb DEPENDS on or otherwise requires it). Close matches:
  libtspi-dev-native
  makedevs-native

[1] - 8e43835c ti-sci-fw: make dependency on meta-ti-extras soft

Copy link
Copy Markdown
Contributor

@MrCry0 MrCry0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread meta-lmp-bsp/dynamic-layers/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb Outdated
This is a temporary workaround to remove the dependencie in
meta-ti-extras until the patch is merged upstream.
https://lists.yoctoproject.org/g/meta-ti/message/15567

The meta-ti-bsp layer is still broken for K3 HS platforms.

The patch [1] makes the check-layer happy again as it does not
fail any more during bitbake parsing but it will be difficult
for the end user to discover this dependency on meta-ti-extras.
On the other side, meta-ti-extras depends on meta-ti-bsp so
this is a circular dependency.

Currently the layer is broken for am62xx-evm/am64xx-evm machines:

| ERROR: Nothing PROVIDES 'ti-k3-secdev-native' (but mc:k3r5:/srv/oe/build/conf/../../layers/meta-ti/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb DEPENDS on or otherwise requires it). Close matches:
|  libtspi-dev-native
|  makedevs-native

[1] - 8e43835c ti-sci-fw: make dependency on meta-ti-extras soft

Signed-off-by: Jose Quaresma <[email protected]>
This is a temporary workaround to remove the dependencie in
meta-ti-extras until the patch is merged upstream.
https://lists.yoctoproject.org/g/meta-ti/message/15568

The TI_K3_SECDEV_INSTALL_DIR_RECIPE is defined on the meta-ti-extras layer
so when the layer is not used the variable is undefined.
For such cases we can use default value that is the same defined
on the recipes-ti/includes/ti-paths.inc

Signed-off-by: Jose Quaresma <[email protected]>
This is a temporary workaround to remove the dependencie in
meta-ti-extras until the patch is merged upstream.
https://lists.yoctoproject.org/g/meta-ti/message/15569

The TI_K3_SECDEV_INSTALL_DIR is defined on the meta-ti-extras layer
so when the layer is not used the variable is undefined.
For such cases we can use default value that is the same defined
on the recipes-ti/includes/ti-paths.inc

Signed-off-by: Jose Quaresma <[email protected]>
@quaresmajose quaresmajose force-pushed the remove-meta-ti-extras branch from 2f1133e to f890a5d Compare January 18, 2023 15:35
Copy link
Copy Markdown
Member

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardosalveti ricardosalveti merged commit 6db002d into foundriesio:main Jan 18, 2023
@quaresmajose quaresmajose deleted the remove-meta-ti-extras branch January 18, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants