Skip to content

setup-environment-internal: fix regressions#417

Merged
ricardosalveti merged 3 commits intofoundriesio:mainfrom
quaresmajose:setup-environment-internal
Jan 26, 2024
Merged

setup-environment-internal: fix regressions#417
ricardosalveti merged 3 commits intofoundriesio:mainfrom
quaresmajose:setup-environment-internal

Conversation

@quaresmajose
Copy link
Copy Markdown
Member

No description provided.

@quaresmajose quaresmajose requested a review from a team January 25, 2024 17:48
@quaresmajose quaresmajose added the ok-to-test Requires OK for testing to proceed label Jan 25, 2024
Comment thread setup-environment-internal
Comment thread setup-environment-internal Outdated
Comment thread setup-environment-internal Outdated
Comment thread setup-environment-internal
@quaresmajose quaresmajose removed the ok-to-test Requires OK for testing to proceed label Jan 25, 2024
@quaresmajose quaresmajose force-pushed the setup-environment-internal branch from b461ece to 76e4eb8 Compare January 25, 2024 18:16
Comment thread setup-environment-internal Outdated
@quaresmajose quaresmajose added ok-to-test Requires OK for testing to proceed and removed ok-to-test Requires OK for testing to proceed labels Jan 25, 2024
We can't delete the LMP_VERSION_CACHE on CI because
it is still needed in several places even after being used here.
So add a new check that checks where we are executing.

Signed-off-by: Jose Quaresma <[email protected]>
@quaresmajose quaresmajose force-pushed the setup-environment-internal branch from 76e4eb8 to bc4663c Compare January 26, 2024 09:28
^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.

Signed-off-by: Jose Quaresma <[email protected]>
@quaresmajose quaresmajose added the ok-to-test Requires OK for testing to proceed label Jan 26, 2024
Copy link
Copy Markdown
Member

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardosalveti ricardosalveti merged commit 7365f29 into foundriesio:main Jan 26, 2024
@quaresmajose quaresmajose deleted the setup-environment-internal branch January 26, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Requires OK for testing to proceed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants