Dockerfile: Add docker CLI and compose CLI plugin#208
Merged
ricardosalveti merged 1 commit intomainfrom Aug 8, 2022
Merged
Conversation
mike-sul
force-pushed
the
add-docker-compose
branch
2 times, most recently
from
2bd9549 to
76510f9
Compare
Contributor
Author
doanac
reviewed
Aug 8, 2022
| RUN mkdir -p /etc/apt/keyrings \ | ||
| && curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo gpg --dearmor -o /etc/apt/keyrings/docker.gpg \ | ||
| && echo "deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/docker.gpg] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable" | tee /etc/apt/sources.list.d/docker.list > /dev/null \ | ||
| && apt-get update && apt-get install -y docker-ce-cli=5:20.10.14~3-0~ubuntu-focal |
Member
There was a problem hiding this comment.
the stuff above this clears out the apt-cache after installing things to produce a smaller image. maybe we should fold this into that logic or also clear out the apt-cache here.
Contributor
Author
There was a problem hiding this comment.
added apt-get clean to clean the cache.
mike-sul
force-pushed
the
add-docker-compose
branch
from
76510f9 to
fff161f
Compare
doanac
reviewed
Aug 8, 2022
| && curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo gpg --dearmor -o /etc/apt/keyrings/docker.gpg \ | ||
| && echo "deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/docker.gpg] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable" | tee /etc/apt/sources.list.d/docker.list > /dev/null \ | ||
| && apt-get update && apt-get install -y docker-ce-cli=5:20.10.14~3-0~ubuntu-focal \ | ||
| && apt-get clean |
Member
There was a problem hiding this comment.
you also need - && rm -rf /var/lib/apt/lists/*
Contributor
Author
There was a problem hiding this comment.
ok, I added, not sure it makes significant difference though.
Member
There was a problem hiding this comment.
i have no idea, mine is 254M, but i don't clean it ever.
The "oe-builtin" App preload requires `docker compose` utility now since we moved from the python-based `docker-compose` to the golang-based plugin of `docker` CLI utility. Signed-off-by: Mike <[email protected]>
mike-sul
force-pushed
the
add-docker-compose
branch
from
fff161f to
3ed4303
Compare
doanac
approved these changes
Aug 8, 2022
| RUN mkdir -p /etc/apt/keyrings \ | ||
| && curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo gpg --dearmor -o /etc/apt/keyrings/docker.gpg \ | ||
| && echo "deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/docker.gpg] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable" | tee /etc/apt/sources.list.d/docker.list > /dev/null \ | ||
| && apt-get update && apt-get install -y docker-ce-cli=5:20.10.14~3-0~ubuntu-focal \ |
Member
There was a problem hiding this comment.
It seems they are not removing older ce-cli packages, but this might cause the dockerfile to fail on rebuilds in case they decide to clean it up.
I think it is ok for now, but we might just have to switch to latest at some point.
ricardosalveti
approved these changes
Aug 8, 2022
Tim-Anderson
pushed a commit
to Tim-Anderson/lmp-manifest
that referenced
this pull request
Aug 30, 2022
Relevant changes: - d323df3 Merge pull request foundriesio#208 from Freescale/backport-207-to-honister - 32aff9b linux-boundary: bump revision to bb58f0ee - b123854 Merge pull request foundriesio#204 from boundarydevices/honister - 9e698af u-boot-boundary: fix fw_env.config management - b4df0cf Merge pull request foundriesio#201 from chrisdimich/honister - 2ebd2e0 nitrogen8mp: Define nxp as default BSP - 657e750 Merge pull request foundriesio#200 from chrisdimich/honister - 8f6984a u-boot-boundary: bump revision to 3d5e7f60 - b30688b linux-boundary: bump revision to 04f4286f Signed-off-by: Ricardo Salveti <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "oe-builtin" App preload requires
docker composeutility sincewe moved from the python-based
docker-composeto the golang-basedplugin of
dockerCLI utility.Signed-off-by: Mike [email protected]