Skip to content

dockerfile: Add ostreeuploader/fiopush/fiocheck#178

Merged
ricardosalveti merged 1 commit intomainfrom
add-ostreeuploader
Apr 18, 2022
Merged

dockerfile: Add ostreeuploader/fiopush/fiocheck#178
ricardosalveti merged 1 commit intomainfrom
add-ostreeuploader

Conversation

@mike-sul
Copy link
Copy Markdown
Contributor

@mike-sul mike-sul commented Apr 12, 2022

  • Update Dockerfile to build ostreeuploader and include the resultant executables into the image top layer.

Signed-off-by: Mike Sul [email protected]

@mike-sul mike-sul mentioned this pull request Apr 12, 2022
Merged
@mike-sul mike-sul force-pushed the add-ostreeuploader branch from 03ae1a4 to a5f2559 Compare April 13, 2022 07:49
@mike-sul mike-sul marked this pull request as ready for review April 13, 2022 07:50
@mike-sul
Copy link
Copy Markdown
Contributor Author

mike-sul commented Apr 14, 2022

@ricardosalveti Can it be merged?

ricardosalveti
ricardosalveti reviewed Apr 17, 2022
View reviewed changes
Comment thread Dockerfile Outdated
ENV PATH /usr/local/go/bin:$PATH

RUN git clone https://github.com/foundriesio/ostreeuploader.git /ostreeuploader && \
cd /ostreeuploader && git checkout ae83a2188808fd6188adb25ac72dffd4beaadd3d && \
Copy link
Copy Markdown
Member

@ricardosalveti ricardosalveti Apr 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a tag to use instead of a fixed hash?

Copy link
Copy Markdown
Contributor Author

@mike-sul mike-sul Apr 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

ricardosalveti
ricardosalveti reviewed Apr 17, 2022
View reviewed changes
Comment thread Dockerfile Outdated
RUN sudo -u $DEV_USER -H git config --global credential.helper 'cache --timeout=3600'

# Install ostreeuploader, aka fiopush/fiocheck
COPY --from=0 /ostreeuploader/bin/fiopush /usr/bin/
Copy link
Copy Markdown
Member

@ricardosalveti ricardosalveti Apr 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to update to use a named stage instead of 0, to avoid possible issue in the future related to the order of the changes.

Copy link
Copy Markdown
Contributor Author

@mike-sul mike-sul Apr 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

ricardosalveti
ricardosalveti reviewed Apr 17, 2022
View reviewed changes
Comment thread Dockerfile
@mike-sul mike-sul force-pushed the add-ostreeuploader branch from a5f2559 to 3e5372c Compare April 18, 2022 11:20
ricardosalveti
ricardosalveti approved these changes Apr 18, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge and give this a try today to make sure we don't generate any regression.

@ricardosalveti ricardosalveti merged commit d53d3a1 into main Apr 18, 2022
@mike-sul
Copy link
Copy Markdown
Contributor Author

mike-sul commented Apr 18, 2022

It works, the containers' fiotools were used in this build https://ci.foundries.io/projects/msul-dev01/lmp/builds/1294/raspberrypi4-64/artifacts/console.log

ricardosalveti added a commit to ricardosalveti/lmp-manifest that referenced this pull request May 25, 2022
@ricardosalveti
lmp-bsp: update meta-freescale-3rdparty layer
ae256e6 
Relevant changes:
- de0eb14 Merge pull request foundriesio#210 from YoeDistro/yoe/mut
- 1bf66f8 linux-firmware: Use nonarch_base_libdir instead of hardcoding /lib
- 478e0c4 Merge pull request foundriesio#209 from YoeDistro/yoe/mut
- 7ca49de ti-18xx-wlconf: Drop spurious dot from PV
- aff7e79 ti-18xx-wlconf: Use nonarch_base_libdir instead of hardcoding /lib
- f244dd4 Merge pull request foundriesio#207 from chrisdimich/master
- d52f46a linux-boundary: bump revision to bb58f0ee
- 1e88fc2 Merge pull request foundriesio#206 from Ossanes/topic/fix-nitrogen8-boards
- 47d2543 nitrogen*: Drop duplicated WKS dependencies
- b806279 nitrogen8*: Drop useless overrides for WKS_FILE_DEPENDS
- 18912db Merge pull request foundriesio#203 from boundarydevices/master
- 4d1b126 u-boot-boundary: fix fw_env.config management
- bd3eb22 u-boot-boundary: switch filesextrapaths to generic-bsp
- 7596527 Merge pull request foundriesio#202 from YoeDistro/yoe/mut
- 1efcb1b recipes: Use SPDX naming scheme for LICENSE field
- a27ac73 Merge pull request foundriesio#199 from chrisdimich/master
- b30a5bc u-boot-boundary: bump revision to 3d5e7f60
- 4d7c7c5 linux-boundary: bump revision to 04f4286f
- f467829 Merge pull request foundriesio#198 from Ossanes/topic/linux-kontron
- 100b41b linux-kontron: defconfig: Rework to enable CONFIG_KPROBES
- d236514 linux-kontron: Upgrade 5.4.41>5.10.95
- dc91d5e Merge pull request foundriesio#197 from Freescale/topic/simplify-overrides
- b034e5c Rework machine definitions to reduce duplication
- bf7ae43 u-boot-script-toradex: Revert wrong override change
- 671aee4 Generalize overrides subsystem for NXP and Mainline support
- a161b3a Merge pull request foundriesio#196 from Ossanes/topic/nitrogen8mp
- 52e9a93 nitrogen8mp: Define nxp as default BSP
- 10a470a Merge pull request foundriesio#195 from YoeDistro/yoe/mut
- 4560e22 layers: Bump to use kirkstone
- 0c68a5a Merge pull request foundriesio#193 from Ossanes/topic/imx7d-remarkable2-remove-firmwares
- 654d5b5 imx7d-remarkable2: Remove bcm43456 firmware as it has no providers
- f8d9213 Merge pull request foundriesio#192 from Ossanes/topic/imx6dl-riotboard-uboot
- e78de66 imx6dl-riotboard: Fix u-boot target
- 6059586 Merge pull request foundriesio#191 from sapiippo/apalis-imx6
- 61b70a0 apalis-imx6: add missing space to append
- b3670f9 Merge pull request foundriesio#190 from MaxKrummenacher/master
- e064d0e colibri-imx6ull: fix mistyped override
- b26df7f Merge pull request foundriesio#187 from boundarydevices/master
- 748b8f0 linux-boundary: bump revision to acef1311
- f007a9f Merge pull request foundriesio#185 from MaxKrummenacher/update-toradex
- 13bd2ac machines: toradex: update
- 02bff68 linux-toradex: vf: update to 4.4.291
- 74fc138 linux-toradex: imx: update to 5.4-2.3.x-imx
- a2c343e u-boot-script-toradex: improve script
- 6e8f05b u-boot-toradex: updated to latest
- 839df32 u-boot-toradex: drop inc file
- 4661bdc Merge pull request foundriesio#184 from texierp/topic/git-fetcher
- be54937 recipes: use https protocol and add explicit branch parameter
- be3442a Merge pull request foundriesio#183 from Ossanes/topic/remove-dms-ba16
- f6c6d9e Merge pull request foundriesio#182 from Ossanes/topic/remove-congatec
- 5dc9275 imx6q-dms-ba16: Remove files because it is not being maintained
- 00acf49 congatec: Remove defconfig
- af1c0cb Merge pull request foundriesio#181 from Ossanes/topic/remove-congatec
- 3777793 congatec: Remove files because it is not being maintained
- 557e7b6 Merge pull request foundriesio#180 from Ossanes/topic/u-boot-script-gateworks-imx
- d57becc u-boot-script-gateworks-imx.bb: Fix license checksum
- ea36713 Merge pull request foundriesio#178 from Ossanes/topic/linux-remarkable
- 322f7f9 linux-remarkable2_5.4.bb: Fix git revision
- 5ed5d23 Merge pull request foundriesio#177 from Ossanes/topic/imx6sl-warp-uboot
- 18f54fa imx6sl-warp: Fix u-boot suffix
- c57b5f3 Merge pull request foundriesio#176 from Ossanes/topic/riotboard-suffix
- a9fce64 imx6dl-riotboard: Fix u-boot suffix

Signed-off-by: Ricardo Salveti <[email protected]>
ricardosalveti added a commit to ricardosalveti/lmp-manifest that referenced this pull request May 25, 2022
@ricardosalveti
lmp-bsp: update meta-freescale-3rdparty layer
a4aea21 
Relevant changes:
- de0eb14 Merge pull request foundriesio#210 from YoeDistro/yoe/mut
- 1bf66f8 linux-firmware: Use nonarch_base_libdir instead of hardcoding /lib
- 478e0c4 Merge pull request foundriesio#209 from YoeDistro/yoe/mut
- 7ca49de ti-18xx-wlconf: Drop spurious dot from PV
- aff7e79 ti-18xx-wlconf: Use nonarch_base_libdir instead of hardcoding /lib
- f244dd4 Merge pull request foundriesio#207 from chrisdimich/master
- d52f46a linux-boundary: bump revision to bb58f0ee
- 1e88fc2 Merge pull request foundriesio#206 from Ossanes/topic/fix-nitrogen8-boards
- 47d2543 nitrogen*: Drop duplicated WKS dependencies
- b806279 nitrogen8*: Drop useless overrides for WKS_FILE_DEPENDS
- 18912db Merge pull request foundriesio#203 from boundarydevices/master
- 4d1b126 u-boot-boundary: fix fw_env.config management
- bd3eb22 u-boot-boundary: switch filesextrapaths to generic-bsp
- 7596527 Merge pull request foundriesio#202 from YoeDistro/yoe/mut
- 1efcb1b recipes: Use SPDX naming scheme for LICENSE field
- a27ac73 Merge pull request foundriesio#199 from chrisdimich/master
- b30a5bc u-boot-boundary: bump revision to 3d5e7f60
- 4d7c7c5 linux-boundary: bump revision to 04f4286f
- f467829 Merge pull request foundriesio#198 from Ossanes/topic/linux-kontron
- 100b41b linux-kontron: defconfig: Rework to enable CONFIG_KPROBES
- d236514 linux-kontron: Upgrade 5.4.41>5.10.95
- dc91d5e Merge pull request foundriesio#197 from Freescale/topic/simplify-overrides
- b034e5c Rework machine definitions to reduce duplication
- bf7ae43 u-boot-script-toradex: Revert wrong override change
- 671aee4 Generalize overrides subsystem for NXP and Mainline support
- a161b3a Merge pull request foundriesio#196 from Ossanes/topic/nitrogen8mp
- 52e9a93 nitrogen8mp: Define nxp as default BSP
- 10a470a Merge pull request foundriesio#195 from YoeDistro/yoe/mut
- 4560e22 layers: Bump to use kirkstone
- 0c68a5a Merge pull request foundriesio#193 from Ossanes/topic/imx7d-remarkable2-remove-firmwares
- 654d5b5 imx7d-remarkable2: Remove bcm43456 firmware as it has no providers
- f8d9213 Merge pull request foundriesio#192 from Ossanes/topic/imx6dl-riotboard-uboot
- e78de66 imx6dl-riotboard: Fix u-boot target
- 6059586 Merge pull request foundriesio#191 from sapiippo/apalis-imx6
- 61b70a0 apalis-imx6: add missing space to append
- b3670f9 Merge pull request foundriesio#190 from MaxKrummenacher/master
- e064d0e colibri-imx6ull: fix mistyped override
- b26df7f Merge pull request foundriesio#187 from boundarydevices/master
- 748b8f0 linux-boundary: bump revision to acef1311
- f007a9f Merge pull request foundriesio#185 from MaxKrummenacher/update-toradex
- 13bd2ac machines: toradex: update
- 02bff68 linux-toradex: vf: update to 4.4.291
- 74fc138 linux-toradex: imx: update to 5.4-2.3.x-imx
- a2c343e u-boot-script-toradex: improve script
- 6e8f05b u-boot-toradex: updated to latest
- 839df32 u-boot-toradex: drop inc file
- 4661bdc Merge pull request foundriesio#184 from texierp/topic/git-fetcher
- be54937 recipes: use https protocol and add explicit branch parameter
- be3442a Merge pull request foundriesio#183 from Ossanes/topic/remove-dms-ba16
- f6c6d9e Merge pull request foundriesio#182 from Ossanes/topic/remove-congatec
- 5dc9275 imx6q-dms-ba16: Remove files because it is not being maintained
- 00acf49 congatec: Remove defconfig
- af1c0cb Merge pull request foundriesio#181 from Ossanes/topic/remove-congatec
- 3777793 congatec: Remove files because it is not being maintained
- 557e7b6 Merge pull request foundriesio#180 from Ossanes/topic/u-boot-script-gateworks-imx
- d57becc u-boot-script-gateworks-imx.bb: Fix license checksum
- ea36713 Merge pull request foundriesio#178 from Ossanes/topic/linux-remarkable
- 322f7f9 linux-remarkable2_5.4.bb: Fix git revision
- 5ed5d23 Merge pull request foundriesio#177 from Ossanes/topic/imx6sl-warp-uboot
- 18f54fa imx6sl-warp: Fix u-boot suffix
- c57b5f3 Merge pull request foundriesio#176 from Ossanes/topic/riotboard-suffix
- a9fce64 imx6dl-riotboard: Fix u-boot suffix

Signed-off-by: Ricardo Salveti <[email protected]>
ricardosalveti added a commit to ricardosalveti/lmp-manifest that referenced this pull request May 27, 2022
@ricardosalveti
lmp-bsp: update meta-freescale-3rdparty layer
2c0dc86 
Relevant changes:
- de0eb14 Merge pull request foundriesio#210 from YoeDistro/yoe/mut
- 1bf66f8 linux-firmware: Use nonarch_base_libdir instead of hardcoding /lib
- 478e0c4 Merge pull request foundriesio#209 from YoeDistro/yoe/mut
- 7ca49de ti-18xx-wlconf: Drop spurious dot from PV
- aff7e79 ti-18xx-wlconf: Use nonarch_base_libdir instead of hardcoding /lib
- f244dd4 Merge pull request foundriesio#207 from chrisdimich/master
- d52f46a linux-boundary: bump revision to bb58f0ee
- 1e88fc2 Merge pull request foundriesio#206 from Ossanes/topic/fix-nitrogen8-boards
- 47d2543 nitrogen*: Drop duplicated WKS dependencies
- b806279 nitrogen8*: Drop useless overrides for WKS_FILE_DEPENDS
- 18912db Merge pull request foundriesio#203 from boundarydevices/master
- 4d1b126 u-boot-boundary: fix fw_env.config management
- bd3eb22 u-boot-boundary: switch filesextrapaths to generic-bsp
- 7596527 Merge pull request foundriesio#202 from YoeDistro/yoe/mut
- 1efcb1b recipes: Use SPDX naming scheme for LICENSE field
- a27ac73 Merge pull request foundriesio#199 from chrisdimich/master
- b30a5bc u-boot-boundary: bump revision to 3d5e7f60
- 4d7c7c5 linux-boundary: bump revision to 04f4286f
- f467829 Merge pull request foundriesio#198 from Ossanes/topic/linux-kontron
- 100b41b linux-kontron: defconfig: Rework to enable CONFIG_KPROBES
- d236514 linux-kontron: Upgrade 5.4.41>5.10.95
- dc91d5e Merge pull request foundriesio#197 from Freescale/topic/simplify-overrides
- b034e5c Rework machine definitions to reduce duplication
- bf7ae43 u-boot-script-toradex: Revert wrong override change
- 671aee4 Generalize overrides subsystem for NXP and Mainline support
- a161b3a Merge pull request foundriesio#196 from Ossanes/topic/nitrogen8mp
- 52e9a93 nitrogen8mp: Define nxp as default BSP
- 10a470a Merge pull request foundriesio#195 from YoeDistro/yoe/mut
- 4560e22 layers: Bump to use kirkstone
- 0c68a5a Merge pull request foundriesio#193 from Ossanes/topic/imx7d-remarkable2-remove-firmwares
- 654d5b5 imx7d-remarkable2: Remove bcm43456 firmware as it has no providers
- f8d9213 Merge pull request foundriesio#192 from Ossanes/topic/imx6dl-riotboard-uboot
- e78de66 imx6dl-riotboard: Fix u-boot target
- 6059586 Merge pull request foundriesio#191 from sapiippo/apalis-imx6
- 61b70a0 apalis-imx6: add missing space to append
- b3670f9 Merge pull request foundriesio#190 from MaxKrummenacher/master
- e064d0e colibri-imx6ull: fix mistyped override
- b26df7f Merge pull request foundriesio#187 from boundarydevices/master
- 748b8f0 linux-boundary: bump revision to acef1311
- f007a9f Merge pull request foundriesio#185 from MaxKrummenacher/update-toradex
- 13bd2ac machines: toradex: update
- 02bff68 linux-toradex: vf: update to 4.4.291
- 74fc138 linux-toradex: imx: update to 5.4-2.3.x-imx
- a2c343e u-boot-script-toradex: improve script
- 6e8f05b u-boot-toradex: updated to latest
- 839df32 u-boot-toradex: drop inc file
- 4661bdc Merge pull request foundriesio#184 from texierp/topic/git-fetcher
- be54937 recipes: use https protocol and add explicit branch parameter
- be3442a Merge pull request foundriesio#183 from Ossanes/topic/remove-dms-ba16
- f6c6d9e Merge pull request foundriesio#182 from Ossanes/topic/remove-congatec
- 5dc9275 imx6q-dms-ba16: Remove files because it is not being maintained
- 00acf49 congatec: Remove defconfig
- af1c0cb Merge pull request foundriesio#181 from Ossanes/topic/remove-congatec
- 3777793 congatec: Remove files because it is not being maintained
- 557e7b6 Merge pull request foundriesio#180 from Ossanes/topic/u-boot-script-gateworks-imx
- d57becc u-boot-script-gateworks-imx.bb: Fix license checksum
- ea36713 Merge pull request foundriesio#178 from Ossanes/topic/linux-remarkable
- 322f7f9 linux-remarkable2_5.4.bb: Fix git revision
- 5ed5d23 Merge pull request foundriesio#177 from Ossanes/topic/imx6sl-warp-uboot
- 18f54fa imx6sl-warp: Fix u-boot suffix
- c57b5f3 Merge pull request foundriesio#176 from Ossanes/topic/riotboard-suffix
- a9fce64 imx6dl-riotboard: Fix u-boot suffix

Signed-off-by: Ricardo Salveti <[email protected]>
ricardosalveti added a commit that referenced this pull request May 27, 2022
@ricardosalveti
lmp-bsp: update meta-freescale-3rdparty layer
2fd3052 
Relevant changes:
- de0eb14 Merge pull request #210 from YoeDistro/yoe/mut
- 1bf66f8 linux-firmware: Use nonarch_base_libdir instead of hardcoding /lib
- 478e0c4 Merge pull request #209 from YoeDistro/yoe/mut
- 7ca49de ti-18xx-wlconf: Drop spurious dot from PV
- aff7e79 ti-18xx-wlconf: Use nonarch_base_libdir instead of hardcoding /lib
- f244dd4 Merge pull request #207 from chrisdimich/master
- d52f46a linux-boundary: bump revision to bb58f0ee
- 1e88fc2 Merge pull request #206 from Ossanes/topic/fix-nitrogen8-boards
- 47d2543 nitrogen*: Drop duplicated WKS dependencies
- b806279 nitrogen8*: Drop useless overrides for WKS_FILE_DEPENDS
- 18912db Merge pull request #203 from boundarydevices/master
- 4d1b126 u-boot-boundary: fix fw_env.config management
- bd3eb22 u-boot-boundary: switch filesextrapaths to generic-bsp
- 7596527 Merge pull request #202 from YoeDistro/yoe/mut
- 1efcb1b recipes: Use SPDX naming scheme for LICENSE field
- a27ac73 Merge pull request #199 from chrisdimich/master
- b30a5bc u-boot-boundary: bump revision to 3d5e7f60
- 4d7c7c5 linux-boundary: bump revision to 04f4286f
- f467829 Merge pull request #198 from Ossanes/topic/linux-kontron
- 100b41b linux-kontron: defconfig: Rework to enable CONFIG_KPROBES
- d236514 linux-kontron: Upgrade 5.4.41>5.10.95
- dc91d5e Merge pull request #197 from Freescale/topic/simplify-overrides
- b034e5c Rework machine definitions to reduce duplication
- bf7ae43 u-boot-script-toradex: Revert wrong override change
- 671aee4 Generalize overrides subsystem for NXP and Mainline support
- a161b3a Merge pull request #196 from Ossanes/topic/nitrogen8mp
- 52e9a93 nitrogen8mp: Define nxp as default BSP
- 10a470a Merge pull request #195 from YoeDistro/yoe/mut
- 4560e22 layers: Bump to use kirkstone
- 0c68a5a Merge pull request #193 from Ossanes/topic/imx7d-remarkable2-remove-firmwares
- 654d5b5 imx7d-remarkable2: Remove bcm43456 firmware as it has no providers
- f8d9213 Merge pull request #192 from Ossanes/topic/imx6dl-riotboard-uboot
- e78de66 imx6dl-riotboard: Fix u-boot target
- 6059586 Merge pull request #191 from sapiippo/apalis-imx6
- 61b70a0 apalis-imx6: add missing space to append
- b3670f9 Merge pull request #190 from MaxKrummenacher/master
- e064d0e colibri-imx6ull: fix mistyped override
- b26df7f Merge pull request #187 from boundarydevices/master
- 748b8f0 linux-boundary: bump revision to acef1311
- f007a9f Merge pull request #185 from MaxKrummenacher/update-toradex
- 13bd2ac machines: toradex: update
- 02bff68 linux-toradex: vf: update to 4.4.291
- 74fc138 linux-toradex: imx: update to 5.4-2.3.x-imx
- a2c343e u-boot-script-toradex: improve script
- 6e8f05b u-boot-toradex: updated to latest
- 839df32 u-boot-toradex: drop inc file
- 4661bdc Merge pull request #184 from texierp/topic/git-fetcher
- be54937 recipes: use https protocol and add explicit branch parameter
- be3442a Merge pull request #183 from Ossanes/topic/remove-dms-ba16
- f6c6d9e Merge pull request #182 from Ossanes/topic/remove-congatec
- 5dc9275 imx6q-dms-ba16: Remove files because it is not being maintained
- 00acf49 congatec: Remove defconfig
- af1c0cb Merge pull request #181 from Ossanes/topic/remove-congatec
- 3777793 congatec: Remove files because it is not being maintained
- 557e7b6 Merge pull request #180 from Ossanes/topic/u-boot-script-gateworks-imx
- d57becc u-boot-script-gateworks-imx.bb: Fix license checksum
- ea36713 Merge pull request #178 from Ossanes/topic/linux-remarkable
- 322f7f9 linux-remarkable2_5.4.bb: Fix git revision
- 5ed5d23 Merge pull request #177 from Ossanes/topic/imx6sl-warp-uboot
- 18f54fa imx6sl-warp: Fix u-boot suffix
- c57b5f3 Merge pull request #176 from Ossanes/topic/riotboard-suffix
- a9fce64 imx6dl-riotboard: Fix u-boot suffix

Signed-off-by: Ricardo Salveti <[email protected]>
@ricardosalveti ricardosalveti deleted the add-ostreeuploader branch May 5, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@doanac doanac doanac approved these changes

@ricardosalveti ricardosalveti ricardosalveti approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mike-sul @doanac @ricardosalveti