Conversation
mike-sul
force-pushed
the
resettable-apps-config
branch
from
722c0c2 to
b0dfd09
Compare
doanac
left a comment
doanac
left a comment
There was a problem hiding this comment.
I feel like a "--reset-apps" option is going to feel confusing like "I want to reset the apps", but I can't think of a better thing to call it that wouldn't also be confusing.
|
@rsalveti - you might want to watch what happens with this also. |
maybe |
|
I like "restorable-apps" |
|
Also +1 for restorable-apps. |
mike-sul
force-pushed
the
resettable-apps-config
branch
from
b0dfd09 to
0cb340f
Compare
|
@doanac @ricardosalveti I made it "restorable". |
| "It's set to an empty list automatically if not specified and a system image is preloaded with Restorable Apps." | ||
| "Restorable App list = UNION(compose-apps, restorable-apps),") |
There was a problem hiding this comment.
I don't want to nit, but I've read this sentence a few times and the "if not specified" part keeps making me think you can't turn off restorable apps. i.e it defaults to all. Then I read your code comments and it becomes clear and expected. I think you should incorporate the comments into the usage message. They are more clear.
- Added a new param `--restorable-apps`; - If not specified then Restorable Apps are OFF; - If specified just `--restorable-apps` with no value then turn Restorable Apps ON and use `compose_apps` as an App list; - If `--restorable-apps` is specified and defined with a value then a list of resettable Apps == UNION(reset_apps, compose_apps); - If `--restorable-apps` is not specified, but a system image is preloaded with Restorable Apps then turn Restorable Apps ON. Signed-off-by: Mike Sul <[email protected]>
mike-sul
force-pushed
the
resettable-apps-config
branch
from
0cb340f to
e769f81
Compare
3 participants
--restorable-apps--restorable-appswith no value then turn Restorable Apps ON and usecompose_appsas an App list--restorable-appsis specified and defined with a value then a list of restorable Apps == UNION(reset_apps, compose_apps)Signed-off-by: Mike Sul [email protected]