Remove hard-coded usage of aktualizr-lite#27
Merged
doanac merged 1 commit intofoundriesio:masterfrom Sep 26, 2021
Merged
Conversation
meta-updater code in OE allows the actual ota client to be configurable via the SOTA_CLIENT setting. This change removes our hard coded dependency on aktualizr-lite so that it can be used with any proper SOTA_CLIENT. Signed-off-by: Andy Doan <[email protected]>
| try { | ||
| if (!lock.try_lock_sharable()) { | ||
| cerr << "ERROR: aktualizr-lite daemon appears to be running" << endl; | ||
| cerr << "ERROR: " SOTA_CLIENT " daemon appears to be running" << endl; |
Member
There was a problem hiding this comment.
Here we're assuming that the custom client will also use the same lock file (/var/lock/aklite.lock), is this something done/handled by the lite library as well?
Member
Author
There was a problem hiding this comment.
I think the library should handle this, so the name is fine. That said - the library isn't doing the lock, so i need to work on that logic now also. can be done independently of this.
| cout << "Starting aktualizr-lite daemon" << endl; | ||
| _spawn("systemctl start aktualizr-lite"); | ||
| cout << "Starting " SOTA_CLIENT " daemon" << endl; | ||
| _spawn("systemctl start " SOTA_CLIENT); |
Member
There was a problem hiding this comment.
Same here but for the systemd service job, but I think this should be fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
meta-updater code in OE allows the actual ota client to be configurable
via the SOTA_CLIENT setting. This change removes our hard coded
dependency on aktualizr-lite so that it can be used with any proper
SOTA_CLIENT.
Signed-off-by: Andy Doan [email protected]