net: lan78xx: fix "softirq work is pending" error

olerem · kuba-moo · commit e3d5d70cb483 · 2024-02-27T18:21:51.000-08:00
Disable BH around the call to napi_schedule() to avoid following error: NOHZ tick-stop error: local softirq work is pending, handler #8!!! Fixes: ec4c7e1 ("lan78xx: Introduce NAPI polling support") Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> Link: https://lore.kernel.org/r/20240226110820.2113584-1-o.rempel@pengutronix.de Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
@@ -1501,7 +1501,9 @@ static int lan78xx_link_reset(struct lan78xx_net *dev)
 
 		lan78xx_rx_urb_submit_all(dev);
 
+		local_bh_disable();
 		napi_schedule(&dev->napi);
+		local_bh_enable();
 	}
 
 	return 0;

Original file line number	Diff line number	Diff line change
`@@ -1501,7 +1501,9 @@ static int lan78xx_link_reset(struct lan78xx_net *dev)`
`1501`	`1501`
`1502`	`1502`	`lan78xx_rx_urb_submit_all(dev);`
`1503`	`1503`
	`1504`	`+ local_bh_disable();`
`1504`	`1505`	`napi_schedule(&dev->napi);`
	`1506`	`+ local_bh_enable();`
`1505`	`1507`	`}`
`1506`	`1508`
`1507`	`1509`	`return 0;`